From: Conor Dooley <conor@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
Cc: linux-edac@vger.kernel.org, git@amd.com,
shubhrajyoti.datta@gmail.com,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i3c: dw: Add VersalNet compatible string
Date: Tue, 21 Apr 2026 18:17:54 +0100 [thread overview]
Message-ID: <20260421-exorcist-panther-d43470a97cec@spud> (raw)
In-Reply-To: <20260421103059.2484623-3-shubhrajyoti.datta@amd.com>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Tue, Apr 21, 2026 at 04:00:59PM +0530, Shubhrajyoti Datta wrote:
> Add amd,versalnet-dw-i3c-master to the of_match table with
> snps,dw-i3c-master-1.00a as the generic fallback.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---
>
> drivers/i3c/master/dw-i3c-master.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index d6bdb32397fb..69fef7fdda37 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1845,6 +1845,7 @@ static const struct of_device_id dw_i3c_master_of_match[] = {
> { .compatible = "altr,agilex5-dw-i3c-master",
> .data = &altr_agilex5_drvdata,
> },
> + { .compatible = "amd,versalnet-dw-i3c-master", },
This shouldn't be needed, you use the snps compatible as a fallback and
have no driver data.
> {},
> };
> MODULE_DEVICE_TABLE(of, dw_i3c_master_of_match);
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-04-21 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 10:30 [PATCH 0/2] i3c: dw: Add AMD VersalNet I3C compatible string Shubhrajyoti Datta
2026-04-21 10:30 ` [PATCH 1/2] dt-bindings: i3c: dw: Add VersalNet " Shubhrajyoti Datta
2026-04-21 17:17 ` Conor Dooley
2026-04-21 10:30 ` [PATCH 2/2] " Shubhrajyoti Datta
2026-04-21 17:17 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421-exorcist-panther-d43470a97cec@spud \
--to=conor@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzk+dt@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=shubhrajyoti.datta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox