Re: [PATCH 1/2] dt-bindings: i3c: dw: Add VersalNet compatible string

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Tue, Apr 21, 2026 at 04:00:58PM +0530, Shubhrajyoti Datta wrote:
> Add amd,versalnet-dw-i3c-master as a vendor-specific compatible
> for the i3c ip available on Versal NET SOC.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---
> 
>  Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f55..98dafec0ace5 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -18,6 +18,7 @@ properties:
>        - const: snps,dw-i3c-master-1.00a
>        - items:
>            - const: altr,agilex5-dw-i3c-master
> +          - const: amd,versalnet-dw-i3c-master
>            - const: snps,dw-i3c-master-1.00a

Yeah, no... This will just introduce warnings for the existing platform
and is incorrect on your platform because the altera compatible will
match before yours, dragging in the quirk that platform has.

You need to make this into and enum with your new compatible and the
altera one, with a fallback to the snps one.

pw-bot: changes-requested

>  
>    reg:
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]