[PATCH 0/2] i3c: dw: Add AMD VersalNet I3C compatible string

[PATCH 0/2] i3c: dw: Add AMD VersalNet I3C compatible string

[Shubhrajyoti Datta]

This series adds support for the AMD VersalNet SoC to the
Synopsys DesignWare I3C master driver by introducing the
vendor-specific compatible string amd,versalnet-dw-i3c-master
for I3C in VersalNet platforms.

The request for the addition was in the below thread
https://lore.kernel.org/all/LV5PR12MB9828D700D168803CBD022A708151A@LV5PR12MB9828.namprd12.prod.outlook.com/


Shubhrajyoti Datta (2):
  dt-bindings: i3c: dw: Add VersalNet compatible string
  i3c: dw: Add VersalNet compatible string

 Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 1 +
 drivers/i3c/master/dw-i3c-master.c                            | 1 +
 2 files changed, 2 insertions(+)

-- 
2.34.1

[PATCH 1/2] dt-bindings: i3c: dw: Add VersalNet compatible string

[Shubhrajyoti Datta]

Add amd,versalnet-dw-i3c-master as a vendor-specific compatible
for the i3c ip available on Versal NET SOC.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---

 Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
index e803457d3f55..98dafec0ace5 100644
--- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
+++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
@@ -18,6 +18,7 @@ properties:
       - const: snps,dw-i3c-master-1.00a
       - items:
           - const: altr,agilex5-dw-i3c-master
+          - const: amd,versalnet-dw-i3c-master
           - const: snps,dw-i3c-master-1.00a
 
   reg:
-- 
2.34.1

[PATCH 2/2] i3c: dw: Add VersalNet compatible string

[Shubhrajyoti Datta]

Add amd,versalnet-dw-i3c-master to the of_match table with
snps,dw-i3c-master-1.00a as the generic fallback.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---

 drivers/i3c/master/dw-i3c-master.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index d6bdb32397fb..69fef7fdda37 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -1845,6 +1845,7 @@ static const struct of_device_id dw_i3c_master_of_match[] = {
 	{ .compatible = "altr,agilex5-dw-i3c-master",
 	  .data = &altr_agilex5_drvdata,
 	},
+	{ .compatible = "amd,versalnet-dw-i3c-master", },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dw_i3c_master_of_match);
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: i3c: dw: Add VersalNet compatible string

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Tue, Apr 21, 2026 at 04:00:58PM +0530, Shubhrajyoti Datta wrote:
> Add amd,versalnet-dw-i3c-master as a vendor-specific compatible
> for the i3c ip available on Versal NET SOC.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---
> 
>  Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f55..98dafec0ace5 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -18,6 +18,7 @@ properties:
>        - const: snps,dw-i3c-master-1.00a
>        - items:
>            - const: altr,agilex5-dw-i3c-master
> +          - const: amd,versalnet-dw-i3c-master
>            - const: snps,dw-i3c-master-1.00a

Yeah, no... This will just introduce warnings for the existing platform
and is incorrect on your platform because the altera compatible will
match before yours, dragging in the quirk that platform has.

You need to make this into and enum with your new compatible and the
altera one, with a fallback to the snps one.

pw-bot: changes-requested

>  
>    reg:
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] i3c: dw: Add VersalNet compatible string

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Tue, Apr 21, 2026 at 04:00:59PM +0530, Shubhrajyoti Datta wrote:
> Add amd,versalnet-dw-i3c-master to the of_match table with
> snps,dw-i3c-master-1.00a as the generic fallback.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---
> 
>  drivers/i3c/master/dw-i3c-master.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index d6bdb32397fb..69fef7fdda37 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1845,6 +1845,7 @@ static const struct of_device_id dw_i3c_master_of_match[] = {
>  	{ .compatible = "altr,agilex5-dw-i3c-master",
>  	  .data = &altr_agilex5_drvdata,
>  	},
> +	{ .compatible = "amd,versalnet-dw-i3c-master", },

This shouldn't be needed, you use the snps compatible as a fallback and
have no driver data.

>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, dw_i3c_master_of_match);
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]