Linux EDAC development
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Avadhut Naik <avanaik92@gmail.com>
Subject: Re: [PATCH v5 0/2] Incorporate DRAM address in EDAC messages
Date: Mon, 1 Jun 2026 14:41:00 -0400	[thread overview]
Message-ID: <20260601184100.GA4547@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260521005740.GAag5YhDa_oarHPZdJ@fat_crate.local>

On Wed, May 20, 2026 at 05:57:40PM -0700, Borislav Petkov wrote:
> On Mon, May 18, 2026 at 12:07:14PM -0400, Yazen Ghannam wrote:
> > Hi all,
> > 
> > This revision addresses a comment from Sashiko in patch 2. The decision
> > to print the DRAM address will be independent of other decoding results.
> 
> https://sashiko.dev/#/patchset/20260518160716.171578-1-yazen.ghannam%40amd.com
> 
> Meh, gemini still finds stuff. Some of it is meh, the fake_inject thing
> probably needs fixing tho as I can see the concurrent f*ckup happening...
> 

The fake_inject thing looks like it could happen with all EDAC modules.

But it seems unlikely because CONFIG_EDAC_DEBUG needs to be enabled to
enable fake_inject. Plus a user would need to use it at the same time as
a real DRAM ECC error occurs.

We could add a mutex to the mci struct and hold it during
edac_mc_handle_error().

What do you think?

Thanks,
Yazen

  reply	other threads:[~2026-06-01 18:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 16:07 [PATCH v5 0/2] Incorporate DRAM address in EDAC messages Yazen Ghannam
2026-05-18 16:07 ` [PATCH v5 1/2] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM Yazen Ghannam
2026-05-18 16:07 ` [PATCH v5 2/2] EDAC/amd64: Include DRAM address in output Yazen Ghannam
2026-05-21  0:57 ` [PATCH v5 0/2] Incorporate DRAM address in EDAC messages Borislav Petkov
2026-06-01 18:41   ` Yazen Ghannam [this message]
2026-06-01 21:05     ` Borislav Petkov
2026-06-04 15:48       ` Yazen Ghannam
2026-06-10  0:35         ` Borislav Petkov
2026-06-10 21:15           ` Yazen Ghannam
2026-06-11  1:23             ` Borislav Petkov
2026-06-11 14:11               ` Yazen Ghannam
2026-06-11 16:16                 ` Borislav Petkov
2026-06-11 17:01                   ` Yazen Ghannam
2026-06-12  2:39                     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601184100.GA4547@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=avanaik92@gmail.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox