Linux EDAC development
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Avadhut Naik <avanaik92@gmail.com>
Subject: Re: [PATCH v5 0/2] Incorporate DRAM address in EDAC messages
Date: Thu, 11 Jun 2026 13:01:07 -0400	[thread overview]
Message-ID: <20260611165458.GA1105@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260611161611.GBairfS4UTuG-cwKjO@fat_crate.local>

On Thu, Jun 11, 2026 at 09:16:11AM -0700, Borislav Petkov wrote:
> On Thu, Jun 11, 2026 at 10:11:38AM -0400, Yazen Ghannam wrote:
> > The fake_inject fields are targets.
> 
> Uff, true story, I got confused, sorry.
> 
> /facepalm.
> 
> > Just curious, why not leave it? Do you think the bots will keep bringing
> > it up?
> 
> Ok, someone tells you about a bug in the software. You do nothing?
> 
> When do you fix it if you intend to do so?
> 

IMO, consider the risk and the outcome.

In this case, the conditions to hit the issue are rare.

Real DRAM ECC occurs and logged through EDAC: rare
EDAC_DEBUG config option enabled: almost never
User is doing a fake_inject: practically 0% chance

If the issue occurs, what is the outcome?

The "other_detail" string gets messed up for one of the error logs.

Of course, if no one is using fake_inject, then removing it closes this
small risk. I guess that's the point, right?

Thanks,
Yazen

  reply	other threads:[~2026-06-11 17:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 16:07 [PATCH v5 0/2] Incorporate DRAM address in EDAC messages Yazen Ghannam
2026-05-18 16:07 ` [PATCH v5 1/2] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM Yazen Ghannam
2026-05-18 16:07 ` [PATCH v5 2/2] EDAC/amd64: Include DRAM address in output Yazen Ghannam
2026-05-21  0:57 ` [PATCH v5 0/2] Incorporate DRAM address in EDAC messages Borislav Petkov
2026-06-01 18:41   ` Yazen Ghannam
2026-06-01 21:05     ` Borislav Petkov
2026-06-04 15:48       ` Yazen Ghannam
2026-06-10  0:35         ` Borislav Petkov
2026-06-10 21:15           ` Yazen Ghannam
2026-06-11  1:23             ` Borislav Petkov
2026-06-11 14:11               ` Yazen Ghannam
2026-06-11 16:16                 ` Borislav Petkov
2026-06-11 17:01                   ` Yazen Ghannam [this message]
2026-06-12  2:39                     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611165458.GA1105@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=avanaik92@gmail.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox