From: Borislav Petkov <bp@alien8.de>
To: Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
linux-edac@vger.kernel.org, git@amd.com,
Michal Simek <michal.simek@amd.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] EDAC/versalnet: Add NULL check for mci in remove_one_mc()
Date: Wed, 2 Sep 2026 09:13:41 -0700 [thread overview]
Message-ID: <20260902161341.GDaphLNf5-oebw1SZM@fat_crate.local> (raw)
In-Reply-To: <CAKfKVtEOn-jSiqHs9zGc4qNahQUy3XbAuACgtE5joF_ctGxjMw@mail.gmail.com>
On Tue, Aug 11, 2026 at 06:41:45PM +0530, Shubhrajyoti Datta wrote:
> The driver currently assumes that all 8 controllers are instantiated. However,
> Vivado allows users to enable only a subset of them. For example, if only 4
> controllers are enabled, only indices 0-3 will be populated with valid data
> structures. During rmmod, the driver attempts to remove all 8 controllers,
> including uninitialized entries, which can lead to a crash due to invalid memory
> access.
Yes, that's what I am looking for, thanks!
I would like to read a sane explanation and a use case how something can
happen so that when reading commit messages months and years from now, we all
know why the code was written this way.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-09-02 16:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 17:19 [PATCH 0/9] EDAC/versalnet: Fix error handling, teardown, and robustness Shubhrajyoti Datta
2026-07-24 17:19 ` [PATCH 1/9] EDAC/versalnet: Add NULL check for mci in handle_error() Shubhrajyoti Datta
2026-07-26 23:52 ` Borislav Petkov
2026-07-27 6:48 ` Pandey, Radhey Shyam
2026-07-28 1:37 ` Borislav Petkov
2026-07-28 18:27 ` Pandey, Radhey Shyam
2026-07-28 21:33 ` Borislav Petkov
2026-07-29 16:40 ` Pandey, Radhey Shyam
2026-07-30 15:03 ` Shubhrajyoti Datta
2026-07-24 17:19 ` [PATCH 2/9] EDAC/versalnet: Add NULL check for mci in remove_one_mc() Shubhrajyoti Datta
2026-07-27 8:11 ` Pandey, Radhey Shyam
2026-08-02 18:52 ` Borislav Petkov
2026-08-02 18:46 ` Borislav Petkov
2026-08-03 14:44 ` Shubhrajyoti Datta
2026-08-03 16:29 ` Borislav Petkov
2026-08-11 13:11 ` Shubhrajyoti Datta
2026-09-02 16:13 ` Borislav Petkov [this message]
2026-07-24 17:19 ` [PATCH 3/9] EDAC/versalnet: Move platform_set_drvdata() to mc_probe() Shubhrajyoti Datta
2026-07-27 8:35 ` Pandey, Radhey Shyam
2026-07-24 17:19 ` [PATCH 4/9] EDAC/versalnet: Fix device_register() error handling in init_one_mc() Shubhrajyoti Datta
2026-07-31 11:01 ` Pandey, Radhey Shyam
2026-07-24 17:19 ` [PATCH 5/9] EDAC/versalnet: Use dev_set_name() instead of sprintf with init_name Shubhrajyoti Datta
2026-07-31 11:22 ` Pandey, Radhey Shyam
2026-07-24 17:19 ` [PATCH 6/9] EDAC/versalnet: Initialize MCDI before RPMsg registration Shubhrajyoti Datta
2026-07-31 11:41 ` Pandey, Radhey Shyam
2026-07-24 17:19 ` [PATCH 7/9] EDAC/versalnet: Add bounds validation in rpmsg_cb() Shubhrajyoti Datta
2026-07-31 13:56 ` Pandey, Radhey Shyam
2026-07-24 17:19 ` [PATCH 8/9] EDAC/versalnet: Fix use-after-free in remove_one_mc() Shubhrajyoti Datta
2026-07-31 14:06 ` Pandey, Radhey Shyam
2026-07-24 17:19 ` [PATCH 9/9] EDAC/versalnet: Use designated initializer for rpmsg_channel_info Shubhrajyoti Datta
2026-07-31 14:26 ` Pandey, Radhey Shyam
2026-09-02 16:21 ` [PATCH 0/9] EDAC/versalnet: Fix error handling, teardown, and robustness Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902161341.GDaphLNf5-oebw1SZM@fat_crate.local \
--to=bp@alien8.de \
--cc=git@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox