From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, "Ani Sinha" <anisinha@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
linux-edac@vger.kernel.org, "Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH v3 03/16] qapi/docs: remove unused QAPIDoc subsection members
Date: Mon, 15 Jun 2026 16:10:16 +0200 [thread overview]
Message-ID: <87pl1rx5br.fsf@pond.sub.org> (raw)
In-Reply-To: <20260603032201.993015-4-jsnow@redhat.com> (John Snow's message of "Tue, 2 Jun 2026 23:21:48 -0400")
Uh, "qapi/docs:"? Shouldn't this be "qapi/parser:"?
John Snow <jsnow@redhat.com> writes:
> All users of the QAPIDoc object should be iterating over all_sections
> and not grabbing arbitrary subsections, if possible. Remove the 'body'
> and 'sections' members, as they are no longer used.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/parser.py | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
> index c3cf33904ef..b33edbba74f 100644
> --- a/scripts/qapi/parser.py
> +++ b/scripts/qapi/parser.py
> @@ -732,8 +732,6 @@ def __init__(self, info: QAPISourceInfo, symbol: Optional[str] = None):
> self.all_sections: List[QAPIDoc.Section] = [
> QAPIDoc.Section(info, QAPIDoc.Kind.PLAIN)
> ]
> - # the body section
> - self.body: Optional[QAPIDoc.Section] = self.all_sections[0]
> # dicts mapping parameter/feature names to their description
> self.args: Dict[str, QAPIDoc.ArgSection] = {}
> self.features: Dict[str, QAPIDoc.ArgSection] = {}
> @@ -742,8 +740,6 @@ def __init__(self, info: QAPISourceInfo, symbol: Optional[str] = None):
> self.errors: Optional[QAPIDoc.Section] = None
> # "Since" section
> self.since: Optional[QAPIDoc.Section] = None
> - # sections other than .body, .args, .features
> - self.sections: List[QAPIDoc.Section] = []
>
> def end(self) -> None:
> for section in self.all_sections:
> @@ -766,7 +762,6 @@ def ensure_untagged_section(self, info: QAPISourceInfo) -> None:
>
> # start new section
> section = self.Section(info, kind)
> - self.sections.append(section)
> self.all_sections.append(section)
>
> def new_tagged_section(
> @@ -790,7 +785,6 @@ def new_tagged_section(
> raise QAPISemError(
> info, "duplicated '%s' section" % kind)
> self.since = section
> - self.sections.append(section)
> self.all_sections.append(section)
>
> def _new_description(
next prev parent reply other threads:[~2026-06-15 14:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 3:21 [PATCH v3 00/16] qapi: add formal "intro" section John Snow
2026-06-03 3:21 ` [PATCH v3 01/16] python: temporarily restrict max mypy version John Snow
2026-06-03 3:21 ` [PATCH v3 02/16] tests/qapi: generate output in source order John Snow
2026-06-03 3:21 ` [PATCH v3 03/16] qapi/docs: remove unused QAPIDoc subsection members John Snow
2026-06-15 14:10 ` Markus Armbruster [this message]
2026-06-15 19:45 ` John Snow
2026-06-16 6:04 ` Markus Armbruster
2026-06-03 3:21 ` [PATCH v3 04/16] qapi/docs: add has_features property John Snow
2026-06-03 3:21 ` [PATCH v3 05/16] qapi/docs: make remaining subsection members "private" John Snow
2026-06-03 3:21 ` [PATCH v3 06/16] qapi/docs: fix comment phrasing John Snow
2026-06-03 3:21 ` [PATCH v3 07/16] qapi/docs: add "Intro" section John Snow
2026-06-09 10:58 ` Markus Armbruster
2026-06-09 18:06 ` John Snow
2026-06-03 3:21 ` [PATCH v3 08/16] qapi/parser: move _insert_near_kind() method John Snow
2026-06-03 3:21 ` [PATCH v3 09/16] qapi/docs: adjust stub member insertion algorithm John Snow
2026-06-03 11:27 ` Markus Armbruster
2026-06-04 19:07 ` John Snow
2026-06-09 13:32 ` Markus Armbruster
2026-06-09 18:44 ` John Snow
2026-06-03 3:21 ` [PATCH v3 10/16] qapi/docs: remove implicit Plain section John Snow
2026-06-03 3:21 ` [PATCH v3 11/16] qapi/docs: add rendering for INTRO sections John Snow
2026-06-09 13:36 ` Markus Armbruster
2026-06-09 18:51 ` John Snow
2026-06-03 3:21 ` [PATCH v3 12/16] qapi/docs: add "Intro" section parsing John Snow
2026-06-09 13:39 ` Markus Armbruster
2026-06-09 18:57 ` John Snow
2026-06-11 5:54 ` Markus Armbruster
2026-06-03 3:21 ` [PATCH v3 13/16] qapi: convert intro sections for accelerator.json John Snow
2026-06-03 3:21 ` [PATCH v3 14/16] qapi: convert intro sections for acpi-hest.json John Snow
2026-06-03 3:22 ` [PATCH v3 15/16] qapi: convert intro sections for acpi.json John Snow
2026-06-03 3:22 ` [PATCH v3 16/16] qapi: convert intro sections for audio.json John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl1rx5br.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=anisinha@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-edac@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=mchehab+huawei@kernel.org \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox