From: Borislav Petkov <bp@alien8.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: bjorn.andersson@linaro.org, mchehab@kernel.org,
james.morse@arm.com, rric@kernel.org,
linux-arm-msm@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_tsoni@quicinc.com,
quic_saipraka@quicinc.com
Subject: Re: [PATCH v3 3/5] EDAC/qcom: Get rid of hardcoded register offsets
Date: Wed, 26 Oct 2022 18:00:20 +0200 [thread overview]
Message-ID: <Y1lZlB+slTCM0+tS@zn.tnic> (raw)
In-Reply-To: <20220825043859.30066-4-manivannan.sadhasivam@linaro.org>
On Thu, Aug 25, 2022 at 10:08:57AM +0530, Manivannan Sadhasivam wrote:
> The LLCC EDAC register offsets varies between each SoC. Hardcoding the
> register offsets won't work and will often result in crash due to
> accessing the wrong locations.
>
> Hence, get the register offsets from the LLCC driver matching the
> individual SoCs.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/edac/qcom_edac.c | 116 ++++++++++++++---------------
> include/linux/soc/qcom/llcc-qcom.h | 6 --
> 2 files changed, 58 insertions(+), 64 deletions(-)
I can't take those:
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/soc/qcom/llcc-qcom.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
make: *** [Makefile:1944: modpost] Error 2
You'd have to rediff them against latest Linus -rc tag and test them
properly.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-10-26 16:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 4:38 [PATCH v3 0/5] Fix crash when using Qcom LLCC/EDAC drivers Manivannan Sadhasivam
2022-08-25 4:38 ` [PATCH v3 1/5] soc: qcom: llcc: Rename reg_offset structs to reflect LLCC version Manivannan Sadhasivam
2022-08-25 4:48 ` Sai Prakash Ranjan
2022-08-25 4:38 ` [PATCH v3 2/5] soc: qcom: llcc: Pass LLCC version based register offsets to EDAC driver Manivannan Sadhasivam
2022-08-25 4:50 ` Sai Prakash Ranjan
2022-08-25 4:38 ` [PATCH v3 3/5] EDAC/qcom: Get rid of hardcoded register offsets Manivannan Sadhasivam
2022-08-25 4:57 ` Sai Prakash Ranjan
2022-08-30 2:50 ` Bjorn Andersson
2022-10-26 16:00 ` Borislav Petkov [this message]
2022-08-25 4:38 ` [PATCH v3 4/5] EDAC/qcom: Remove extra error no assignment in qcom_llcc_core_setup() Manivannan Sadhasivam
2022-08-25 4:45 ` Sai Prakash Ranjan
2022-08-25 4:38 ` [PATCH v3 5/5] MAINTAINERS: Add myself as the maintainer for qcom_edac driver Manivannan Sadhasivam
2022-08-30 2:50 ` (subset) [PATCH v3 0/5] Fix crash when using Qcom LLCC/EDAC drivers Bjorn Andersson
2022-10-03 7:04 ` Manivannan Sadhasivam
2022-10-03 9:32 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1lZlB+slTCM0+tS@zn.tnic \
--to=bp@alien8.de \
--cc=bjorn.andersson@linaro.org \
--cc=james.morse@arm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=quic_saipraka@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox