From: Borislav Petkov <bp@alien8.de>
To: Hans Potsch <hans.potsch@nokia.com>
Cc: jlu@pengutronix.de, linux-edac@vger.kernel.org, harald.glock@nokia.com
Subject: Re: [PATCH] EDAC/armada-xp: Fix output of uncorrectable error counter
Date: Thu, 14 Oct 2021 11:56:04 +0200 [thread overview]
Message-ID: <YWf+tClabicEVQ4d@zn.tnic> (raw)
In-Reply-To: <20211006121332.58788-1-hans.potsch@nokia.com>
On Wed, Oct 06, 2021 at 02:13:32PM +0200, Hans Potsch wrote:
> Incorrect parameter is passed to the edac_mc_handle_error() function.
> Therefore number of correctable errors is displayed as uncorrectable
> errors. Changed to correct parameter.
>
> Signed-off-by: Hans Potsch <hans.potsch@nokia.com>
> ---
> drivers/edac/armada_xp_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c
> index e3e757513d1b..b1f46a974b9e 100644
> --- a/drivers/edac/armada_xp_edac.c
> +++ b/drivers/edac/armada_xp_edac.c
> @@ -178,7 +178,7 @@ static void axp_mc_check(struct mem_ctl_info *mci)
> "details unavailable (multiple errors)");
> if (cnt_dbe)
> edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci,
> - cnt_sbe, /* error count */
> + cnt_dbe, /* error count */
> 0, 0, 0, /* pfn, offset, syndrome */
> -1, -1, -1, /* top, mid, low layer */
> mci->ctl_name,
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2021-10-14 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AM8PR07MB8172B5AB7AD5DAE78CA4624CFEAA9@AM8PR07MB8172.eurprd07.prod.outlook.com>
2021-09-30 14:25 ` Bug in EDAC error handling of Marvell Armada XP Jan Lübbe
2021-10-06 9:40 ` Potsch, Hans (Nokia - DE/Stuttgart)
2021-10-06 12:13 ` [PATCH] EDAC/armada-xp: Fix output of uncorrectable error counter Hans Potsch
2021-10-14 9:56 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWf+tClabicEVQ4d@zn.tnic \
--to=bp@alien8.de \
--cc=hans.potsch@nokia.com \
--cc=harald.glock@nokia.com \
--cc=jlu@pengutronix.de \
--cc=linux-edac@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox