From: Borislav Petkov <bp@alien8.de>
To: Jane Chu <jane.chu@oracle.com>
Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org,
linux-edac@vger.kernel.org, dan.j.williams@intel.com,
linux-kernel@vger.kernel.org, hch@lst.de, nvdimm@lists.linux.dev
Subject: Re: [PATCH v7] x86/mce: retrieve poison range from hardware
Date: Tue, 23 Aug 2022 18:51:34 +0200 [thread overview]
Message-ID: <YwUFlo3+my6bJHWj@zn.tnic> (raw)
In-Reply-To: <20220802195053.3882368-1-jane.chu@oracle.com>
On Tue, Aug 02, 2022 at 01:50:53PM -0600, Jane Chu wrote:
> With Commit 7917f9cdb503 ("acpi/nfit: rely on mce->misc to determine
> poison granularity") that changed nfit_handle_mce() callback to report
> badrange according to 1ULL << MCI_MISC_ADDR_LSB(mce->misc), it's been
> discovered that the mce->misc LSB field is 0x1000 bytes, hence injecting
> 2 back-to-back poisons and the driver ends up logging 8 badblocks,
> because 0x1000 bytes is 8 512-byte.
What I'm missing from this text here is, what *is* the mce->misc LSB
field in human speak? What does that field denote?
What effect does that field have on error injection?
And so on.
> Dan Williams noticed that apei_mce_report_mem_error() hardcode
> the LSB field to PAGE_SHIFT instead of consulting the input
> struct cper_sec_mem_err record. So change to rely on hardware whenever
> support is available.
Rely on hardware? You're changing this to rely on what the firmware
reports.
That mem_err thing comes from a BIOS table AFAICT.
...
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-08-23 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 19:50 [PATCH v7] x86/mce: retrieve poison range from hardware Jane Chu
2022-08-03 8:53 ` Ingo Molnar
2022-08-08 20:58 ` Jane Chu
2022-08-08 23:30 ` Dan Williams
2022-08-23 16:38 ` Jane Chu
2022-08-23 16:51 ` Borislav Petkov [this message]
2022-08-23 16:58 ` Luck, Tony
2022-08-25 16:29 ` Jane Chu
2022-08-25 22:53 ` Borislav Petkov
2022-08-26 17:54 ` Dan Williams
2022-08-26 18:09 ` Borislav Petkov
2022-08-26 22:11 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwUFlo3+my6bJHWj@zn.tnic \
--to=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hch@lst.de \
--cc=jane.chu@oracle.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nvdimm@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox