* [PATCH] EDAC/fsl_ddr: use non devm for request_irq()
@ 2026-07-29 1:23 Rosen Penev
2026-07-30 18:49 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-07-29 1:23 UTC (permalink / raw)
To: linux-edac
Cc: Frank Li, Borislav Petkov, Tony Luck, open list:EDAC-FSL_DDR,
open list
We need to tear down the irq before edac_mc_free() to avoid a use after
free on teardown as request_irq uses mci as dev_id.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/edac/fsl_ddr_edac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
index f4cc89b26954..f1ddd1f47f2a 100644
--- a/drivers/edac/fsl_ddr_edac.c
+++ b/drivers/edac/fsl_ddr_edac.c
@@ -601,7 +601,7 @@ int fsl_mc_err_probe(struct platform_device *op)
/* register interrupts */
pdata->irq = platform_get_irq(op, 0);
- res = devm_request_irq(&op->dev, pdata->irq,
+ res = request_irq(pdata->irq,
fsl_mc_isr,
IRQF_SHARED,
"[EDAC] MC err", mci);
@@ -639,6 +639,7 @@ void fsl_mc_err_remove(struct platform_device *op)
if (edac_op_state == EDAC_OPSTATE_INT) {
ddr_out32(pdata, FSL_MC_ERR_INT_EN, 0);
+ free_irq(pdata->irq, mci);
}
ddr_out32(pdata, FSL_MC_ERR_DISABLE,
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EDAC/fsl_ddr: use non devm for request_irq()
2026-07-29 1:23 [PATCH] EDAC/fsl_ddr: use non devm for request_irq() Rosen Penev
@ 2026-07-30 18:49 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-07-30 18:49 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-edac, Frank Li, Borislav Petkov, Tony Luck,
open list:EDAC-FSL_DDR, open list
On Tue, Jul 28, 2026 at 06:23:20PM -0700, Rosen Penev wrote:
> We need to tear down the irq before edac_mc_free() to avoid a use after
> free on teardown as request_irq uses mci as dev_id.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/edac/fsl_ddr_edac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
> index f4cc89b26954..f1ddd1f47f2a 100644
> --- a/drivers/edac/fsl_ddr_edac.c
> +++ b/drivers/edac/fsl_ddr_edac.c
> @@ -601,7 +601,7 @@ int fsl_mc_err_probe(struct platform_device *op)
>
> /* register interrupts */
> pdata->irq = platform_get_irq(op, 0);
> - res = devm_request_irq(&op->dev, pdata->irq,
> + res = request_irq(pdata->irq,
> fsl_mc_isr,
> IRQF_SHARED,
> "[EDAC] MC err", mci);
> @@ -639,6 +639,7 @@ void fsl_mc_err_remove(struct platform_device *op)
>
> if (edac_op_state == EDAC_OPSTATE_INT) {
> ddr_out32(pdata, FSL_MC_ERR_INT_EN, 0);
> + free_irq(pdata->irq, mci);
here already disable hardware irq. Just call
synchronize_irq() to make sure pending irq handled.
Frank
> }
>
> ddr_out32(pdata, FSL_MC_ERR_DISABLE,
> --
> 2.55.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-30 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-29 1:23 [PATCH] EDAC/fsl_ddr: use non devm for request_irq() Rosen Penev
2026-07-30 18:49 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox