Linux EFI development
 help / color / mirror / Atom feed
From: Theodore Tucker <theodore@tti0.net>
To: Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	Tony Luck <tony.luck@intel.com>, Kees Cook <kees@kernel.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH] efi: Make EFI_VARS_PSTORE depend on EFIVAR_FS
Date: Thu, 20 Aug 2026 18:54:39 +0100	[thread overview]
Message-ID: <04e11e34-1b3f-4892-adc5-ae2ea040c004@tti0.net> (raw)
In-Reply-To: <55870f62-ee17-4aed-850e-790517f68eee@app.fastmail.com>

Hi,

On 20/08/2026 12:49, Ard Biesheuvel wrote:
> 
> Actually, EFI pstore does not depend on efivarfs, it only depends on
> the efivars layer.
> 
> Why do you think it needs to depend on EFIVAR_FS?

When building a 7.0 kernel for x86 with `make alldefconfig` and then 
enabling CONFIG_EFI, CONFIG_PSTORE, and CONFIG_EFI_VARS_PSTORE, I found 
that the EFI pstore backend failed to register 
(/sys/module/pstore/parameters/backend was empty after boot) unless 
CONFIG_EFIVAR_FS had also been enabled explicitly.

I can see now that EFI pstore code should not need the efivarfs, and 
neither should userspace, since it gets access to any logs through 
/sys/fs/pstore. So I do appreciate that my patch may not be the right 
fix here, and I proposed it not as an expert on the internals of EFI 
pstore, but from experimentation as a user. Sorry for the noise.

I eventually ended up using the ramoops pstore backend so unfortunately 
no longer have the exact kernel configurations I used when this tripped 
me up.

Thanks and kind regards,

Theodore


-- 
Theodore Tucker
theodore@tti0.net


  reply	other threads:[~2026-08-20 18:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25 17:12 [PATCH] efi: Make EFI_VARS_PSTORE depend on EFIVAR_FS Theodore Tucker
2026-07-23  6:39 ` Ard Biesheuvel
2026-08-20 11:49   ` Ard Biesheuvel
2026-08-20 17:54     ` Theodore Tucker [this message]
2026-08-21  7:18       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04e11e34-1b3f-4892-adc5-ae2ea040c004@tti0.net \
    --to=theodore@tti0.net \
    --cc=ardb@kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kees@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox