From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Theodore Tucker" <theodore@tti0.net>, linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Tony Luck" <tony.luck@intel.com>, "Kees Cook" <kees@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH] efi: Make EFI_VARS_PSTORE depend on EFIVAR_FS
Date: Thu, 20 Aug 2026 14:49:31 +0300 [thread overview]
Message-ID: <55870f62-ee17-4aed-850e-790517f68eee@app.fastmail.com> (raw)
In-Reply-To: <6ecd6385-37c6-4ae8-8413-53a6e8602635@app.fastmail.com>
On Thu, 23 Jul 2026, at 09:39, Ard Biesheuvel wrote:
> On Thu, 25 Jun 2026, at 19:12, Theodore Tucker wrote:
>> The efivars backend to pstore will not register if the efivarfs is
>> not available. The efivars sysfs interface was removed in Linux 6.0,
>> meaning efivarfs is now the only way pstore can write into EFI
>> variables. Making the dependency on the efivarfs explicit removes
>> a stumbling block when configuring a kernel with pstore.
>>
>> Signed-off-by: Theodore Tucker <theodore@tti0.net>
>> ---
>> drivers/firmware/efi/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Applied, thanks.
>
Actually, EFI pstore does not depend on efivarfs, it only depends on
the efivars layer.
Why do you think it needs to depend on EFIVAR_FS?
>> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
>> index 29e0729299f5..8dfd21e7a8e4 100644
>> --- a/drivers/firmware/efi/Kconfig
>> +++ b/drivers/firmware/efi/Kconfig
>> @@ -9,7 +9,7 @@ config EFI_ESRT
>>
>> config EFI_VARS_PSTORE
>> tristate "Register efivars backend for pstore"
>> - depends on PSTORE
>> + depends on PSTORE && EFIVAR_FS
>> select UCS2_STRING
>> default y
>> help
>> --
>> 2.47.3
next prev parent reply other threads:[~2026-08-20 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 17:12 [PATCH] efi: Make EFI_VARS_PSTORE depend on EFIVAR_FS Theodore Tucker
2026-07-23 6:39 ` Ard Biesheuvel
2026-08-20 11:49 ` Ard Biesheuvel [this message]
2026-08-20 17:54 ` Theodore Tucker
2026-08-21 7:18 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55870f62-ee17-4aed-850e-790517f68eee@app.fastmail.com \
--to=ardb@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kees@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=theodore@tti0.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox