From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-efi@vger.kernel.org,
kernel-dev@igalia.com, kernel@gpiccoli.net,
keescook@chromium.org, anton@enomsg.org, ccross@android.com,
tony.luck@intel.com
Subject: Re: [PATCH V2 3/3] efi: pstore: Add module parameter for setting the record size
Date: Fri, 14 Oct 2022 12:19:24 -0300 [thread overview]
Message-ID: <0d037ef8-e301-c0fd-8020-3846a4762ade@igalia.com> (raw)
In-Reply-To: <CAMj1kXGLULYfA6UGwvH7NY5A5E6YaC4s8G+qU12MgChB1_5DKQ@mail.gmail.com>
On 14/10/2022 12:00, Ard Biesheuvel wrote:
> On Fri, 14 Oct 2022 at 16:58, Guilherme G. Piccoli <gpiccoli@igalia.com> wrote:
>>
>> On 14/10/2022 11:46, Ard Biesheuvel wrote:
>>> [...]
>>>> for (;;) {
>>>> - varname_size = EFIVARS_DATA_SIZE_MAX;
>>>> + varname_size = record_size;
>>>>
>>>
>>> I don't think we need this - this is the size of the variable name not
>>> the variable itself.
>>>
>>
>> Ugh, my bad. Do you want to stick with 1024 then?
>
> Yes let's keep this at 1024
Perfect, will re-send after we have more feedback on patches 1 and 2.
Thanks again,
Guilherme
next prev parent reply other threads:[~2022-10-14 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 21:06 [PATCH V2 0/3] Some pstore improvements V2 Guilherme G. Piccoli
2022-10-13 21:06 ` [PATCH V2 1/3] pstore: Alert on backend write error Guilherme G. Piccoli
2022-10-14 14:46 ` Ard Biesheuvel
2022-10-14 17:41 ` (subset) " Kees Cook
2022-10-13 21:06 ` [PATCH V2 2/3] efi: pstore: Follow convention for the efi-pstore backend name Guilherme G. Piccoli
2022-10-13 21:06 ` [PATCH V2 3/3] efi: pstore: Add module parameter for setting the record size Guilherme G. Piccoli
2022-10-14 14:46 ` Ard Biesheuvel
2022-10-14 14:57 ` Guilherme G. Piccoli
2022-10-14 15:00 ` Ard Biesheuvel
2022-10-14 15:19 ` Guilherme G. Piccoli [this message]
2022-10-14 17:42 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d037ef8-e301-c0fd-8020-3846a4762ade@igalia.com \
--to=gpiccoli@igalia.com \
--cc=anton@enomsg.org \
--cc=ardb@kernel.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox