Linux EFI development
 help / color / mirror / Atom feed
From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: "Lee, Chun-Yi" <joeyli.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Lee,
	Chun-Yi" <jlee-IBi9RG/b67k@public.gmane.org>,
	Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Subject: Re: [PATCH] efi: fix always unregister kset of efivars in register_efivars
Date: Mon, 29 Oct 2012 19:11:44 +0000	[thread overview]
Message-ID: <1351537904.14888.44.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <1351493576-3094-1-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>

On Mon, 2012-10-29 at 14:52 +0800, Lee, Chun-Yi wrote:
> The cc9c97b76aa7235d5a1de0f74f990097f77008b4 patch introduced a
> issue that always unregister kset of efivars in register_efivars.
> 
> This patch moved the kset_unregister function call to the kobject create check
> block for fix issue.
> 
> Cc: Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
> Cc: Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> Cc: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Lee, Chun-Yi <jlee-IBi9RG/b67k@public.gmane.org>
> ---
>  drivers/firmware/efivars.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)

Thanks Joey. What I ended up doing was squashing this patch with your
previous version and rebasing my 'next' branch. That way, when this
series is merged the bug will never appear.

Please take a look to make sure everything is OK.

-- 
Matt Fleming, Intel Open Source Technology Center

  parent reply	other threads:[~2012-10-29 19:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-29  6:52 [PATCH] efi: fix always unregister kset of efivars in register_efivars Lee, Chun-Yi
     [not found] ` <1351493576-3094-1-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2012-10-29 19:11   ` Matt Fleming [this message]
     [not found]     ` <1351537904.14888.44.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-10-30  3:07       ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351537904.14888.44.camel@mfleming-mobl1.ger.corp.intel.com \
    --to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=jlee-IBi9RG/b67k@public.gmane.org \
    --cc=joeyli.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox