Re: [PATCH] efi: fix always unregister kset of efivars in register_efivars

[joeyli <jlee-IBi9RG/b67k@public.gmane.org>]

於 一，2012-10-29 於 19:11 +0000，Matt Fleming 提到：
> On Mon, 2012-10-29 at 14:52 +0800, Lee, Chun-Yi wrote:
> > The cc9c97b76aa7235d5a1de0f74f990097f77008b4 patch introduced a
> > issue that always unregister kset of efivars in register_efivars.
> > 
> > This patch moved the kset_unregister function call to the kobject create check
> > block for fix issue.
> > 
> > Cc: Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Cc: H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
> > Cc: Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> > Cc: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Lee, Chun-Yi <jlee-IBi9RG/b67k@public.gmane.org>
> > ---
> >  drivers/firmware/efivars.c |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> Thanks Joey. What I ended up doing was squashing this patch with your
> previous version and rebasing my 'next' branch. That way, when this
> series is merged the bug will never appear.
> 
> Please take a look to make sure everything is OK.
> 

I just check the next branch, this fix merged with patch commit eecceeb,
everything is OK.


Thanks a lot!
Joey Lee