[PATCH] efi: fix errors in building: requires -maccumulate-outgoing-args

[PATCH] efi: fix errors in building: requires -maccumulate-outgoing-args

[Zhu Lingshan]

when build kernel with default config, efi/libstub won't build,
complain: sorry, unimplemented: ms_abi attribute
requires -maccumulate-outgoing-args or subtarget optimization
implying it

This commit intends to add -maccumulate-outgoing-args to Makefile
cflags, make builder happy.

Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
 drivers/firmware/efi/libstub/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
index 75daaf2..a4541b2 100644
--- a/drivers/firmware/efi/libstub/Makefile
+++ b/drivers/firmware/efi/libstub/Makefile
@@ -6,7 +6,7 @@
 # enabled, even if doing so doesn't break the build.
 #
 cflags-$(CONFIG_X86_32)		:= -march=i386
-cflags-$(CONFIG_X86_64)		:= -mcmodel=small
+cflags-$(CONFIG_X86_64)		:= -mcmodel=small -maccumulate-outgoing-args
 cflags-$(CONFIG_X86)		+= -m$(BITS) -D__KERNEL__ \
 				   -fPIC -fno-strict-aliasing -mno-red-zone \
 				   -mno-mmx -mno-sse -fshort-wchar \
-- 
1.8.3.1

Re: [PATCH] efi: fix errors in building: requires -maccumulate-outgoing-args

[Ard Biesheuvel]

On Sun, 14 Jun 2020 at 13:49, Zhu Lingshan <lingshan.zhu@intel.com> wrote:
>
> when build kernel with default config, efi/libstub won't build,
> complain: sorry, unimplemented: ms_abi attribute
> requires -maccumulate-outgoing-args or subtarget optimization
> implying it
>
> This commit intends to add -maccumulate-outgoing-args to Makefile
> cflags, make builder happy.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>

Thank you Zhu. You are number #4 to report this to the linux-efi
mailing list, and a fix was already suggested.

https://lore.kernel.org/linux-efi/20200605150638.1011637-1-nivedita@alum.mit.edu/

Upgrading to something more recent than GCC 4.8 could be another
workaround, if that is an option for you. The fix should hopefully be
in by -rc2


> ---
>  drivers/firmware/efi/libstub/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
> index 75daaf2..a4541b2 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -6,7 +6,7 @@
>  # enabled, even if doing so doesn't break the build.
>  #
>  cflags-$(CONFIG_X86_32)                := -march=i386
> -cflags-$(CONFIG_X86_64)                := -mcmodel=small
> +cflags-$(CONFIG_X86_64)                := -mcmodel=small -maccumulate-outgoing-args
>  cflags-$(CONFIG_X86)           += -m$(BITS) -D__KERNEL__ \
>                                    -fPIC -fno-strict-aliasing -mno-red-zone \
>                                    -mno-mmx -mno-sse -fshort-wchar \
> --
> 1.8.3.1
>