[patch 01/12 v4] efi: remove unused variables in __map_region

[patch 01/12 v4] efi: remove unused variables in __map_region

[dyoung-H+wXaHxf7aLQT0dZR+AlfA]

Hi,
References: <20131125085630.417850406-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
Content-Disposition: inline; filename=01-remove-unused-var-in-map-region.patch

variables size and end is useless in this function, thus remove them.

Reported-by: Toshi Kani <toshi.kani-VXdhtT5mjnY@public.gmane.org>
Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Acked-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>
---
 arch/x86/platform/efi/efi_64.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- efi.orig/arch/x86/platform/efi/efi_64.c
+++ efi/arch/x86/platform/efi/efi_64.c
@@ -148,15 +148,11 @@ void efi_setup_page_tables(void)
 static void __init __map_region(efi_memory_desc_t *md, u64 va)
 {
 	pgd_t *pgd = (pgd_t *)__va(real_mode_header->trampoline_pgd);
-	unsigned long pf = 0, size;
-	u64 end;
+	unsigned long pf = 0;
 
 	if (!(md->attribute & EFI_MEMORY_WB))
 		pf |= _PAGE_PCD;
 
-	size = md->num_pages << PAGE_SHIFT;
-	end  = va + size;
-
 	if (kernel_map_pages_in_pgd(pgd, md->phys_addr, va, md->num_pages, pf))
 		pr_warn("Error mapping PA 0x%llx -> VA 0x%llx!\n",
 			   md->phys_addr, va);

Re: [patch 01/12 v4] efi: remove unused variables in __map_region

[Dave Young]

On 11/25/13 at 04:56pm, Dave Young wrote:
> Hi,
> References: <20131125085630.417850406-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
> Content-Disposition: inline; filename=01-remove-unused-var-in-map-region.patch

Not sure why above references are added in content, another mistake.
please ignore them when you review the patches.

Sigh, looks like I should move to git-send-email for less error prone.

Re: [patch 01/12 v4] efi: remove unused variables in __map_region

[Borislav Petkov]

On Mon, Nov 25, 2013 at 05:19:57PM +0800, Dave Young wrote:
> Sigh, looks like I should move to git-send-email for less error prone.

You won't regret it :-)

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--