From: Yeoreum Yun <yeoreum.yun@arm.com>
To: ardb@kernel.org, broonie@kernel.org, sami.mujawar@arm.com,
sudeep.holla@arm.com, pierre.gondois@arm.com,
hagarhem@amazon.com, catalin.marinas@arm.com, will@kernel.org,
guohanjun@huawei.com, Jonathan.Cameron@huawei.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Yeoreum Yun <yeoreum.yun@arm.com>
Subject: [PATCH v2 1/2] arm64/acpi: panic when failed to init acpi table with acpi=force option
Date: Mon, 25 Nov 2024 17:07:57 +0000 [thread overview]
Message-ID: <20241125170758.518943-2-yeoreum.yun@arm.com> (raw)
In-Reply-To: <20241125170758.518943-1-yeoreum.yun@arm.com>
when the acpi=force option is used,
the system does not fall back to the device tree (DT).
If it fails to initialize the ACPI table, it cannot proceed further.
In such cases, the system should invoke panic() to avoid contradicting
the user's explicit intent, as failing or
proceeding with unintended behavior would violate their wishes.
Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
---
arch/arm64/kernel/acpi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c
index e6f66491fbe9..efdf24ed5c3e 100644
--- a/arch/arm64/kernel/acpi.c
+++ b/arch/arm64/kernel/acpi.c
@@ -225,6 +225,8 @@ void __init acpi_boot_table_init(void)
pr_err("Failed to init ACPI tables\n");
if (!param_acpi_force)
disable_acpi();
+ else
+ panic("Failed to boot with ACPI tables\n");
}
done:
--
LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}
next prev parent reply other threads:[~2024-11-25 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 17:07 [PATCH v2 0/2] small fixes when boot with acpi=force option Yeoreum Yun
2024-11-25 17:07 ` Yeoreum Yun [this message]
2024-11-25 17:30 ` [PATCH v2 1/2] arm64/acpi: panic when failed to init acpi table " Ard Biesheuvel
2024-11-25 17:41 ` Mark Brown
2024-11-25 17:59 ` Levi Yun
2024-11-25 17:07 ` [PATCH v2 2/2] efi/fdt: ignore dtb when acpi option is used with force Yeoreum Yun
2024-11-25 17:18 ` Mark Brown
2024-11-25 17:24 ` Ard Biesheuvel
2024-11-25 17:45 ` Levi Yun
2024-11-25 17:53 ` Ard Biesheuvel
2024-11-25 18:15 ` Levi Yun
2024-11-25 18:32 ` Ard Biesheuvel
2024-11-25 18:47 ` Levi Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125170758.518943-2-yeoreum.yun@arm.com \
--to=yeoreum.yun@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=guohanjun@huawei.com \
--cc=hagarhem@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=sami.mujawar@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox