From: Levi Yun <yeoreum.yun@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: broonie@kernel.org, sami.mujawar@arm.com, sudeep.holla@arm.com,
pierre.gondois@arm.com, hagarhem@amazon.com,
catalin.marinas@arm.com, will@kernel.org, guohanjun@huawei.com,
Jonathan.Cameron@huawei.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64/acpi: panic when failed to init acpi table with acpi=force option
Date: Mon, 25 Nov 2024 17:59:31 +0000 [thread overview]
Message-ID: <Z0S7A6uOHpXZbxfy@e129823.arm.com> (raw)
In-Reply-To: <CAMj1kXGBnYQi05qh0QZk2hVLjVhS774-nT=HLdL_kW1d7nxMVg@mail.gmail.com>
Hi Ard.
>
> Calling panic() at this point does not achieve anything useful,
> though. Without ACPI tables or a DT, the only way to observe this
> panic message is by using earlycon= with an explicit MMIO address, and
> it might be better to limp on instead. Is there anything bad that
> might happen because of this, other than the user's wishes getting
> violated?
IMHO, the most weird thing is progressing boot with acpi table although
it failed to initailise. in this situation continuing to boot maybe
dead in unexepceted places. I think it would be better to prevent
futher progress by calling the panic() in this situation.
next prev parent reply other threads:[~2024-11-25 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 17:07 [PATCH v2 0/2] small fixes when boot with acpi=force option Yeoreum Yun
2024-11-25 17:07 ` [PATCH v2 1/2] arm64/acpi: panic when failed to init acpi table " Yeoreum Yun
2024-11-25 17:30 ` Ard Biesheuvel
2024-11-25 17:41 ` Mark Brown
2024-11-25 17:59 ` Levi Yun [this message]
2024-11-25 17:07 ` [PATCH v2 2/2] efi/fdt: ignore dtb when acpi option is used with force Yeoreum Yun
2024-11-25 17:18 ` Mark Brown
2024-11-25 17:24 ` Ard Biesheuvel
2024-11-25 17:45 ` Levi Yun
2024-11-25 17:53 ` Ard Biesheuvel
2024-11-25 18:15 ` Levi Yun
2024-11-25 18:32 ` Ard Biesheuvel
2024-11-25 18:47 ` Levi Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0S7A6uOHpXZbxfy@e129823.arm.com \
--to=yeoreum.yun@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=guohanjun@huawei.com \
--cc=hagarhem@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=sami.mujawar@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox