public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Gregory Price <gourry@gourry.net>,
	Usama Arif <usamaarif642@gmail.com>,
	 linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Breno Leitao <leitao@debian.org>,
	kernel-team@meta.com
Subject: [PATCH 0/3] efi/memattr: Improve the efi_memattr_init function.
Date: Mon, 06 Jan 2025 11:02:49 -0800	[thread overview]
Message-ID: <20250106-efi_fw_bug-v1-0-01a8eb40bfeb@debian.org> (raw)

After 8fbe4c49c0ccac ("efi/memattr: Ignore table if the size is clearly
bogus") landed, we are seeing a lot of firmware bugs in the Meta fleet.

There is an indication that this might be related to kexec, but, more on
this later.

While debugging the current issue, I modified the efi_memattr_init()
function in a way that I think it might be useful upstream.

The changes will help to detect EFI problems at scale, by making it more
verbose and easy to categorize early FW bugs.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (3):
      efi/memattr: Convert efi_memattr_init() return type to void
      efi/memattr: Add FW_BUG prefix to firmware error messages
      efi/memattr: Include EFI memmap size in corruption warnings

 drivers/firmware/efi/memattr.c | 20 ++++++++++----------
 include/linux/efi.h            |  2 +-
 2 files changed, 11 insertions(+), 11 deletions(-)
---
base-commit: c8e17339185951589d109ba81e8854513ab3d26f
change-id: 20250106-efi_fw_bug-2b62e9a41899

Best regards,
-- 
Breno Leitao <leitao@debian.org>


             reply	other threads:[~2025-01-06 19:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 19:02 Breno Leitao [this message]
2025-01-06 19:02 ` [PATCH 1/3] efi/memattr: Convert efi_memattr_init() return type to void Breno Leitao
2025-01-06 19:24   ` Ard Biesheuvel
2025-01-06 19:02 ` [PATCH 2/3] efi/memattr: Add FW_BUG prefix to firmware error messages Breno Leitao
2025-01-06 19:25   ` Ard Biesheuvel
2025-01-06 19:02 ` [PATCH 3/3] efi/memattr: Include EFI memmap size in corruption warnings Breno Leitao
2025-01-07 11:24   ` Ard Biesheuvel
2025-01-07 12:05     ` Breno Leitao
2025-01-09 14:48       ` Ard Biesheuvel
2025-01-09 15:09         ` Usama Arif
2025-01-09 17:45         ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250106-efi_fw_bug-v1-0-01a8eb40bfeb@debian.org \
    --to=leitao@debian.org \
    --cc=ardb@kernel.org \
    --cc=gourry@gourry.net \
    --cc=kernel-team@meta.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=usamaarif642@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox