From: Breno Leitao <leitao@debian.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Gregory Price <gourry@gourry.net>,
Usama Arif <usamaarif642@gmail.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Breno Leitao <leitao@debian.org>,
kernel-team@meta.com
Subject: [PATCH 2/3] efi/memattr: Add FW_BUG prefix to firmware error messages
Date: Mon, 06 Jan 2025 11:02:51 -0800 [thread overview]
Message-ID: <20250106-efi_fw_bug-v1-2-01a8eb40bfeb@debian.org> (raw)
In-Reply-To: <20250106-efi_fw_bug-v1-0-01a8eb40bfeb@debian.org>
Tag firmware-related error messages with FW_BUG in efi_memattr_init() to
make EFI firmware issues more discoverable and consistent with kernel
error reporting conventions.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/firmware/efi/memattr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/efi/memattr.c b/drivers/firmware/efi/memattr.c
index e727cc5909cb676c47d787ab0d7754b6fdcb493d..5f83cdea88b05cb325e9f90c14a0048131e53cfa 100644
--- a/drivers/firmware/efi/memattr.c
+++ b/drivers/firmware/efi/memattr.c
@@ -29,13 +29,13 @@ void __init efi_memattr_init(void)
tbl = early_memremap(efi_mem_attr_table, sizeof(*tbl));
if (!tbl) {
- pr_err("Failed to map EFI Memory Attributes table @ 0x%lx\n",
+ pr_err(FW_BUG "Failed to map EFI Memory Attributes table @ 0x%lx\n",
efi_mem_attr_table);
return;
}
if (tbl->version > 2) {
- pr_warn("Unexpected EFI Memory Attributes table version %d\n",
+ pr_warn(FW_BUG "Unexpected EFI Memory Attributes table version %d\n",
tbl->version);
goto unmap;
}
--
2.43.5
next prev parent reply other threads:[~2025-01-06 19:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 19:02 [PATCH 0/3] efi/memattr: Improve the efi_memattr_init function Breno Leitao
2025-01-06 19:02 ` [PATCH 1/3] efi/memattr: Convert efi_memattr_init() return type to void Breno Leitao
2025-01-06 19:24 ` Ard Biesheuvel
2025-01-06 19:02 ` Breno Leitao [this message]
2025-01-06 19:25 ` [PATCH 2/3] efi/memattr: Add FW_BUG prefix to firmware error messages Ard Biesheuvel
2025-01-06 19:02 ` [PATCH 3/3] efi/memattr: Include EFI memmap size in corruption warnings Breno Leitao
2025-01-07 11:24 ` Ard Biesheuvel
2025-01-07 12:05 ` Breno Leitao
2025-01-09 14:48 ` Ard Biesheuvel
2025-01-09 15:09 ` Usama Arif
2025-01-09 17:45 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106-efi_fw_bug-v1-2-01a8eb40bfeb@debian.org \
--to=leitao@debian.org \
--cc=ardb@kernel.org \
--cc=gourry@gourry.net \
--cc=kernel-team@meta.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=usamaarif642@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox