[PATCH 0/2] drm,efi: Export efi_mem_desc_lookup for efidrm

[PATCH 0/2] drm,efi: Export efi_mem_desc_lookup for efidrm

[Thomas Zimmermann]

Efidrm invokes efi_mem_desc_lookup(). Export the symbol to enable
module builds of efidrm.

Thomas Zimmermann (2):
  efi: Export symbol efi_mem_desc_lookup
  drm/sysfb: efidrm: Support module builds

 drivers/firmware/efi/efi.c    | 1 +
 drivers/gpu/drm/sysfb/Kconfig | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.49.0

[PATCH 1/2] efi: Export symbol efi_mem_desc_lookup

[Thomas Zimmermann]

Building efidrm as module requires efi_mem_desc_lookup(). Export
the symbol.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/firmware/efi/efi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 7309394b8fc98..e57bff702b5f4 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -558,6 +558,7 @@ int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 
 extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 	__weak __alias(__efi_mem_desc_lookup);
+EXPORT_SYMBOL_GPL(efi_mem_desc_lookup);
 
 /*
  * Calculate the highest address of an efi memory descriptor.
-- 
2.49.0

Re: [PATCH 1/2] efi: Export symbol efi_mem_desc_lookup

[Ard Biesheuvel]

On Tue, 8 Apr 2025 at 11:22, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Building efidrm as module requires efi_mem_desc_lookup(). Export
> the symbol.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  drivers/firmware/efi/efi.c | 1 +
>  1 file changed, 1 insertion(+)
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

Feel free to take this via a DRM tree.


> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 7309394b8fc98..e57bff702b5f4 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -558,6 +558,7 @@ int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
>
>  extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
>         __weak __alias(__efi_mem_desc_lookup);
> +EXPORT_SYMBOL_GPL(efi_mem_desc_lookup);
>
>  /*
>   * Calculate the highest address of an efi memory descriptor.
> --
> 2.49.0
>

Re: [PATCH 1/2] efi: Export symbol efi_mem_desc_lookup

[Thomas Zimmermann]

Am 08.04.25 um 11:40 schrieb Ard Biesheuvel:
> On Tue, 8 Apr 2025 at 11:22, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> Building efidrm as module requires efi_mem_desc_lookup(). Export
>> the symbol.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>   drivers/firmware/efi/efi.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>

Thanks a lot.

>
> Feel free to take this via a DRM tree.

I'll do that.

Best regards
Thomas

>
>
>> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
>> index 7309394b8fc98..e57bff702b5f4 100644
>> --- a/drivers/firmware/efi/efi.c
>> +++ b/drivers/firmware/efi/efi.c
>> @@ -558,6 +558,7 @@ int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
>>
>>   extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
>>          __weak __alias(__efi_mem_desc_lookup);
>> +EXPORT_SYMBOL_GPL(efi_mem_desc_lookup);
>>
>>   /*
>>    * Calculate the highest address of an efi memory descriptor.
>> --
>> 2.49.0
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: [PATCH 1/2] efi: Export symbol efi_mem_desc_lookup

[Javier Martinez Canillas]

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Building efidrm as module requires efi_mem_desc_lookup(). Export
> the symbol.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

[PATCH 2/2] drm/sysfb: efidrm: Support module builds

[Thomas Zimmermann]

Make CONFIG_DRM_EFIDRM a tristate to enable module builds.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/sysfb/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/sysfb/Kconfig b/drivers/gpu/drm/sysfb/Kconfig
index 5ac71d5ff8edf..9c9884c7efc6c 100644
--- a/drivers/gpu/drm/sysfb/Kconfig
+++ b/drivers/gpu/drm/sysfb/Kconfig
@@ -8,8 +8,8 @@ config DRM_SYSFB_HELPER
 	depends on DRM
 
 config DRM_EFIDRM
-	bool "EFI framebuffer driver"
-	depends on (DRM=y) && MMU && EFI && (!SYSFB_SIMPLEFB || COMPILE_TEST)
+	tristate "EFI framebuffer driver"
+	depends on DRM && MMU && EFI && (!SYSFB_SIMPLEFB || COMPILE_TEST)
 	select APERTURE_HELPERS
 	select DRM_CLIENT_SELECTION
 	select DRM_GEM_SHMEM_HELPER
-- 
2.49.0

Re: [PATCH 2/2] drm/sysfb: efidrm: Support module builds

[Javier Martinez Canillas]

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Make CONFIG_DRM_EFIDRM a tristate to enable module builds.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat