From: Julian Braha <julianbraha@gmail.com>
To: ardb@kernel.org
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers: firmware: fix kconfig dependency on CRYPTO
Date: Fri, 19 Feb 2021 18:46:10 -0500 [thread overview]
Message-ID: <3079145.qOpluECk2m@ubuntu-mate-laptop> (raw)
commit 72304490d9df7d6af2e6851cc5762908abd52889
Author: Julian Braha <julianbraha@gmail.com>
Date: Fri Feb 19 18:36:22 2021 -0500
drivers: firmware: fix kconfig dependency on CRYPTO
When EFI_EMBEDDED_FIRMWARE is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256,
without depending on or selecting CRYPTO, despite that config option
being subordinate to CRYPTO.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2c3dac5ecb36..f914da9845ac 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -248,6 +248,7 @@ endmenu
config EFI_EMBEDDED_FIRMWARE
bool
depends on EFI
+ select CRYPTO
select CRYPTO_LIB_SHA256
config UEFI_CPER
reply other threads:[~2021-02-19 23:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3079145.qOpluECk2m@ubuntu-mate-laptop \
--to=julianbraha@gmail.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox