* [PATCH] drivers: firmware: fix kconfig dependency on CRYPTO
@ 2021-02-19 23:46 Julian Braha
0 siblings, 0 replies; only message in thread
From: Julian Braha @ 2021-02-19 23:46 UTC (permalink / raw)
To: ardb; +Cc: linux-efi, linux-kernel
commit 72304490d9df7d6af2e6851cc5762908abd52889
Author: Julian Braha <julianbraha@gmail.com>
Date: Fri Feb 19 18:36:22 2021 -0500
drivers: firmware: fix kconfig dependency on CRYPTO
When EFI_EMBEDDED_FIRMWARE is enabled and CRYPTO is disabled,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256,
without depending on or selecting CRYPTO, despite that config option
being subordinate to CRYPTO.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2c3dac5ecb36..f914da9845ac 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -248,6 +248,7 @@ endmenu
config EFI_EMBEDDED_FIRMWARE
bool
depends on EFI
+ select CRYPTO
select CRYPTO_LIB_SHA256
config UEFI_CPER
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-19 23:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-19 23:46 [PATCH] drivers: firmware: fix kconfig dependency on CRYPTO Julian Braha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox