From: Maniaxx <tripleshiftone@gmail.com>
To: linux-acpi@vger.kernel.org
Cc: linux-efi@vger.kernel.org
Subject: Re: PROBLEM: Kernel panic on EFI BGRT early init code (kernel 4.11/4.12rc2) [regression]
Date: Sun, 4 Jun 2017 02:11:36 +0200 [thread overview]
Message-ID: <4b651aea-0fcc-4f70-cf39-3a46393d2e28@gmail.com> (raw)
In-Reply-To: <c1505b0e-8136-86d3-e6ab-019c17106e5b@gmail.com>
New kernel (with early_init panic):
In contrast to old kernel early_memremap is successful and
"Ignoring BGRT: failed to map image header memory" condition
isn't triggered.
https://github.com/torvalds/linux/blob/v4.11-rc1/arch/x86/platform/efi/efi-bgrt.c#L65
The next memcpy is the culprit for the panic. I've checked that with printk.
https://github.com/torvalds/linux/blob/v4.11-rc1/arch/x86/platform/efi/efi-bgrt.c#L71
This leads to this commit:
https://github.com/torvalds/linux/commit/66dbe99cfe30e113d2e571e68b9b6a1a8985a157
My u64 image address might be complete garbage (0A08E01800000001). Rather looks like
2x u32. Here is another BGRT image address that looks much more valid than mine
(on boundary, lower mem area).
https://ubuntuforums.org/showthread.php?t=2264380
If so, we are poking in invalid memory areas.
Reverting the commit until a better way is found to identify a valid
image address should fix the problem.
next prev parent reply other threads:[~2017-06-04 0:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86c36f9b-f633-3354-d676-7693f35dae0d@gmail.com>
[not found] ` <86c36f9b-f633-3354-d676-7693f35dae0d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-26 1:23 ` PROBLEM: Kernel panic on EFI BGRT early init code (kernel 4.11/4.12rc2) [regression] Dave Young
[not found] ` <a32eea98-9576-1ee7-c27a-b165204d825f@gmail.com>
[not found] ` <a32eea98-9576-1ee7-c27a-b165204d825f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-27 5:14 ` Dave Young
[not found] ` <20170527051427.GA3492-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-05-27 5:34 ` Dave Young
[not found] ` <20170527053457.GB3492-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-06-01 1:17 ` Maniaxx
2017-06-01 1:57 ` Dave Young
[not found] ` <20170601015621.GA4306-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-06-01 19:13 ` Maniaxx
2017-06-02 2:51 ` Dave Young
2017-06-03 18:24 ` Maniaxx
2017-06-04 0:11 ` Maniaxx [this message]
2017-06-04 2:45 ` Maniaxx
2017-06-07 8:57 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b651aea-0fcc-4f70-cf39-3a46393d2e28@gmail.com \
--to=tripleshiftone@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox