Re: [PATCH V2 1/2] efi: move ARM CPER code to new file

[Tyler Baicar <tbaicar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

On 12/7/2017 2:38 PM, Ard Biesheuvel wrote:
>> diff --git a/include/linux/cper.h b/include/linux/cper.h
>> index 723e952..0a2d5c5 100644
>> --- a/include/linux/cper.h
>> +++ b/include/linux/cper.h
>> @@ -494,6 +494,13 @@ struct cper_sec_pcie {
>>   /* Reset to default packing */
>>   #pragma pack()
>>
>> +static const char * const proc_error_type_strs[] = {
>> +       "cache error",
>> +       "TLB error",
>> +       "bus error",
>> +       "micro-architectural error",
>> +};
>> +
> Could we keep this in cper.c, and replace this with
>
> extern const char * const cper_proc_error_type_strs[];
>
> instead? I'm not too keen on putting definitions (other than static
> inline functions) in header files.
>
Hello Ard,

Yes, I will make this change.

Thanks,
Tyler

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.