From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: Laurent Pinchart <laurentp@cse-semaphore.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk,
linux-embedded@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v3)
Date: Tue, 11 Nov 2008 11:03:52 +0200 [thread overview]
Message-ID: <49194A78.8040202@teltonika.lt> (raw)
In-Reply-To: <200811101815.54126.laurentp@cse-semaphore.com>
Laurent Pinchart wrote:
> Hi Paulius,
>
> sorry for the late reply. I've been busy at work with a release and had no
> time to test the patch. Comments follow.
>
> On Monday 10 November 2008, Paulius Zaleckas wrote:
>> make mdio-gpio work with non OpenFirmware gpio implementation.
>>
>> Aditional changes to mdio-gpio:
>> - use gpio_request() and gpio_free()
>> - place irq[] array in struct mdio_gpio_info
>> - add module description, author and license
>> - add note about compiling this driver as module
>> - rename mdc and mdio function (were ugly names)
>> - change MII to MDIO in bus name
>> - add __init __exit to module (un)loading functions
>> - probe fails if no phys added to the bus
>> - kzalloc bitbang with sizeof(*bitbang)
>>
>> Changes since v2:
>> - more #ifdefs reduction
>> - platform driver will be registered on OF platforms also
>> - unified platform and OF bus_id to phy%i
>>
>> Changes since v1:
>> - removed NO_IRQ
>> - reduced #idefs
>>
>> Laurent, please test this driver under OF.
>
> Unfortunately this breaks on OF platforms (at least on mine):
>
> ~ # ifconfig eth0 up
> [ 258.886051] eb:01 not found
> [ 258.887409] eth0: Could not attach to phy
>
> The bus id was "%x"...
>
> And you renamed it to phy%i. Ethernet drivers relying on the id should be
> updated as well.
I done this to be closer to what phylib documentation says...
I did search over drivers and found out that almost all of them uses "%x"...
> Updating drivers/net/fs_enet/fs_enet-main.c (in find_phy) fixed the problem
> for my platform. Please not that this requires a change to
> drivers/net/fs_enet/mii-bitbang.c (in fs_mii_bitbang_init) as well.
A lot more than that...
So actually it is better to just change it back to "%x".
Waiting for comments from other people and I will respin patch with this change.
prev parent reply other threads:[~2008-11-11 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 15:11 [PATCH] phylib: make mdio-gpio work without OF (v3) Paulius Zaleckas
2008-11-10 17:15 ` Laurent Pinchart
2008-11-11 9:03 ` Paulius Zaleckas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49194A78.8040202@teltonika.lt \
--to=paulius.zaleckas@teltonika.lt \
--cc=grant.likely@secretlab.ca \
--cc=laurentp@cse-semaphore.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox