[PATCH] uio: add ioctl callback

[PATCH] uio: add ioctl callback

[Neil Armstrong]

[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]

Add an ioctl callback to the UIO device class.
This can be useful when status and data are needed after an interrupt
occurs.

Changes :
 - Add an uio_ioctl method
 - Add en ioctl entry in uio_info

Neil Armstrong <narmstrong@neotion.com>

Index: drivers/uio/uio.c
===================================================================
--- drivers/uio/uio.c    (revision 80)
+++ drivers/uio/uio.c    (working copy)
@@ -378,6 +378,17 @@
     return 0;
 }
 
+static int uio_ioctl(struct inode *inode, struct file *filep, unsigned
int cmd, unsigned long arg)
+{
+    struct uio_listener *listener = filep->private_data;
+    struct uio_device *idev = listener->dev;
+   
+    if (idev->info->ioctl)
+        return idev->info->ioctl(idev->info, cmd, arg);
+   
+    return -ENOSYS;
+}
+
 static ssize_t uio_read(struct file *filep, char __user *buf,
             size_t count, loff_t *ppos)
 {
@@ -575,6 +586,7 @@
     .mmap        = uio_mmap,
     .poll        = uio_poll,
     .fasync        = uio_fasync,
+   .ioctl      = uio_ioctl,
 };
 
 static int uio_major_init(void)
Index: include/linux/uio_driver.h
===================================================================
--- include/linux/uio_driver.h    (revision 80)
+++ include/linux/uio_driver.h    (working copy)
@@ -68,6 +68,7 @@
     int (*open)(struct uio_info *info, struct inode *inode);
     int (*release)(struct uio_info *info, struct inode *inode);
     int (*irqcontrol)(struct uio_info *info, s32 irq_on);
+    int (*ioctl)(struct uio_info *info, unsigned int cmd, unsigned long
arg);
 };
 
 extern int __must_check


[-- Attachment #1.2: narmstrong.vcf --]
[-- Type: text/x-vcard, Size: 319 bytes --]

begin:vcard
fn:Neil Armstrong
n:Armstrong;Neil
org:Neotion;Neotion Sophia Antipolis
adr:;;;Sophia Antipolis;;;France
email;internet:narmstrong@neotion.com
title:Embedded Linux Software Engineer
tel;cell:0667474169
note:PGP 0x1166F485
x-mozilla-html:FALSE
url:http://www.neotion.com
version:2.1
end:vcard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [PATCH] uio: add ioctl callback

[Marco Stornelli]

Read the file SubmittingPatches in your kernel documentation folder
before sending a patch. In addition, check the patch with checkpatch
script. You can find the script in the script kernel folder. Send the
patch with the right destination. You can know the names (and emails) of
the maintainers in the MAINTAINER file in the kernel source.

Regards,

Marco


Neil Armstrong wrote:
> Add an ioctl callback to the UIO device class.
> This can be useful when status and data are needed after an interrupt
> occurs.
> 
> Changes :
>  - Add an uio_ioctl method
>  - Add en ioctl entry in uio_info
> 
> Neil Armstrong <narmstrong@neotion.com>
> 
> Index: drivers/uio/uio.c
> ===================================================================
> --- drivers/uio/uio.c    (revision 80)
> +++ drivers/uio/uio.c    (working copy)
> @@ -378,6 +378,17 @@
>      return 0;
>  }
>  
> +static int uio_ioctl(struct inode *inode, struct file *filep, unsigned
> int cmd, unsigned long arg)
> +{
> +    struct uio_listener *listener = filep->private_data;
> +    struct uio_device *idev = listener->dev;
> +   
> +    if (idev->info->ioctl)
> +        return idev->info->ioctl(idev->info, cmd, arg);
> +   
> +    return -ENOSYS;
> +}
> +
>  static ssize_t uio_read(struct file *filep, char __user *buf,
>              size_t count, loff_t *ppos)
>  {
> @@ -575,6 +586,7 @@
>      .mmap        = uio_mmap,
>      .poll        = uio_poll,
>      .fasync        = uio_fasync,
> +   .ioctl      = uio_ioctl,
>  };
>  
>  static int uio_major_init(void)
> Index: include/linux/uio_driver.h
> ===================================================================
> --- include/linux/uio_driver.h    (revision 80)
> +++ include/linux/uio_driver.h    (working copy)
> @@ -68,6 +68,7 @@
>      int (*open)(struct uio_info *info, struct inode *inode);
>      int (*release)(struct uio_info *info, struct inode *inode);
>      int (*irqcontrol)(struct uio_info *info, s32 irq_on);
> +    int (*ioctl)(struct uio_info *info, unsigned int cmd, unsigned long
> arg);
>  };
>  
>  extern int __must_check
>