Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: zbestahu@gmail.com (Yue Hu)
Subject: [PATCH] erofs-utils: correct --with-lz4 example in README
Date: Mon, 3 Jun 2019 08:40:49 +0800	[thread overview]
Message-ID: <20190603084049.000004bf.zbestahu@gmail.com> (raw)
In-Reply-To: <852d84fb-8073-0f3e-bca5-2716788c8149@aol.com>

On Sat, 1 Jun 2019 13:38:09 +0800
Gao Xiang <hsiangkao@aol.com> wrote:

> On 2019/5/31 ??????5:27, Yue Hu wrote:
> > From: Yue Hu <huyue2 at yulong.com>
> > 
> > Option --with-lz4 means LZ4 install directory rather than LZ4 lib
> > directory. We will meet configuration error due to wrong path if
> > setting --with-lz4 to /usr/local/lib. Also stay the same with LZ4
> > help in configure shell script.
> > 
> > Signed-off-by: Yue Hu <huyue2 at yulong.com>  
> 
> Applied to mkfs-dev. However, I'd suggest to take a look at new
> erofs-utils since I want to mark old mkfs.erofs as obsoleted...

Ok, got it.

Thx.

> 
> Thanks,
> Gao Xiang
> 
> > ---
> >  README | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/README b/README
> > index 9014268..97eb228 100644
> > --- a/README
> > +++ b/README
> > @@ -19,8 +19,8 @@ Dependencies
> >  
> >  How to build with lz4 static library
> >  	./configure --with-lz4=<lz4 install path>
> > -eg. if lz4 lib has been installed into fold of /usr/local/lib
> > -	./configure --with-lz4=/usr/local/lib && make
> > +eg. if lz4 has been installed into fold of /usr/local
> > +	./configure --with-lz4=/usr/local && make
> >  On Fedora, static lz4 can be installed using:
> >  	yum install lz4-static.x86_64
> >  To build you should run this first:
> >   

      reply	other threads:[~2019-06-03  0:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  9:27 [PATCH] erofs-utils: correct --with-lz4 example in README Yue Hu
2019-06-01  5:38 ` Gao Xiang
2019-06-03  0:40   ` Yue Hu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603084049.000004bf.zbestahu@gmail.com \
    --to=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox