Linux-EROFS Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] erofs-utils: correct --with-lz4 example in README
@ 2019-05-31  9:27 Yue Hu
  2019-06-01  5:38 ` Gao Xiang
  0 siblings, 1 reply; 3+ messages in thread
From: Yue Hu @ 2019-05-31  9:27 UTC (permalink / raw)


From: Yue Hu <huyue2@yulong.com>

Option --with-lz4 means LZ4 install directory rather than LZ4 lib
directory. We will meet configuration error due to wrong path if
setting --with-lz4 to /usr/local/lib. Also stay the same with LZ4
help in configure shell script.

Signed-off-by: Yue Hu <huyue2 at yulong.com>
---
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README b/README
index 9014268..97eb228 100644
--- a/README
+++ b/README
@@ -19,8 +19,8 @@ Dependencies
 
 How to build with lz4 static library
 	./configure --with-lz4=<lz4 install path>
-eg. if lz4 lib has been installed into fold of /usr/local/lib
-	./configure --with-lz4=/usr/local/lib && make
+eg. if lz4 has been installed into fold of /usr/local
+	./configure --with-lz4=/usr/local && make
 On Fedora, static lz4 can be installed using:
 	yum install lz4-static.x86_64
 To build you should run this first:
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] erofs-utils: correct --with-lz4 example in README
  2019-05-31  9:27 [PATCH] erofs-utils: correct --with-lz4 example in README Yue Hu
@ 2019-06-01  5:38 ` Gao Xiang
  2019-06-03  0:40   ` Yue Hu
  0 siblings, 1 reply; 3+ messages in thread
From: Gao Xiang @ 2019-06-01  5:38 UTC (permalink / raw)




On 2019/5/31 ??????5:27, Yue Hu wrote:
> From: Yue Hu <huyue2 at yulong.com>
> 
> Option --with-lz4 means LZ4 install directory rather than LZ4 lib
> directory. We will meet configuration error due to wrong path if
> setting --with-lz4 to /usr/local/lib. Also stay the same with LZ4
> help in configure shell script.
> 
> Signed-off-by: Yue Hu <huyue2 at yulong.com>

Applied to mkfs-dev. However, I'd suggest to take a look at new
erofs-utils since I want to mark old mkfs.erofs as obsoleted...

Thanks,
Gao Xiang

> ---
>  README | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/README b/README
> index 9014268..97eb228 100644
> --- a/README
> +++ b/README
> @@ -19,8 +19,8 @@ Dependencies
>  
>  How to build with lz4 static library
>  	./configure --with-lz4=<lz4 install path>
> -eg. if lz4 lib has been installed into fold of /usr/local/lib
> -	./configure --with-lz4=/usr/local/lib && make
> +eg. if lz4 has been installed into fold of /usr/local
> +	./configure --with-lz4=/usr/local && make
>  On Fedora, static lz4 can be installed using:
>  	yum install lz4-static.x86_64
>  To build you should run this first:
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] erofs-utils: correct --with-lz4 example in README
  2019-06-01  5:38 ` Gao Xiang
@ 2019-06-03  0:40   ` Yue Hu
  0 siblings, 0 replies; 3+ messages in thread
From: Yue Hu @ 2019-06-03  0:40 UTC (permalink / raw)


On Sat, 1 Jun 2019 13:38:09 +0800
Gao Xiang <hsiangkao@aol.com> wrote:

> On 2019/5/31 ??????5:27, Yue Hu wrote:
> > From: Yue Hu <huyue2 at yulong.com>
> > 
> > Option --with-lz4 means LZ4 install directory rather than LZ4 lib
> > directory. We will meet configuration error due to wrong path if
> > setting --with-lz4 to /usr/local/lib. Also stay the same with LZ4
> > help in configure shell script.
> > 
> > Signed-off-by: Yue Hu <huyue2 at yulong.com>  
> 
> Applied to mkfs-dev. However, I'd suggest to take a look at new
> erofs-utils since I want to mark old mkfs.erofs as obsoleted...

Ok, got it.

Thx.

> 
> Thanks,
> Gao Xiang
> 
> > ---
> >  README | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/README b/README
> > index 9014268..97eb228 100644
> > --- a/README
> > +++ b/README
> > @@ -19,8 +19,8 @@ Dependencies
> >  
> >  How to build with lz4 static library
> >  	./configure --with-lz4=<lz4 install path>
> > -eg. if lz4 lib has been installed into fold of /usr/local/lib
> > -	./configure --with-lz4=/usr/local/lib && make
> > +eg. if lz4 has been installed into fold of /usr/local
> > +	./configure --with-lz4=/usr/local && make
> >  On Fedora, static lz4 can be installed using:
> >  	yum install lz4-static.x86_64
> >  To build you should run this first:
> >   

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-03  0:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-31  9:27 [PATCH] erofs-utils: correct --with-lz4 example in README Yue Hu
2019-06-01  5:38 ` Gao Xiang
2019-06-03  0:40   ` Yue Hu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox