* [PATCH 1/4] erofs-utils: lib: fix wrong forward declaration of `erofs_metamgr`
@ 2026-08-26 13:43 Gao Xiang
2026-08-26 13:43 ` [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device Gao Xiang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gao Xiang @ 2026-08-26 13:43 UTC (permalink / raw)
To: linux-erofs; +Cc: Gao Xiang
it is forward-declared as "struct erofs_metaboxmgr", but the actual
struct was already named as "erofs_metamgr" in lib/metabox.c.
This could confuse the compiler; update it to match the real name.
Signed-off-by: Gao Xiang <xiang@kernel.org>
---
include/erofs/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/erofs/internal.h b/include/erofs/internal.h
index c9c7873..514cfbd 100644
--- a/include/erofs/internal.h
+++ b/include/erofs/internal.h
@@ -89,7 +89,7 @@ struct erofs_mkfs_dfops;
struct erofs_packed_inode;
struct erofs_xattrmgr;
struct z_erofs_mgr;
-struct erofs_metaboxmgr;
+struct erofs_metamgr;
struct erofs_sb_info {
struct erofs_sb_lz4_info lz4;
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device
2026-08-26 13:43 [PATCH 1/4] erofs-utils: lib: fix wrong forward declaration of `erofs_metamgr` Gao Xiang
@ 2026-08-26 13:43 ` Gao Xiang
2026-08-27 1:30 ` Yifan Zhao
2026-08-26 13:43 ` [PATCH 3/4] erofs-utils: lib: refactor unencoded chunk handling Gao Xiang
2026-08-26 13:43 ` [PATCH 4/4] erofs-utils: get rid of hashmap Gao Xiang
2 siblings, 1 reply; 6+ messages in thread
From: Gao Xiang @ 2026-08-26 13:43 UTC (permalink / raw)
To: linux-erofs; +Cc: Gao Xiang
Source kernel commit: 7b00af2c5414dc01e0718deef7ead81102867636
Signed-off-by: Gao Xiang <xiang@kernel.org>
---
include/erofs/internal.h | 4 +---
lib/importer.c | 3 +--
lib/io.c | 8 ++++----
lib/rebuild.c | 6 +++---
lib/super.c | 18 +++++++++---------
lib/vmdk.c | 4 ++--
mkfs/main.c | 12 ++++++------
7 files changed, 26 insertions(+), 29 deletions(-)
diff --git a/include/erofs/internal.h b/include/erofs/internal.h
index 514cfbd..30dae41 100644
--- a/include/erofs/internal.h
+++ b/include/erofs/internal.h
@@ -93,11 +93,9 @@ struct erofs_metamgr;
struct erofs_sb_info {
struct erofs_sb_lz4_info lz4;
- struct erofs_device_info *devs;
- char *devname;
+ struct erofs_device_info *devs, dif0;
u64 total_blocks;
- u64 primarydevice_blocks;
s32 meta_blkaddr;
u32 xattr_blkaddr;
diff --git a/lib/importer.c b/lib/importer.c
index c404b0f..2a635d2 100644
--- a/lib/importer.c
+++ b/lib/importer.c
@@ -126,8 +126,7 @@ int erofs_importer_flush_all(struct erofs_importer *im)
fsalignblks = im->params->fsalignblks ?
roundup_pow_of_two(im->params->fsalignblks) : 1;
- sbi->primarydevice_blocks = roundup(erofs_mapbh(sbi->bmgr, NULL),
- fsalignblks);
+ sbi->dif0.blocks = roundup(erofs_mapbh(sbi->bmgr, NULL), fsalignblks);
err = erofs_write_device_table(sbi);
if (err)
return err;
diff --git a/lib/io.c b/lib/io.c
index 3ba45cc..5c5449f 100644
--- a/lib/io.c
+++ b/lib/io.c
@@ -368,8 +368,8 @@ repeat:
}
out:
- sbi->devname = strdup(dev);
- if (!sbi->devname) {
+ sbi->dif0.src_path = strdup(dev);
+ if (!sbi->dif0.src_path) {
close(fd);
return -ENOMEM;
}
@@ -381,8 +381,8 @@ out:
void erofs_dev_close(struct erofs_sb_info *sbi)
{
erofs_io_close(&sbi->bdev);
- free(sbi->devname);
- sbi->devname = NULL;
+ free(sbi->dif0.src_path);
+ sbi->dif0.src_path = NULL;
sbi->bdev.fd = -1;
}
diff --git a/lib/rebuild.c b/lib/rebuild.c
index a5308dc..6b03a52 100644
--- a/lib/rebuild.c
+++ b/lib/rebuild.c
@@ -233,7 +233,7 @@ static int erofs_rebuild_write_full_data(struct erofs_inode *inode)
return -EFSCORRUPTED;
return 0;
}
- inode->rebuild_blobpath = strdup(src_sbi->devname);
+ inode->rebuild_blobpath = strdup(src_sbi->dif0.src_path);
if (!inode->rebuild_blobpath)
return -ENOMEM;
inode->rebuild_src_dataoff =
@@ -244,7 +244,7 @@ static int erofs_rebuild_write_full_data(struct erofs_inode *inode)
unsigned int inline_size = inode->i_size % erofs_blksiz(src_sbi);
if (nblocks > 0 && inode->u.i_blkaddr != EROFS_NULL_ADDR) {
- inode->rebuild_blobpath = strdup(src_sbi->devname);
+ inode->rebuild_blobpath = strdup(src_sbi->dif0.src_path);
if (!inode->rebuild_blobpath)
return -ENOMEM;
inode->rebuild_src_dataoff =
@@ -500,7 +500,7 @@ int erofs_rebuild_load_tree(struct erofs_inode *root, struct erofs_sb_info *sbi,
struct erofs_inode inode = {};
struct erofs_rebuild_dir_context ctx;
char uuid_str[37];
- char *fsid = sbi->devname;
+ char *fsid = sbi->dif0.src_path;
int ret;
if (!fsid) {
diff --git a/lib/super.c b/lib/super.c
index d138f84..ead4170 100644
--- a/lib/super.c
+++ b/lib/super.c
@@ -33,7 +33,7 @@ static int erofs_init_devices(struct erofs_sb_info *sbi,
erofs_off_t pos;
bool _48bit = erofs_sb_has_48bit(sbi);
- sbi->total_blocks = sbi->primarydevice_blocks;
+ sbi->total_blocks = sbi->dif0.blocks;
if (!erofs_sb_has_device_table(sbi))
ondisk_extradevs = 0;
@@ -118,14 +118,14 @@ int erofs_read_superblock(struct erofs_sb_info *sbi)
erofs_err("invalid sb_extslots %u", dsb->sb_extslots);
return -EINVAL;
}
- sbi->primarydevice_blocks = le32_to_cpu(dsb->blocks_lo);
+ sbi->dif0.blocks = le32_to_cpu(dsb->blocks_lo);
sbi->meta_blkaddr = le32_to_cpu(dsb->meta_blkaddr);
sbi->xattr_blkaddr = le32_to_cpu(dsb->xattr_blkaddr);
sbi->xattr_prefix_start = le32_to_cpu(dsb->xattr_prefix_start);
sbi->xattr_prefix_count = dsb->xattr_prefix_count;
if (erofs_sb_has_48bit(sbi) && dsb->rootnid_8b) {
sbi->root_nid = le64_to_cpu(dsb->rootnid_8b);
- sbi->primarydevice_blocks = sbi->primarydevice_blocks |
+ sbi->dif0.blocks = sbi->dif0.blocks |
((u64)le16_to_cpu(dsb->rb.blocks_hi) << 32);
} else {
sbi->root_nid = le16_to_cpu(dsb->rb.rootnid_2b);
@@ -230,10 +230,10 @@ int erofs_writesb(struct erofs_sb_info *sbi)
char *buf;
int ret;
- sb.blocks_lo = cpu_to_le32(sbi->primarydevice_blocks);
- if (sbi->primarydevice_blocks > UINT32_MAX ||
+ sb.blocks_lo = cpu_to_le32(sbi->dif0.blocks);
+ if (sbi->dif0.blocks > UINT32_MAX ||
sbi->root_nid > UINT16_MAX) {
- sb.rb.blocks_hi = cpu_to_le16(sbi->primarydevice_blocks >> 32);
+ sb.rb.blocks_hi = cpu_to_le16(sbi->dif0.blocks >> 32);
sb.rootnid_8b = cpu_to_le64(sbi->root_nid);
}
memcpy(sb.uuid, sbi->uuid, sizeof(sb.uuid));
@@ -404,7 +404,7 @@ int erofs_mkfs_init_devices(struct erofs_sb_info *sbi, unsigned int devices)
int erofs_write_device_table(struct erofs_sb_info *sbi)
{
- erofs_blk_t nblocks = sbi->primarydevice_blocks;
+ erofs_blk_t nblocks = sbi->dif0.blocks;
struct erofs_buffer_head *bh = sbi->bh_devt;
erofs_off_t pos;
unsigned int i, ret;
@@ -484,7 +484,7 @@ int erofs_mkfs_load_fs(struct erofs_sb_info *sbi, unsigned int dsunit)
erofs_warn("EXPERIMENTAL incremental build in use. Use at your own risk!");
err = erofs_read_superblock(sbi);
if (err) {
- erofs_err("failed to read superblock of %s: %s", sbi->devname,
+ erofs_err("failed to read superblock of %s: %s", sbi->dif0.src_path,
erofs_strerror(err));
return err;
}
@@ -493,7 +493,7 @@ int erofs_mkfs_load_fs(struct erofs_sb_info *sbi, unsigned int dsunit)
if (!err && S_ISREG(u.st.st_mode))
u.startblk = DIV_ROUND_UP(u.st.st_size, erofs_blksiz(sbi));
else
- u.startblk = sbi->primarydevice_blocks;
+ u.startblk = sbi->dif0.blocks;
bmgr = erofs_buffer_init(sbi, u.startblk, NULL);
if (!bmgr)
diff --git a/lib/vmdk.c b/lib/vmdk.c
index 316a8ff..28381c8 100644
--- a/lib/vmdk.c
+++ b/lib/vmdk.c
@@ -51,8 +51,8 @@ int erofs_dump_vmdk_desc(FILE *f, struct erofs_sb_info *sbi)
int ret, i;
fprintf(f, desc_template_1, cid, parent_cid, subformat);
- sectors = sbi->primarydevice_blocks << (sbi->blkszbits - 9);
- ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->devname, 0);
+ sectors = sbi->dif0.blocks << (sbi->blkszbits - 9);
+ ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->dif0.blocks, 0);
if (ret)
return ret;
total_sectors = sectors;
diff --git a/mkfs/main.c b/mkfs/main.c
index 929ce7c..5bf7b8f 100644
--- a/mkfs/main.c
+++ b/mkfs/main.c
@@ -1685,12 +1685,12 @@ static int erofs_mkfs_rebuild_load_trees(struct erofs_inode *root)
ret = erofs_rebuild_load_tree(root, src, datamode);
src->xamgr = NULL;
if (ret) {
- erofs_err("failed to load %s", src->devname);
+ erofs_err("failed to load %s", src->dif0.src_path);
return ret;
}
if (src->extra_devices > 1) {
erofs_err("%s: unsupported number %u of extra devices",
- src->devname, src->extra_devices);
+ src->dif0.src_path, src->extra_devices);
return -EOPNOTSUPP;
}
extra_devices += src->extra_devices;
@@ -1723,8 +1723,8 @@ static int erofs_mkfs_rebuild_load_trees(struct erofs_inode *root)
nblocks = src->devs[0].blocks;
tag = src->devs[0].tag;
} else {
- nblocks = src->primarydevice_blocks;
- devs[idx].src_path = strdup(src->devname);
+ nblocks = src->dif0.blocks;
+ devs[idx].src_path = strdup(src->dif0.src_path);
}
devs[idx].blocks = nblocks;
if (tag && *tag)
@@ -1849,7 +1849,7 @@ int main(int argc, char **argv)
goto exit;
err = erofs_read_superblock(src);
if (err) {
- erofs_err("failed to read superblock of %s", src->devname);
+ erofs_err("failed to read superblock of %s", src->dif0.src_path);
goto exit;
}
mkfs_blkszbits = src->blkszbits;
@@ -2051,7 +2051,7 @@ int main(int argc, char **argv)
if (err)
goto exit;
- err = erofs_dev_resize(&g_sbi, g_sbi.primarydevice_blocks);
+ err = erofs_dev_resize(&g_sbi, g_sbi.dif0.blocks);
if (!err && erofs_sb_has_sb_chksum(&g_sbi)) {
err = erofs_enable_sb_chksum(&g_sbi, &crc);
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] erofs-utils: lib: refactor unencoded chunk handling
2026-08-26 13:43 [PATCH 1/4] erofs-utils: lib: fix wrong forward declaration of `erofs_metamgr` Gao Xiang
2026-08-26 13:43 ` [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device Gao Xiang
@ 2026-08-26 13:43 ` Gao Xiang
2026-08-26 13:43 ` [PATCH 4/4] erofs-utils: get rid of hashmap Gao Xiang
2 siblings, 0 replies; 6+ messages in thread
From: Gao Xiang @ 2026-08-26 13:43 UTC (permalink / raw)
To: linux-erofs; +Cc: Gao Xiang, Daniel Colascione, Friendy Su
Switch global variables to per-sb and/or per-device structures, replace
the hashmap with a bucket-list hash table, and replace open-coded blobfile
raw I/O with the buffer allocator and vfile I/O so that blob chunks won't
rely on temporary files on /tmp [1].
Future follow-ups: Optimize to the PLAIN/INLINE inode layout if no valid
deduplication chunk is found.
[ Gao Xiang: need to check if `--dsunit` works as expected in this new
implementation. ]
Reported-by: Daniel Colascione <dancol@dancol.org>
Closes: https://github.com/erofs/erofs-utils/issues/35 [1]
Cc: Friendy Su <friendy.su@sony.com>
Signed-off-by: Gao Xiang <xiang@kernel.org>
---
include/erofs/blobchunk.h | 11 +-
include/erofs/internal.h | 5 +-
lib/blobchunk.c | 422 ++++++++++++++++++++------------------
lib/rebuild.c | 4 +-
lib/super.c | 12 +-
mkfs/main.c | 27 ++-
6 files changed, 262 insertions(+), 219 deletions(-)
diff --git a/include/erofs/blobchunk.h b/include/erofs/blobchunk.h
index 1761fdd..1c8d77d 100644
--- a/include/erofs/blobchunk.h
+++ b/include/erofs/blobchunk.h
@@ -14,8 +14,9 @@ extern "C"
#include "erofs/internal.h"
-struct erofs_blobchunk *erofs_get_unhashed_chunk(unsigned int device_id,
- erofs_blk_t blkaddr, erofs_off_t sourceoffset);
+struct erofs_chunkitem *erofs_get_unhashed_chunk(struct erofs_sb_info *sbi,
+ unsigned int device_id, erofs_blk_t blkaddr,
+ erofs_off_t sourceoffset);
void erofs_inode_fixup_chunkformat(struct erofs_inode *inode);
int erofs_write_chunk_indexes(struct erofs_inode *inode, struct erofs_vfile *vf,
erofs_off_t off);
@@ -24,8 +25,10 @@ int erofs_blob_write_chunked_file(struct erofs_inode *inode, int fd,
int erofs_write_zero_inode(struct erofs_inode *inode);
int tarerofs_write_chunkes(struct erofs_inode *inode, erofs_off_t data_offset);
int erofs_mkfs_dump_blobs(struct erofs_sb_info *sbi);
-void erofs_blob_exit(void);
-int erofs_blob_init(const char *blobfile_path, erofs_off_t chunksize);
+int erofs_blob_exit(struct erofs_sb_info *sbi);
+int erofs_blob_init(struct erofs_sb_info *sbi, int blobdev_id,
+ unsigned int chunkbits_def);
+int erofs_blob_init_device(struct erofs_sb_info *sbi, int device_id);
#ifdef __cplusplus
}
diff --git a/include/erofs/internal.h b/include/erofs/internal.h
index 30dae41..95f5627 100644
--- a/include/erofs/internal.h
+++ b/include/erofs/internal.h
@@ -67,8 +67,9 @@ struct erofs_buffer_head;
struct erofs_bufmgr;
struct erofs_device_info {
- char *src_path;
u8 tag[64];
+ char *src_path;
+ struct erofs_bufmgr *bmgr;
erofs_blk_t blocks;
erofs_blk_t uniaddr;
};
@@ -90,6 +91,7 @@ struct erofs_packed_inode;
struct erofs_xattrmgr;
struct z_erofs_mgr;
struct erofs_metamgr;
+struct erofs_chunkmgr;
struct erofs_sb_info {
struct erofs_sb_lz4_info lz4;
@@ -151,6 +153,7 @@ struct erofs_sb_info {
struct erofs_bufmgr *bmgr;
struct erofs_xattrmgr *xamgr;
struct z_erofs_mgr *zmgr;
+ struct erofs_chunkmgr *chunkmgr;
struct erofs_metamgr *m2gr, *mxgr;
struct erofs_packed_inode *packedinode;
struct erofs_buffer_head *bh_sb;
diff --git a/lib/blobchunk.c b/lib/blobchunk.c
index 0523873..d307a4f 100644
--- a/lib/blobchunk.c
+++ b/lib/blobchunk.c
@@ -5,7 +5,7 @@
* Copyright (C) 2021, Alibaba Cloud
*/
#define _GNU_SOURCE
-#include "erofs/hashmap.h"
+#include "erofs/print.h"
#include "erofs/blobchunk.h"
#include "erofs/block_list.h"
#include "erofs/importer.h"
@@ -14,63 +14,98 @@
#include "liberofs_sha256.h"
#include <unistd.h>
-struct erofs_blobchunk {
- union {
- struct hashmap_entry ent;
- struct list_head list;
- };
- char sha256[32];
- unsigned int device_id;
- union {
- erofs_off_t chunksize;
- erofs_off_t sourceoffset;
+struct erofs_chunkitem {
+ u8 sha256[32];
+ struct list_head list;
+ struct {
+ unsigned int device_id;
+ union {
+ u64 chunksize;
+ erofs_off_t sourceoffset;
+ };
+ erofs_blk_t blkaddr;
};
- erofs_blk_t blkaddr;
};
-static struct hashmap blob_hashmap;
-static int blobfile = -1;
-static erofs_blk_t remapped_base;
-static erofs_off_t datablob_size;
-struct erofs_blobchunk erofs_holechunk = {
+struct erofs_chunkitem erofs_holechunk = {
.blkaddr = EROFS_NULL_ADDR,
};
-static LIST_HEAD(unhashed_blobchunks);
-struct erofs_blobchunk *erofs_get_unhashed_chunk(unsigned int device_id,
- erofs_blk_t blkaddr, erofs_off_t sourceoffset)
+struct erofs_chunkmgr {
+ struct list_head chunks[65536];
+ struct list_head unhashed_chunks;
+ int device_id;
+};
+
+#define EROFS_CHUNK_NR_BUCKETS \
+ ARRAY_SIZE(((struct erofs_chunkmgr *)0)->chunks)
+
+struct erofs_chunkitem *erofs_get_unhashed_chunk(struct erofs_sb_info *sbi,
+ unsigned int device_id, erofs_blk_t blkaddr,
+ erofs_off_t sourceoffset)
{
- struct erofs_blobchunk *chunk;
+ struct erofs_chunkmgr *chunkmgr = sbi->chunkmgr;
+ struct erofs_chunkitem *chunk;
+ int ret;
- chunk = calloc(1, sizeof(struct erofs_blobchunk));
+ if (__erofs_unlikely(!chunkmgr)) {
+ ret = erofs_blob_init(sbi, 0, 0);
+ if (ret)
+ return ERR_PTR(ret);
+ chunkmgr = sbi->chunkmgr;
+ }
+ chunk = calloc(1, sizeof(*chunk));
if (!chunk)
return ERR_PTR(-ENOMEM);
chunk->device_id = device_id;
chunk->blkaddr = blkaddr;
chunk->sourceoffset = sourceoffset;
- list_add_tail(&chunk->list, &unhashed_blobchunks);
+ list_add_tail(&chunk->list, &chunkmgr->unhashed_chunks);
return chunk;
}
-static struct erofs_blobchunk *erofs_blob_getchunk(struct erofs_sb_info *sbi,
- u8 *buf, erofs_off_t chunksize)
+#define FNV32_BASE ((unsigned int)0x811c9dc5)
+#define FNV32_PRIME ((unsigned int)0x01000193)
+
+static unsigned int memhash(const void *buf, size_t len)
+{
+ unsigned int hash = FNV32_BASE;
+ unsigned char *ucbuf = (unsigned char *)buf;
+
+ while (len--) {
+ unsigned int c = *ucbuf++;
+
+ hash = (hash * FNV32_PRIME) ^ c;
+ }
+ return hash;
+}
+
+static struct erofs_chunkitem *erofs_get_chunk(struct erofs_sb_info *sbi,
+ int device_id,
+ u8 *buf, u64 size)
{
+ struct erofs_bufmgr *bmgr = device_id ? sbi->devs[device_id - 1].bmgr : sbi->bmgr;
+ struct erofs_chunkmgr *chunkmgr = sbi->chunkmgr;
static u8 zeroed[EROFS_MAX_BLOCK_SIZE];
- struct erofs_blobchunk *chunk;
+ struct erofs_chunkitem *chunk;
+ struct erofs_buffer_head *bh;
unsigned int hash, padding;
+ struct list_head *head;
+ erofs_blk_t pos;
u8 sha256[32];
- erofs_off_t blkpos;
int ret;
- erofs_sha256(buf, chunksize, sha256);
+ erofs_sha256(buf, size, sha256);
hash = memhash(sha256, sizeof(sha256));
+ head = &chunkmgr->chunks[hash & (EROFS_CHUNK_NR_BUCKETS - 1)];
if (cfg.c_dedupe != EROFS_DEDUPE_FORCE_OFF) {
- chunk = hashmap_get_from_hash(&blob_hashmap, hash, sha256);
- if (chunk) {
- DBG_BUGON(chunksize != chunk->chunksize);
-
- sbi->saved_by_deduplication += chunksize;
+ list_for_each_entry(chunk, head, list) {
+ if (chunk->chunksize != size)
+ continue;
+ if (memcmp(chunk->sha256, sha256, sizeof(sha256)))
+ continue;
+ sbi->saved_by_deduplication += size;
if (chunk->blkaddr == erofs_holechunk.blkaddr) {
chunk = &erofs_holechunk;
erofs_dbg("Found duplicated hole chunk");
@@ -82,29 +117,34 @@ static struct erofs_blobchunk *erofs_blob_getchunk(struct erofs_sb_info *sbi,
}
}
- chunk = malloc(sizeof(struct erofs_blobchunk));
+ chunk = malloc(sizeof(*chunk));
if (!chunk)
return ERR_PTR(-ENOMEM);
- chunk->chunksize = chunksize;
+ chunk->chunksize = size;
memcpy(chunk->sha256, sha256, sizeof(sha256));
- blkpos = lseek(blobfile, 0, SEEK_CUR);
- DBG_BUGON(erofs_blkoff(sbi, blkpos));
- if (sbi->extra_devices)
- chunk->device_id = 1;
- else
- chunk->device_id = 0;
- chunk->blkaddr = erofs_blknr(sbi, blkpos);
-
- erofs_dbg("Writing chunk (%llu bytes) to %llu", chunksize | 0ULL,
- chunk->blkaddr | 0ULL);
- ret = __erofs_io_write(blobfile, buf, chunksize);
- if (ret == chunksize) {
- padding = erofs_blkoff(sbi, chunksize);
+ chunk->device_id = device_id;
+ bh = erofs_balloc(bmgr, DATA, size, 0);
+ if (IS_ERR(bh)) {
+ free(chunk);
+ return ERR_CAST(bh);
+ }
+ bh->op = &erofs_drop_directly_bhops;
+ erofs_mapbh(NULL, bh->block);
+ pos = erofs_btell(bh, false);
+ chunk->blkaddr = pos >> sbi->blkszbits;
+
+ erofs_dbg("Writing chunk (%llu bytes) to %llu (device %d)",
+ size | 0ULL, chunk->blkaddr | 0ULL, chunk->device_id);
+
+ ret = erofs_io_pwrite(bmgr->vf, buf, pos, size);
+ if (ret == size) {
+ padding = erofs_blkoff(sbi, size);
if (padding) {
padding = erofs_blksiz(sbi) - padding;
- ret = __erofs_io_write(blobfile, zeroed, padding);
+ ret = erofs_io_pwrite(bmgr->vf, zeroed,
+ pos + size, padding);
if (ret > 0 && ret != padding)
ret = -EIO;
}
@@ -113,29 +153,15 @@ static struct erofs_blobchunk *erofs_blob_getchunk(struct erofs_sb_info *sbi,
}
if (ret < 0) {
+ erofs_bdrop(bh, true);
free(chunk);
return ERR_PTR(ret);
}
-
- hashmap_entry_init(&chunk->ent, hash);
- hashmap_add(&blob_hashmap, chunk);
+ list_add(&chunk->list, head);
+ erofs_bdrop(bh, false);
return chunk;
}
-static int erofs_blob_hashmap_cmp(const void *a, const void *b,
- const void *key)
-{
- const struct erofs_blobchunk *ec1 =
- container_of((struct hashmap_entry *)a,
- struct erofs_blobchunk, ent);
- const struct erofs_blobchunk *ec2 =
- container_of((struct hashmap_entry *)b,
- struct erofs_blobchunk, ent);
-
- return memcmp(ec1->sha256, key ? key : ec2->sha256,
- sizeof(ec1->sha256));
-}
-
void erofs_inode_fixup_chunkformat(struct erofs_inode *inode)
{
unsigned int unit, src;
@@ -153,17 +179,12 @@ void erofs_inode_fixup_chunkformat(struct erofs_inode *inode)
extent_count = inode->extent_isize / unit;
for (src = 0; src < extent_count; ++src) {
- struct erofs_blobchunk *chunk =
+ struct erofs_chunkitem *chunk =
*(void **)(inode->chunkindexes + src * sizeof(void *));
if (chunk->blkaddr == EROFS_NULL_ADDR)
continue;
- if (chunk->device_id) {
- if (chunk->blkaddr > UINT32_MAX) {
- _48bit = true;
- break;
- }
- } else if (remapped_base + chunk->blkaddr > UINT32_MAX) {
+ if (chunk->blkaddr > UINT32_MAX) {
_48bit = true;
break;
}
@@ -193,7 +214,7 @@ int erofs_write_chunk_indexes(struct erofs_inode *inode, struct erofs_vfile *vf,
_48bit = inode->u.chunkformat & EROFS_CHUNK_FORMAT_48BIT;
for (dst = src = 0; dst < inode->extent_isize;
src += sizeof(void *), dst += unit) {
- struct erofs_blobchunk *chunk;
+ struct erofs_chunkitem *chunk;
erofs_blk_t startblk;
chunk = *(void **)(inode->chunkindexes + src);
@@ -205,7 +226,7 @@ int erofs_write_chunk_indexes(struct erofs_inode *inode, struct erofs_vfile *vf,
startblk = chunk->blkaddr;
extent_start = EROFS_NULL_ADDR;
} else {
- startblk = remapped_base + chunk->blkaddr;
+ startblk = chunk->blkaddr;
}
if (extent_start == EROFS_NULL_ADDR || startblk != extent_end) {
@@ -286,8 +307,8 @@ static void erofs_update_minextblks(struct erofs_sb_info *sbi,
*minextblks = lb;
}
static bool erofs_blob_can_merge(struct erofs_sb_info *sbi,
- struct erofs_blobchunk *lastch,
- struct erofs_blobchunk *chunk)
+ struct erofs_chunkitem *lastch,
+ struct erofs_chunkitem *chunk)
{
if (!lastch)
return true;
@@ -300,13 +321,16 @@ static bool erofs_blob_can_merge(struct erofs_sb_info *sbi,
return false;
}
+
int erofs_blob_write_chunked_file(struct erofs_inode *inode, int fd,
erofs_off_t startoff)
{
struct erofs_sb_info *sbi = inode->sbi;
- unsigned int chunkbits = cfg.c_chunkbits;
+ struct erofs_chunkmgr *cmgr = sbi->chunkmgr;
+ int device_id = cmgr->device_id;
+ unsigned int chunkbits = inode->u.chunkbits;
unsigned int count, unit;
- struct erofs_blobchunk *chunk, *lastch;
+ struct erofs_chunkitem *chunk, *lastch;
struct erofs_inode_chunk_index *idx;
erofs_off_t pos, len, chunksize, interval_start;
erofs_blk_t minextblks;
@@ -324,7 +348,7 @@ int erofs_blob_write_chunked_file(struct erofs_inode *inode, int fd,
chunksize = 1ULL << chunkbits;
count = DIV_ROUND_UP(inode->i_size, chunksize);
- if (sbi->extra_devices)
+ if (device_id)
inode->u.chunkformat |= EROFS_CHUNK_FORMAT_INDEXES;
if (inode->u.chunkformat & EROFS_CHUNK_FORMAT_INDEXES)
unit = sizeof(struct erofs_inode_chunk_index);
@@ -346,26 +370,6 @@ int erofs_blob_write_chunked_file(struct erofs_inode *inode, int fd,
minextblks = BLK_ROUND_UP(sbi, inode->i_size);
interval_start = 0;
- /*
- * If dsunit <= chunksize, deduplication will not cause misalignment,
- * so it's uncontroversial to apply the current data alignment policy.
- */
- if (sbi->bmgr->dsunit > 1 &&
- sbi->bmgr->dsunit <= (1u << (chunkbits - sbi->blkszbits))) {
- off_t off = lseek(blobfile, 0, SEEK_CUR);
-
- off = roundup(off, sbi->bmgr->dsunit * erofs_blksiz(sbi));
- if (lseek(blobfile, off, SEEK_SET) != off) {
- ret = -errno;
- erofs_err("failed to lseek blobdev@0x%llx: %s", off,
- erofs_strerror(ret));
- goto err;
- }
- erofs_dbg("Align /%s on block #%llu (0x%llx)",
- erofs_fspath(inode->i_srcpath),
- erofs_blknr(sbi, off) | 0ULL, off);
- }
-
for (pos = 0; pos < inode->i_size; pos += len) {
off_t offset = lseek(fd, pos + startoff, SEEK_DATA);
@@ -411,7 +415,7 @@ int erofs_blob_write_chunked_file(struct erofs_inode *inode, int fd,
goto err;
}
- chunk = erofs_blob_getchunk(sbi, chunkdata, len);
+ chunk = erofs_get_chunk(sbi, device_id, chunkdata, len);
if (IS_ERR(chunk)) {
ret = PTR_ERR(chunk);
goto err;
@@ -462,10 +466,10 @@ int erofs_write_zero_inode(struct erofs_inode *inode)
inode->chunkindexes = idx;
for (pos = 0; pos < inode->i_size; pos += len) {
- struct erofs_blobchunk *chunk;
+ struct erofs_chunkitem *chunk;
len = min_t(erofs_off_t, inode->i_size - pos, chunksize);
- chunk = erofs_get_unhashed_chunk(0, EROFS_NULL_ADDR, -1);
+ chunk = erofs_get_unhashed_chunk(sbi, 0, EROFS_NULL_ADDR, -1);
if (IS_ERR(chunk)) {
free(inode->chunkindexes);
inode->chunkindexes = NULL;
@@ -483,9 +487,10 @@ int tarerofs_write_chunkes(struct erofs_inode *inode, erofs_off_t data_offset)
struct erofs_sb_info *sbi = inode->sbi;
unsigned int chunkbits = ilog2(inode->i_size - 1) + 1;
unsigned int count, unit, device_id;
+ struct erofs_inode_chunk_index *idx;
+ struct erofs_buffer_head *bh;
erofs_off_t chunksize, len, pos;
erofs_blk_t blkaddr;
- struct erofs_inode_chunk_index *idx;
if (chunkbits < sbi->blkszbits)
chunkbits = sbi->blkszbits;
@@ -502,9 +507,14 @@ int tarerofs_write_chunkes(struct erofs_inode *inode, erofs_off_t data_offset)
} else {
device_id = 0;
unit = EROFS_BLOCK_MAP_ENTRY_SIZE;
- DBG_BUGON(erofs_blkoff(sbi, datablob_size));
- blkaddr = erofs_blknr(sbi, datablob_size);
- datablob_size += round_up(inode->i_size, erofs_blksiz(sbi));
+ bh = erofs_balloc(sbi->bmgr, DATA,
+ round_up(inode->i_size, erofs_blksiz(sbi)), 0);
+ if (IS_ERR(bh))
+ return PTR_ERR(bh);
+ bh->op = &erofs_drop_directly_bhops;
+ erofs_mapbh(NULL, bh->block);
+ blkaddr = erofs_btell(bh, false) >> sbi->blkszbits;
+ erofs_bdrop(bh, false);
}
chunksize = 1ULL << chunkbits;
count = DIV_ROUND_UP(inode->i_size, chunksize);
@@ -516,11 +526,11 @@ int tarerofs_write_chunkes(struct erofs_inode *inode, erofs_off_t data_offset)
inode->chunkindexes = idx;
for (pos = 0; pos < inode->i_size; pos += len) {
- struct erofs_blobchunk *chunk;
+ struct erofs_chunkitem *chunk;
len = min_t(erofs_off_t, inode->i_size - pos, chunksize);
- chunk = erofs_get_unhashed_chunk(device_id, blkaddr,
+ chunk = erofs_get_unhashed_chunk(sbi, device_id, blkaddr,
data_offset);
if (IS_ERR(chunk)) {
free(inode->chunkindexes);
@@ -548,93 +558,24 @@ int tarerofs_write_chunkes(struct erofs_inode *inode, erofs_off_t data_offset)
int erofs_mkfs_dump_blobs(struct erofs_sb_info *sbi)
{
- struct erofs_buffer_head *bh;
- ssize_t length, ret;
- u64 pos_in, pos_out;
-
- if (blobfile >= 0) {
- length = lseek(blobfile, 0, SEEK_CUR);
- if (length < 0)
- return -errno;
-
- if (sbi->extra_devices)
- sbi->devs[0].blocks = erofs_blknr(sbi, length);
- else
- datablob_size = length;
- }
-
- if (sbi->extra_devices)
- return 0;
-
- bh = erofs_balloc(sbi->bmgr, DATA, datablob_size, 0);
- if (IS_ERR(bh))
- return PTR_ERR(bh);
-
- erofs_mapbh(NULL, bh->block);
-
- pos_out = erofs_btell(bh, false);
- remapped_base = erofs_blknr(sbi, pos_out);
- pos_out += sbi->bdev.offset;
- if (blobfile >= 0) {
- pos_in = 0;
- do {
- length = min_t(erofs_off_t, datablob_size, SSIZE_MAX);
- ret = erofs_copy_file_range(blobfile, &pos_in,
- sbi->bdev.fd, &pos_out, length);
- } while (ret > 0 && (datablob_size -= ret));
-
- if (ret >= 0) {
- if (datablob_size) {
- erofs_err("failed to append the remaining %llu-byte chunk data",
- datablob_size);
- ret = -EIO;
- } else {
- ret = 0;
- }
- }
- } else {
- ret = erofs_io_ftruncate(&sbi->bdev, pos_out + datablob_size);
- }
- bh->op = &erofs_drop_directly_bhops;
- erofs_bdrop(bh, false);
- return ret;
-}
-
-void erofs_blob_exit(void)
-{
- struct hashmap_iter iter;
- struct hashmap_entry *e;
- struct erofs_blobchunk *bc, *n;
-
- if (blobfile >= 0)
- close(blobfile);
-
- /* Disable hashmap shrink, effectively disabling rehash.
- * This way we can iterate over entire hashmap efficiently
- * and safely by using hashmap_iter_next() */
- hashmap_disable_shrink(&blob_hashmap);
- e = hashmap_iter_first(&blob_hashmap, &iter);
- while (e) {
- bc = container_of((struct hashmap_entry *)e,
- struct erofs_blobchunk, ent);
- DBG_BUGON(hashmap_remove(&blob_hashmap, e) != e);
- free(bc);
- e = hashmap_iter_next(&iter);
- }
- DBG_BUGON(hashmap_free(&blob_hashmap));
+ struct erofs_device_info *di;
- list_for_each_entry_safe(bc, n, &unhashed_blobchunks, list) {
- list_del(&bc->list);
- free(bc);
+ for (di = sbi->devs; di < sbi->devs + sbi->extra_devices; ++di) {
+ if (!di->bmgr)
+ continue;
+ di->blocks = erofs_mapbh(di->bmgr, NULL);
}
+ return 0;
}
-static int erofs_insert_zerochunk(erofs_off_t chunksize)
+static int erofs_insert_zerochunk(struct erofs_chunkmgr *cmgr,
+ unsigned int cbitsdef)
{
- u8 *zeros;
- struct erofs_blobchunk *chunk;
- u8 sha256[32];
+ erofs_off_t chunksize = 1ULL << cbitsdef;
+ struct erofs_chunkitem *chunk;
+ struct list_head *head;
unsigned int hash;
+ u8 sha256[32], *zeros;
int ret = 0;
zeros = calloc(1, chunksize);
@@ -644,7 +585,7 @@ static int erofs_insert_zerochunk(erofs_off_t chunksize)
erofs_sha256(zeros, chunksize, sha256);
free(zeros);
hash = memhash(sha256, sizeof(sha256));
- chunk = malloc(sizeof(struct erofs_blobchunk));
+ chunk = malloc(sizeof(*chunk));
if (!chunk)
return -ENOMEM;
@@ -653,21 +594,96 @@ static int erofs_insert_zerochunk(erofs_off_t chunksize)
chunk->blkaddr = erofs_holechunk.blkaddr;
memcpy(chunk->sha256, sha256, sizeof(sha256));
- hashmap_entry_init(&chunk->ent, hash);
- hashmap_add(&blob_hashmap, chunk);
+ head = &cmgr->chunks[hash & (EROFS_CHUNK_NR_BUCKETS - 1)];
+ list_add(&chunk->list, head);
return ret;
}
-int erofs_blob_init(const char *blobfile_path, erofs_off_t chunksize)
+int erofs_blob_init_device(struct erofs_sb_info *sbi, int device_id)
{
- if (!blobfile_path)
- blobfile = erofs_tmpfile();
- else
- blobfile = open(blobfile_path, O_WRONLY | O_CREAT |
- O_TRUNC | O_BINARY, 0666);
- if (blobfile < 0)
- return -errno;
+ struct erofs_bufmgr *bmgr;
+ struct erofs_vfile *vf;
+ int fd, ret;
+
+ if (!device_id || sbi->devs[device_id - 1].bmgr)
+ return 0;
+
+ /* TODO: move it into (struct erofs_device_info) */
+ vf = malloc(sizeof(struct erofs_vfile));
+ if (!vf)
+ return -ENOMEM;
- hashmap_init(&blob_hashmap, erofs_blob_hashmap_cmp, 0);
- return erofs_insert_zerochunk(chunksize);
+ fd = open(sbi->devs[device_id - 1].src_path,
+ O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0666);
+ if (fd < 0) {
+ ret = -errno;
+ goto err_vf;
+ }
+ *vf = (struct erofs_vfile){ .fd = fd };
+ bmgr = erofs_buffer_init(sbi, 0, vf);
+ if (!bmgr) {
+ ret = -ENOMEM;
+ goto err_fd;
+ }
+ sbi->devs[device_id - 1].bmgr = bmgr;
+ return 0;
+
+err_fd:
+ close(fd);
+err_vf:
+ free(vf);
+ return ret;
+}
+
+int erofs_blob_init(struct erofs_sb_info *sbi, int blobdev_id,
+ unsigned int chunkbits_zero)
+{
+ struct erofs_chunkmgr *cmgr;
+ int i, ret;
+
+ if (!sbi->chunkmgr) {
+ cmgr = malloc(sizeof(*cmgr));
+ if (!cmgr)
+ return -ENOMEM;
+
+ for (i = 0; i < EROFS_CHUNK_NR_BUCKETS; ++i)
+ init_list_head(&cmgr->chunks[i]);
+ init_list_head(&cmgr->unhashed_chunks);
+
+ if (chunkbits_zero) {
+ ret = erofs_insert_zerochunk(cmgr, chunkbits_zero);
+ if (ret)
+ goto err_out;
+ }
+ cmgr->device_id = blobdev_id;
+ sbi->chunkmgr = cmgr;
+ }
+ return 0;
+err_out:
+ free(cmgr);
+ return ret;
+}
+
+int erofs_blob_exit(struct erofs_sb_info *sbi)
+{
+ struct erofs_chunkmgr *cmgr = sbi->chunkmgr;
+ struct erofs_chunkitem *bc, *n;
+ int i;
+
+ if (!cmgr)
+ return 0;
+ for (i = 0; i < EROFS_CHUNK_NR_BUCKETS; ++i) {
+ list_for_each_entry_safe(bc, n, &cmgr->chunks[i], list) {
+ list_del(&bc->list);
+ free(bc);
+ }
+ }
+
+ list_for_each_entry_safe(bc, n, &cmgr->unhashed_chunks, list) {
+ list_del(&bc->list);
+ free(bc);
+ }
+ free(cmgr);
+ sbi->chunkmgr = NULL;
+ return 0;
}
diff --git a/lib/rebuild.c b/lib/rebuild.c
index 6b03a52..55681f9 100644
--- a/lib/rebuild.c
+++ b/lib/rebuild.c
@@ -193,7 +193,7 @@ static int erofs_rebuild_write_blob_index(struct erofs_sb_info *dst_sb,
inode->chunkindexes = idx;
for (i = 0; i < count; i++) {
- struct erofs_blobchunk *chunk;
+ struct erofs_chunkitem *chunk;
struct erofs_map_blocks map = {
.buf = __EROFS_BUF_INITIALIZER,
};
@@ -204,7 +204,7 @@ static int erofs_rebuild_write_blob_index(struct erofs_sb_info *dst_sb,
goto err;
blkaddr = erofs_blknr(dst_sb, map.m_pa);
- chunk = erofs_get_unhashed_chunk(inode->dev, blkaddr, 0);
+ chunk = erofs_get_unhashed_chunk(dst_sb, inode->dev, blkaddr, 0);
if (IS_ERR(chunk)) {
ret = PTR_ERR(chunk);
goto err;
diff --git a/lib/super.c b/lib/super.c
index ead4170..25116fe 100644
--- a/lib/super.c
+++ b/lib/super.c
@@ -189,8 +189,18 @@ void erofs_put_super(struct erofs_sb_info *sbi)
int i;
DBG_BUGON(!sbi->extra_devices);
- for (i = 0; i < sbi->extra_devices; ++i)
+ for (i = 0; i < sbi->extra_devices; ++i) {
+ struct erofs_bufmgr *bmgr = sbi->devs[i].bmgr;
+ struct erofs_vfile *vf;
+
+ if (bmgr) {
+ vf = bmgr->vf;
+ erofs_buffer_exit(bmgr);
+ close(vf->fd);
+ free(vf);
+ }
free(sbi->devs[i].src_path);
+ }
free(sbi->devs);
sbi->devs = NULL;
}
diff --git a/mkfs/main.c b/mkfs/main.c
index 5bf7b8f..b6d215b 100644
--- a/mkfs/main.c
+++ b/mkfs/main.c
@@ -1915,12 +1915,6 @@ int main(int argc, char **argv)
}
cfg.c_dedupe = importer_params.dedupe;
- if (cfg.c_chunkbits) {
- err = erofs_blob_init(cfg.c_blobdev_path, 1 << cfg.c_chunkbits);
- if (err)
- goto exit;
- }
-
if (tar_index_512b || cfg.c_blobdev_path) {
err = erofs_mkfs_init_devices(&g_sbi, 1);
if (err) {
@@ -1930,6 +1924,24 @@ int main(int argc, char **argv)
}
}
+ if (tar_index_512b || cfg.c_chunkbits) {
+ if (g_sbi.extra_devices && cfg.c_blobdev_path) {
+ g_sbi.devs[0].src_path = strdup(cfg.c_blobdev_path);
+ if (!g_sbi.devs[0].src_path) {
+ err = -ENOMEM;
+ goto exit;
+ }
+
+ err = erofs_blob_init_device(&g_sbi, 1);
+ if (err)
+ goto exit;
+
+ }
+ err = erofs_blob_init(&g_sbi, cfg.c_blobdev_path ? 1 : 0, cfg.c_chunkbits);
+ if (err)
+ goto exit;
+ }
+
if (source_mode == EROFS_MKFS_SOURCE_LOCALDIR) {
err = erofs_load_shared_xattrs_from_path(&g_sbi, cfg.c_src_path,
mkfscfg.inlinexattr_tolerance);
@@ -2072,8 +2084,7 @@ exit:
fclose(blklst);
erofs_cleanup_compress_hints();
erofs_cleanup_exclude_rules();
- if (cfg.c_chunkbits || source_mode == EROFS_MKFS_SOURCE_REBUILD)
- erofs_blob_exit();
+ erofs_blob_exit(&g_sbi);
erofs_xattr_cleanup_name_prefixes();
erofs_rebuild_cleanup();
erofs_diskbuf_exit();
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] erofs-utils: get rid of hashmap
2026-08-26 13:43 [PATCH 1/4] erofs-utils: lib: fix wrong forward declaration of `erofs_metamgr` Gao Xiang
2026-08-26 13:43 ` [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device Gao Xiang
2026-08-26 13:43 ` [PATCH 3/4] erofs-utils: lib: refactor unencoded chunk handling Gao Xiang
@ 2026-08-26 13:43 ` Gao Xiang
2 siblings, 0 replies; 6+ messages in thread
From: Gao Xiang @ 2026-08-26 13:43 UTC (permalink / raw)
To: linux-erofs; +Cc: Gao Xiang
This is the last piece of GPL-only 3rd-party code in
liberofs.
We may introduce a new dynamic hashmap implementation without GPL-only
restriction later.
Signed-off-by: Gao Xiang <xiang@kernel.org>
---
include/erofs/flex-array.h | 156 ---------------------
include/erofs/hashmap.h | 115 ---------------
lib/Makefile.am | 4 +-
lib/hashmap.c | 280 -------------------------------------
4 files changed, 1 insertion(+), 554 deletions(-)
delete mode 100644 include/erofs/flex-array.h
delete mode 100644 include/erofs/hashmap.h
delete mode 100644 lib/hashmap.c
diff --git a/include/erofs/flex-array.h b/include/erofs/flex-array.h
deleted file mode 100644
index 9b1642f..0000000
--- a/include/erofs/flex-array.h
+++ /dev/null
@@ -1,156 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __EROFS_FLEX_ARRAY_H
-#define __EROFS_FLEX_ARRAY_H
-
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <limits.h>
-#include <stdint.h>
-
-#include "defs.h"
-#include "print.h"
-
-/*
- * flex-array.h
- *
- * Some notes to make sense of the code.
- *
- * Flex-arrays:
- * - Flex-arrays became standard in C99 and are defined by "array[]" (at the
- * end of a struct)
- * - Pre-C99 flex-arrays can be accomplished by "array[1]"
- * - There is a GNU extension where they are defined using "array[0]"
- * Allegedly there is/was a bug in gcc whereby foo[1] generated incorrect
- * code, so it's safest to use [0] (https://lkml.org/lkml/2015/2/18/407).
- *
- * For C89 and C90, __STDC__ is 1
- * For later standards, __STDC_VERSION__ is defined according to the standard.
- * For example: 199901L or 201112L
- *
- * Whilst we're on the subject, in version 5 of gcc, the default std was
- * changed from gnu89 to gnu11. In jgmenu, CFLAGS therefore contains -std=gnu89
- * You can check your default gcc std by doing:
- * gcc -dM -E - </dev/null | grep '__STDC_VERSION__\|__STDC__'
- *
- * The code below is copied from git's git-compat-util.h in support of
- * hashmap.c
- */
-
-#ifndef FLEX_ARRAY
-#if defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) && \
- (!defined(__SUNPRO_C) || (__SUNPRO_C > 0x580))
-# define FLEX_ARRAY /* empty */
-#elif defined(__GNUC__)
-# if (__GNUC__ >= 3)
-# define FLEX_ARRAY /* empty */
-# else
-# define FLEX_ARRAY 0 /* older GNU extension */
-# endif
-#endif
-
-/* Otherwise, default to safer but a bit wasteful traditional style */
-#ifndef FLEX_ARRAY
-# define FLEX_ARRAY 1
-#endif
-#endif
-
-#define bitsizeof(x) (CHAR_BIT * sizeof(x))
-
-#define maximum_signed_value_of_type(a) \
- (INTMAX_MAX >> (bitsizeof(intmax_t) - bitsizeof(a)))
-
-#define maximum_unsigned_value_of_type(a) \
- (UINTMAX_MAX >> (bitsizeof(uintmax_t) - bitsizeof(a)))
-
-/*
- * Signed integer overflow is undefined in C, so here's a helper macro
- * to detect if the sum of two integers will overflow.
- * Requires: a >= 0, typeof(a) equals typeof(b)
- */
-#define signed_add_overflows(a, b) \
- ((b) > maximum_signed_value_of_type(a) - (a))
-
-#define unsigned_add_overflows(a, b) \
- ((b) > maximum_unsigned_value_of_type(a) - (a))
-
-static inline size_t st_add(size_t a, size_t b)
-{
- if (unsigned_add_overflows(a, b)) {
- erofs_err("size_t overflow: %llu + %llu", a | 0ULL, b | 0ULL);
- BUG_ON(1);
- return -1;
- }
- return a + b;
-}
-
-#define st_add3(a, b, c) st_add(st_add((a), (b)), (c))
-#define st_add4(a, b, c, d) st_add(st_add3((a), (b), (c)), (d))
-
-/*
- * These functions help you allocate structs with flex arrays, and copy
- * the data directly into the array. For example, if you had:
- *
- * struct foo {
- * int bar;
- * char name[FLEX_ARRAY];
- * };
- *
- * you can do:
- *
- * struct foo *f;
- * FLEX_ALLOC_MEM(f, name, src, len);
- *
- * to allocate a "foo" with the contents of "src" in the "name" field.
- * The resulting struct is automatically zero'd, and the flex-array field
- * is NUL-terminated (whether the incoming src buffer was or not).
- *
- * The FLEXPTR_* variants operate on structs that don't use flex-arrays,
- * but do want to store a pointer to some extra data in the same allocated
- * block. For example, if you have:
- *
- * struct foo {
- * char *name;
- * int bar;
- * };
- *
- * you can do:
- *
- * struct foo *f;
- * FLEXPTR_ALLOC_STR(f, name, src);
- *
- * and "name" will point to a block of memory after the struct, which will be
- * freed along with the struct (but the pointer can be repointed anywhere).
- *
- * The *_STR variants accept a string parameter rather than a ptr/len
- * combination.
- *
- * Note that these macros will evaluate the first parameter multiple
- * times, and it must be assignable as an lvalue.
- */
-#define FLEX_ALLOC_MEM(x, flexname, buf, len) do { \
- size_t flex_array_len_ = (len); \
- (x) = calloc(1, st_add3(sizeof(*(x)), flex_array_len_, 1)); \
- BUG_ON(!(x)); \
- memcpy((void *)(x)->flexname, (buf), flex_array_len_); \
-} while (0)
-#define FLEXPTR_ALLOC_MEM(x, ptrname, buf, len) do { \
- size_t flex_array_len_ = (len); \
- (x) = xcalloc(1, st_add3(sizeof(*(x)), flex_array_len_, 1)); \
- memcpy((x) + 1, (buf), flex_array_len_); \
- (x)->ptrname = (void *)((x) + 1); \
-} while (0)
-#define FLEX_ALLOC_STR(x, flexname, str) \
- FLEX_ALLOC_MEM((x), flexname, (str), strlen(str))
-#define FLEXPTR_ALLOC_STR(x, ptrname, str) \
- FLEXPTR_ALLOC_MEM((x), ptrname, (str), strlen(str))
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif
diff --git a/include/erofs/hashmap.h b/include/erofs/hashmap.h
deleted file mode 100644
index 484948e..0000000
--- a/include/erofs/hashmap.h
+++ /dev/null
@@ -1,115 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __EROFS_HASHMAP_H
-#define __EROFS_HASHMAP_H
-
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-
-/* Copied from https://github.com/git/git.git */
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-
-#include "flex-array.h"
-
-/*
- * Generic implementation of hash-based key-value mappings.
- * See Documentation/technical/api-hashmap.txt.
- */
-
-/* FNV-1 functions */
-unsigned int strhash(const char *str);
-unsigned int strihash(const char *str);
-unsigned int memhash(const void *buf, size_t len);
-unsigned int memihash(const void *buf, size_t len);
-
-static inline unsigned int sha1hash(const unsigned char *sha1)
-{
- /*
- * Equivalent to 'return *(unsigned int *)sha1;', but safe on
- * platforms that don't support unaligned reads.
- */
- unsigned int hash;
-
- memcpy(&hash, sha1, sizeof(hash));
- return hash;
-}
-
-/* data structures */
-struct hashmap_entry {
- struct hashmap_entry *next;
- unsigned int hash;
-};
-
-typedef int (*hashmap_cmp_fn)(const void *entry, const void *entry_or_key,
- const void *keydata);
-
-struct hashmap {
- struct hashmap_entry **table;
- hashmap_cmp_fn cmpfn;
- unsigned int size, tablesize, grow_at, shrink_at;
-};
-
-struct hashmap_iter {
- struct hashmap *map;
- struct hashmap_entry *next;
- unsigned int tablepos;
-};
-
-/* hashmap functions */
-void hashmap_init(struct hashmap *map, hashmap_cmp_fn equals_function,
- size_t initial_size);
-int hashmap_free(struct hashmap *map);
-
-/* hashmap_entry functions */
-static inline void hashmap_entry_init(void *entry, unsigned int hash)
-{
- struct hashmap_entry *e = entry;
-
- e->hash = hash;
- e->next = NULL;
-}
-
-void *hashmap_get(const struct hashmap *map, const void *key, const void *keydata);
-void *hashmap_get_next(const struct hashmap *map, const void *entry);
-void hashmap_add(struct hashmap *map, void *entry);
-void *hashmap_remove(struct hashmap *map, const void *key);
-
-static inline void *hashmap_get_from_hash(const struct hashmap *map,
- unsigned int hash,
- const void *keydata)
-{
- struct hashmap_entry key;
-
- hashmap_entry_init(&key, hash);
- return hashmap_get(map, &key, keydata);
-}
-
-/* hashmap_iter functions */
-void hashmap_iter_init(struct hashmap *map, struct hashmap_iter *iter);
-void *hashmap_iter_next(struct hashmap_iter *iter);
-static inline void *hashmap_iter_first(struct hashmap *map,
- struct hashmap_iter *iter)
-{
- hashmap_iter_init(map, iter);
- return hashmap_iter_next(iter);
-}
-
-static inline void hashmap_disable_shrink(struct hashmap * map)
-{
- map->shrink_at = 0;
-}
-/* string interning */
-const void *memintern(const void *data, size_t len);
-static inline const char *strintern(const char *string)
-{
- return memintern(string, strlen(string));
-}
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 5ef2122..25d08f2 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -10,8 +10,6 @@ noinst_HEADERS = $(top_srcdir)/include/erofs_fs.h \
$(top_srcdir)/include/erofs/diskbuf.h \
$(top_srcdir)/include/erofs/err.h \
$(top_srcdir)/include/erofs/exclude.h \
- $(top_srcdir)/include/erofs/flex-array.h \
- $(top_srcdir)/include/erofs/hashmap.h \
$(top_srcdir)/include/erofs/inode.h \
$(top_srcdir)/include/erofs/internal.h \
$(top_srcdir)/include/erofs/io.h \
@@ -43,7 +41,7 @@ endif
liberofs_la_SOURCES = config.c io.c cache.c super.c inode.c xattr.c exclude.c \
namei.c data.c compress.c compressor.c zmap.c decompress.c \
- compress_hints.c hashmap.c sha256.c blobchunk.c dir.c \
+ compress_hints.c sha256.c blobchunk.c dir.c \
fragments.c dedupe.c uuid_unparse.c uuid.c tar.c \
block_list.c rebuild.c diskbuf.c bitops.c dedupe_ext.c \
vmdk.c metabox.c global.c importer.c base64.c
diff --git a/lib/hashmap.c b/lib/hashmap.c
deleted file mode 100644
index 45916ae..0000000
--- a/lib/hashmap.c
+++ /dev/null
@@ -1,280 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Copied from https://github.com/git/git.git
- * Generic implementation of hash-based key value mappings.
- */
-#include "erofs/hashmap.h"
-
-#define FNV32_BASE ((unsigned int)0x811c9dc5)
-#define FNV32_PRIME ((unsigned int)0x01000193)
-
-unsigned int strhash(const char *str)
-{
- unsigned int c, hash = FNV32_BASE;
-
- while ((c = (unsigned char)*str++))
- hash = (hash * FNV32_PRIME) ^ c;
- return hash;
-}
-
-unsigned int strihash(const char *str)
-{
- unsigned int c, hash = FNV32_BASE;
-
- while ((c = (unsigned char)*str++)) {
- if (c >= 'a' && c <= 'z')
- c -= 'a' - 'A';
- hash = (hash * FNV32_PRIME) ^ c;
- }
- return hash;
-}
-
-unsigned int memhash(const void *buf, size_t len)
-{
- unsigned int hash = FNV32_BASE;
- unsigned char *ucbuf = (unsigned char *)buf;
-
- while (len--) {
- unsigned int c = *ucbuf++;
-
- hash = (hash * FNV32_PRIME) ^ c;
- }
- return hash;
-}
-
-unsigned int memihash(const void *buf, size_t len)
-{
- unsigned int hash = FNV32_BASE;
- unsigned char *ucbuf = (unsigned char *)buf;
-
- while (len--) {
- unsigned int c = *ucbuf++;
-
- if (c >= 'a' && c <= 'z')
- c -= 'a' - 'A';
- hash = (hash * FNV32_PRIME) ^ c;
- }
- return hash;
-}
-
-#define HASHMAP_INITIAL_SIZE 64
-/* grow / shrink by 2^2 */
-#define HASHMAP_RESIZE_BITS 2
-/* load factor in percent */
-#define HASHMAP_LOAD_FACTOR 80
-
-static void alloc_table(struct hashmap *map, unsigned int size)
-{
- map->tablesize = size;
- map->table = calloc(size, sizeof(struct hashmap_entry *));
- BUG_ON(!map->table);
-
- /* calculate resize thresholds for new size */
- map->grow_at = (unsigned int)((uint64_t)size * HASHMAP_LOAD_FACTOR / 100);
- if (size <= HASHMAP_INITIAL_SIZE)
- map->shrink_at = 0;
- else
- /*
- * The shrink-threshold must be slightly smaller than
- * (grow-threshold / resize-factor) to prevent erratic resizing,
- * thus we divide by (resize-factor + 1).
- */
- map->shrink_at = map->grow_at / ((1 << HASHMAP_RESIZE_BITS) + 1);
-}
-
-static inline int entry_equals(const struct hashmap *map,
- const struct hashmap_entry *e1,
- const struct hashmap_entry *e2,
- const void *keydata)
-{
- return (e1 == e2) || (e1->hash == e2->hash && !map->cmpfn(e1, e2, keydata));
-}
-
-static inline unsigned int bucket(const struct hashmap *map,
- const struct hashmap_entry *key)
-{
- return key->hash & (map->tablesize - 1);
-}
-
-static void rehash(struct hashmap *map, unsigned int newsize)
-{
- unsigned int i, oldsize = map->tablesize;
- struct hashmap_entry **oldtable = map->table;
-
- alloc_table(map, newsize);
- for (i = 0; i < oldsize; i++) {
- struct hashmap_entry *e = oldtable[i];
-
- while (e) {
- struct hashmap_entry *next = e->next;
- unsigned int b = bucket(map, e);
-
- e->next = map->table[b];
- map->table[b] = e;
- e = next;
- }
- }
- free(oldtable);
-}
-
-static inline struct hashmap_entry **find_entry_ptr(const struct hashmap *map,
- const struct hashmap_entry *key,
- const void *keydata)
-{
- struct hashmap_entry **e = &map->table[bucket(map, key)];
-
- while (*e && !entry_equals(map, *e, key, keydata))
- e = &(*e)->next;
- return e;
-}
-
-static int always_equal(const void *unused1, const void *unused2, const void *unused3)
-{
- return 0;
-}
-
-void hashmap_init(struct hashmap *map, hashmap_cmp_fn equals_function,
- size_t initial_size)
-{
- unsigned int size = HASHMAP_INITIAL_SIZE;
-
- map->size = 0;
- map->cmpfn = equals_function ? equals_function : always_equal;
-
- /* calculate initial table size and allocate the table */
- initial_size = (unsigned int)((uint64_t)initial_size * 100
- / HASHMAP_LOAD_FACTOR);
- while (initial_size > size)
- size <<= HASHMAP_RESIZE_BITS;
- alloc_table(map, size);
-}
-
-int hashmap_free(struct hashmap *map)
-{
- if (map && map->table) {
- struct hashmap_iter iter;
- struct hashmap_entry *e;
-
- hashmap_iter_init(map, &iter);
- e = hashmap_iter_next(&iter);
- if (e)
- return -EBUSY;
-
- free(map->table);
- memset(map, 0, sizeof(*map));
- }
- return 0;
-}
-
-void *hashmap_get(const struct hashmap *map, const void *key, const void *keydata)
-{
- return *find_entry_ptr(map, key, keydata);
-}
-
-void *hashmap_get_next(const struct hashmap *map, const void *entry)
-{
- struct hashmap_entry *e = ((struct hashmap_entry *)entry)->next;
-
- for (; e; e = e->next)
- if (entry_equals(map, entry, e, NULL))
- return e;
- return NULL;
-}
-
-void hashmap_add(struct hashmap *map, void *entry)
-{
- unsigned int b = bucket(map, entry);
-
- /* add entry */
- ((struct hashmap_entry *)entry)->next = map->table[b];
- map->table[b] = entry;
-
- /* fix size and rehash if appropriate */
- map->size++;
- if (map->size > map->grow_at)
- rehash(map, map->tablesize << HASHMAP_RESIZE_BITS);
-}
-
-void *hashmap_remove(struct hashmap *map, const void *entry)
-{
- struct hashmap_entry *old;
- struct hashmap_entry **e = &map->table[bucket(map, entry)];
-
- while (*e && *e != entry)
- e = &(*e)->next;
-
- if (!*e)
- return NULL;
-
- /* remove existing entry */
- old = *e;
- *e = old->next;
- old->next = NULL;
-
- /* fix size and rehash if appropriate */
- map->size--;
- if (map->size < map->shrink_at)
- rehash(map, map->tablesize >> HASHMAP_RESIZE_BITS);
- return old;
-}
-
-void hashmap_iter_init(struct hashmap *map, struct hashmap_iter *iter)
-{
- iter->map = map;
- iter->tablepos = 0;
- iter->next = NULL;
-}
-
-void *hashmap_iter_next(struct hashmap_iter *iter)
-{
- struct hashmap_entry *current = iter->next;
-
- for (;;) {
- if (current) {
- iter->next = current->next;
- return current;
- }
-
- if (iter->tablepos >= iter->map->tablesize)
- return NULL;
-
- current = iter->map->table[iter->tablepos++];
- }
-}
-
-struct pool_entry {
- struct hashmap_entry ent;
- size_t len;
- unsigned char data[FLEX_ARRAY];
-};
-
-static int pool_entry_cmp(const struct pool_entry *e1,
- const struct pool_entry *e2,
- const unsigned char *keydata)
-{
- return e1->data != keydata &&
- (e1->len != e2->len || memcmp(e1->data, keydata, e1->len));
-}
-
-const void *memintern(const void *data, size_t len)
-{
- static struct hashmap map;
- struct pool_entry key, *e;
-
- /* initialize string pool hashmap */
- if (!map.tablesize)
- hashmap_init(&map, (hashmap_cmp_fn)pool_entry_cmp, 0);
-
- /* lookup interned string in pool */
- hashmap_entry_init(&key, memhash(data, len));
- key.len = len;
- e = hashmap_get(&map, &key, data);
- if (!e) {
- /* not found: create it */
- FLEX_ALLOC_MEM(e, data, data, len);
- hashmap_entry_init(e, key.ent.hash);
- e->len = len;
- hashmap_add(&map, e);
- }
- return e->data;
-}
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device
2026-08-26 13:43 ` [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device Gao Xiang
@ 2026-08-27 1:30 ` Yifan Zhao
2026-08-27 7:59 ` Gao Xiang
0 siblings, 1 reply; 6+ messages in thread
From: Yifan Zhao @ 2026-08-27 1:30 UTC (permalink / raw)
To: Gao Xiang, linux-erofs
On 26/8/26 21:43, Gao Xiang wrote:
> Source kernel commit: 7b00af2c5414dc01e0718deef7ead81102867636
>
> Signed-off-by: Gao Xiang <xiang@kernel.org>
> ---
> include/erofs/internal.h | 4 +---
> lib/importer.c | 3 +--
> lib/io.c | 8 ++++----
> lib/rebuild.c | 6 +++---
> lib/super.c | 18 +++++++++---------
> lib/vmdk.c | 4 ++--
> mkfs/main.c | 12 ++++++------
> 7 files changed, 26 insertions(+), 29 deletions(-)
>
> diff --git a/include/erofs/internal.h b/include/erofs/internal.h
> index 514cfbd..30dae41 100644
> --- a/include/erofs/internal.h
> +++ b/include/erofs/internal.h
> @@ -93,11 +93,9 @@ struct erofs_metamgr;
>
> struct erofs_sb_info {
> struct erofs_sb_lz4_info lz4;
> - struct erofs_device_info *devs;
> - char *devname;
> + struct erofs_device_info *devs, dif0;
>
> u64 total_blocks;
> - u64 primarydevice_blocks;
>
> s32 meta_blkaddr;
> u32 xattr_blkaddr;
> diff --git a/lib/importer.c b/lib/importer.c
> index c404b0f..2a635d2 100644
> --- a/lib/importer.c
> +++ b/lib/importer.c
> @@ -126,8 +126,7 @@ int erofs_importer_flush_all(struct erofs_importer *im)
>
> fsalignblks = im->params->fsalignblks ?
> roundup_pow_of_two(im->params->fsalignblks) : 1;
> - sbi->primarydevice_blocks = roundup(erofs_mapbh(sbi->bmgr, NULL),
> - fsalignblks);
> + sbi->dif0.blocks = roundup(erofs_mapbh(sbi->bmgr, NULL), fsalignblks);
> err = erofs_write_device_table(sbi);
> if (err)
> return err;
> diff --git a/lib/io.c b/lib/io.c
> index 3ba45cc..5c5449f 100644
> --- a/lib/io.c
> +++ b/lib/io.c
> @@ -368,8 +368,8 @@ repeat:
> }
>
> out:
> - sbi->devname = strdup(dev);
> - if (!sbi->devname) {
> + sbi->dif0.src_path = strdup(dev);
> + if (!sbi->dif0.src_path) {
> close(fd);
> return -ENOMEM;
> }
> @@ -381,8 +381,8 @@ out:
> void erofs_dev_close(struct erofs_sb_info *sbi)
> {
> erofs_io_close(&sbi->bdev);
> - free(sbi->devname);
> - sbi->devname = NULL;
> + free(sbi->dif0.src_path);
> + sbi->dif0.src_path = NULL;
> sbi->bdev.fd = -1;
> }
>
> diff --git a/lib/rebuild.c b/lib/rebuild.c
> index a5308dc..6b03a52 100644
> --- a/lib/rebuild.c
> +++ b/lib/rebuild.c
> @@ -233,7 +233,7 @@ static int erofs_rebuild_write_full_data(struct erofs_inode *inode)
> return -EFSCORRUPTED;
> return 0;
> }
> - inode->rebuild_blobpath = strdup(src_sbi->devname);
> + inode->rebuild_blobpath = strdup(src_sbi->dif0.src_path);
> if (!inode->rebuild_blobpath)
> return -ENOMEM;
> inode->rebuild_src_dataoff =
> @@ -244,7 +244,7 @@ static int erofs_rebuild_write_full_data(struct erofs_inode *inode)
> unsigned int inline_size = inode->i_size % erofs_blksiz(src_sbi);
>
> if (nblocks > 0 && inode->u.i_blkaddr != EROFS_NULL_ADDR) {
> - inode->rebuild_blobpath = strdup(src_sbi->devname);
> + inode->rebuild_blobpath = strdup(src_sbi->dif0.src_path);
> if (!inode->rebuild_blobpath)
> return -ENOMEM;
> inode->rebuild_src_dataoff =
> @@ -500,7 +500,7 @@ int erofs_rebuild_load_tree(struct erofs_inode *root, struct erofs_sb_info *sbi,
> struct erofs_inode inode = {};
> struct erofs_rebuild_dir_context ctx;
> char uuid_str[37];
> - char *fsid = sbi->devname;
> + char *fsid = sbi->dif0.src_path;
> int ret;
>
> if (!fsid) {
> diff --git a/lib/super.c b/lib/super.c
> index d138f84..ead4170 100644
> --- a/lib/super.c
> +++ b/lib/super.c
> @@ -33,7 +33,7 @@ static int erofs_init_devices(struct erofs_sb_info *sbi,
> erofs_off_t pos;
> bool _48bit = erofs_sb_has_48bit(sbi);
>
> - sbi->total_blocks = sbi->primarydevice_blocks;
> + sbi->total_blocks = sbi->dif0.blocks;
>
> if (!erofs_sb_has_device_table(sbi))
> ondisk_extradevs = 0;
> @@ -118,14 +118,14 @@ int erofs_read_superblock(struct erofs_sb_info *sbi)
> erofs_err("invalid sb_extslots %u", dsb->sb_extslots);
> return -EINVAL;
> }
> - sbi->primarydevice_blocks = le32_to_cpu(dsb->blocks_lo);
> + sbi->dif0.blocks = le32_to_cpu(dsb->blocks_lo);
> sbi->meta_blkaddr = le32_to_cpu(dsb->meta_blkaddr);
> sbi->xattr_blkaddr = le32_to_cpu(dsb->xattr_blkaddr);
> sbi->xattr_prefix_start = le32_to_cpu(dsb->xattr_prefix_start);
> sbi->xattr_prefix_count = dsb->xattr_prefix_count;
> if (erofs_sb_has_48bit(sbi) && dsb->rootnid_8b) {
> sbi->root_nid = le64_to_cpu(dsb->rootnid_8b);
> - sbi->primarydevice_blocks = sbi->primarydevice_blocks |
> + sbi->dif0.blocks = sbi->dif0.blocks |
> ((u64)le16_to_cpu(dsb->rb.blocks_hi) << 32);
> } else {
> sbi->root_nid = le16_to_cpu(dsb->rb.rootnid_2b);
> @@ -230,10 +230,10 @@ int erofs_writesb(struct erofs_sb_info *sbi)
> char *buf;
> int ret;
>
> - sb.blocks_lo = cpu_to_le32(sbi->primarydevice_blocks);
> - if (sbi->primarydevice_blocks > UINT32_MAX ||
> + sb.blocks_lo = cpu_to_le32(sbi->dif0.blocks);
> + if (sbi->dif0.blocks > UINT32_MAX ||
> sbi->root_nid > UINT16_MAX) {
> - sb.rb.blocks_hi = cpu_to_le16(sbi->primarydevice_blocks >> 32);
> + sb.rb.blocks_hi = cpu_to_le16(sbi->dif0.blocks >> 32);
> sb.rootnid_8b = cpu_to_le64(sbi->root_nid);
> }
> memcpy(sb.uuid, sbi->uuid, sizeof(sb.uuid));
> @@ -404,7 +404,7 @@ int erofs_mkfs_init_devices(struct erofs_sb_info *sbi, unsigned int devices)
>
> int erofs_write_device_table(struct erofs_sb_info *sbi)
> {
> - erofs_blk_t nblocks = sbi->primarydevice_blocks;
> + erofs_blk_t nblocks = sbi->dif0.blocks;
> struct erofs_buffer_head *bh = sbi->bh_devt;
> erofs_off_t pos;
> unsigned int i, ret;
> @@ -484,7 +484,7 @@ int erofs_mkfs_load_fs(struct erofs_sb_info *sbi, unsigned int dsunit)
> erofs_warn("EXPERIMENTAL incremental build in use. Use at your own risk!");
> err = erofs_read_superblock(sbi);
> if (err) {
> - erofs_err("failed to read superblock of %s: %s", sbi->devname,
> + erofs_err("failed to read superblock of %s: %s", sbi->dif0.src_path,
> erofs_strerror(err));
> return err;
> }
> @@ -493,7 +493,7 @@ int erofs_mkfs_load_fs(struct erofs_sb_info *sbi, unsigned int dsunit)
> if (!err && S_ISREG(u.st.st_mode))
> u.startblk = DIV_ROUND_UP(u.st.st_size, erofs_blksiz(sbi));
> else
> - u.startblk = sbi->primarydevice_blocks;
> + u.startblk = sbi->dif0.blocks;
>
> bmgr = erofs_buffer_init(sbi, u.startblk, NULL);
> if (!bmgr)
> diff --git a/lib/vmdk.c b/lib/vmdk.c
> index 316a8ff..28381c8 100644
> --- a/lib/vmdk.c
> +++ b/lib/vmdk.c
> @@ -51,8 +51,8 @@ int erofs_dump_vmdk_desc(FILE *f, struct erofs_sb_info *sbi)
> int ret, i;
>
> fprintf(f, desc_template_1, cid, parent_cid, subformat);
> - sectors = sbi->primarydevice_blocks << (sbi->blkszbits - 9);
> - ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->devname, 0);
> + sectors = sbi->dif0.blocks << (sbi->blkszbits - 9);
> + ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->dif0.blocks, 0);
mistake? should use `src_path` instead of `blocks`
Thanks,
Yifan Zhao
> if (ret)
> return ret;
> total_sectors = sectors;
> diff --git a/mkfs/main.c b/mkfs/main.c
> index 929ce7c..5bf7b8f 100644
> --- a/mkfs/main.c
> +++ b/mkfs/main.c
> @@ -1685,12 +1685,12 @@ static int erofs_mkfs_rebuild_load_trees(struct erofs_inode *root)
> ret = erofs_rebuild_load_tree(root, src, datamode);
> src->xamgr = NULL;
> if (ret) {
> - erofs_err("failed to load %s", src->devname);
> + erofs_err("failed to load %s", src->dif0.src_path);
> return ret;
> }
> if (src->extra_devices > 1) {
> erofs_err("%s: unsupported number %u of extra devices",
> - src->devname, src->extra_devices);
> + src->dif0.src_path, src->extra_devices);
> return -EOPNOTSUPP;
> }
> extra_devices += src->extra_devices;
> @@ -1723,8 +1723,8 @@ static int erofs_mkfs_rebuild_load_trees(struct erofs_inode *root)
> nblocks = src->devs[0].blocks;
> tag = src->devs[0].tag;
> } else {
> - nblocks = src->primarydevice_blocks;
> - devs[idx].src_path = strdup(src->devname);
> + nblocks = src->dif0.blocks;
> + devs[idx].src_path = strdup(src->dif0.src_path);
> }
> devs[idx].blocks = nblocks;
> if (tag && *tag)
> @@ -1849,7 +1849,7 @@ int main(int argc, char **argv)
> goto exit;
> err = erofs_read_superblock(src);
> if (err) {
> - erofs_err("failed to read superblock of %s", src->devname);
> + erofs_err("failed to read superblock of %s", src->dif0.src_path);
> goto exit;
> }
> mkfs_blkszbits = src->blkszbits;
> @@ -2051,7 +2051,7 @@ int main(int argc, char **argv)
> if (err)
> goto exit;
>
> - err = erofs_dev_resize(&g_sbi, g_sbi.primarydevice_blocks);
> + err = erofs_dev_resize(&g_sbi, g_sbi.dif0.blocks);
>
> if (!err && erofs_sb_has_sb_chksum(&g_sbi)) {
> err = erofs_enable_sb_chksum(&g_sbi, &crc);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device
2026-08-27 1:30 ` Yifan Zhao
@ 2026-08-27 7:59 ` Gao Xiang
0 siblings, 0 replies; 6+ messages in thread
From: Gao Xiang @ 2026-08-27 7:59 UTC (permalink / raw)
To: Yifan Zhao; +Cc: Gao Xiang, linux-erofs
Hi Yifan,
On Thu, Aug 27, 2026 at 09:30:38AM +0800, Yifan Zhao wrote:
>
> On 26/8/26 21:43, Gao Xiang wrote:
> > Source kernel commit: 7b00af2c5414dc01e0718deef7ead81102867636
> >
> > Signed-off-by: Gao Xiang <xiang@kernel.org>
> > ---
...
> > diff --git a/lib/vmdk.c b/lib/vmdk.c
> > index 316a8ff..28381c8 100644
> > --- a/lib/vmdk.c
> > +++ b/lib/vmdk.c
> > @@ -51,8 +51,8 @@ int erofs_dump_vmdk_desc(FILE *f, struct erofs_sb_info *sbi)
> > int ret, i;
> > fprintf(f, desc_template_1, cid, parent_cid, subformat);
> > - sectors = sbi->primarydevice_blocks << (sbi->blkszbits - 9);
> > - ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->devname, 0);
> > + sectors = sbi->dif0.blocks << (sbi->blkszbits - 9);
> > + ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->dif0.blocks, 0);
>
> mistake? should use `src_path` instead of `blocks`
It's already got fixed.
Thanks,
Gao Xiang
>
>
> Thanks,
>
> Yifan Zhao
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-08-27 7:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-26 13:43 [PATCH 1/4] erofs-utils: lib: fix wrong forward declaration of `erofs_metamgr` Gao Xiang
2026-08-26 13:43 ` [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device Gao Xiang
2026-08-27 1:30 ` Yifan Zhao
2026-08-27 7:59 ` Gao Xiang
2026-08-26 13:43 ` [PATCH 3/4] erofs-utils: lib: refactor unencoded chunk handling Gao Xiang
2026-08-26 13:43 ` [PATCH 4/4] erofs-utils: get rid of hashmap Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).