From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Jingbo Xu <jefflexu@linux.alibaba.com>,
chao@kernel.org, huyue2@coolpad.com,
linux-erofs@lists.ozlabs.org
Cc: alexl@redhat.com
Subject: Re: [PATCH v6 2/2] erofs: boost negative xattr lookup with bloom filter
Date: Sun, 23 Jul 2023 21:28:14 +0800 [thread overview]
Message-ID: <6aa8bf9c-4feb-7dbe-4ddf-a42d9b19d3cb@linux.alibaba.com> (raw)
In-Reply-To: <20230722094538.11754-3-jefflexu@linux.alibaba.com>
On 2023/7/22 17:45, Jingbo Xu wrote:
> Optimise the negative xattr lookup with bloom filter.
>
> The bit value for the bloom filter map has a reverse semantics for
> compatibility. That is, the bit value of 0 indicates existence, while
> the bit value of 1 indicates the absence of corresponding xattr.
>
> The initial version is _only_ enabled when xattr_filter_reserved is
> zero. The filter map internals may change in the future, in which case
> the reserved flag will be set non-zero and we don't need bothering the
> compatible bits again at that time. For now disable the optimization if
> this reserved flag is non-zero.
>
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
next prev parent reply other threads:[~2023-07-23 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 9:45 [PATCH v6 0/2] erofs: introduce xattr name bloom filter Jingbo Xu
2023-07-22 9:45 ` [PATCH v6 1/2] erofs: update on-disk format for xattr name filter Jingbo Xu
2023-07-30 13:18 ` Chao Yu
2023-07-22 9:45 ` [PATCH v6 2/2] erofs: boost negative xattr lookup with bloom filter Jingbo Xu
2023-07-23 13:28 ` Gao Xiang [this message]
2023-07-30 13:19 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa8bf9c-4feb-7dbe-4ddf-a42d9b19d3cb@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=alexl@redhat.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox