* [PATCH] ext4: fix potential null pointer dereference in ext4_free_inode
@ 2014-07-08 5:41 Namjae Jeon
2014-07-08 11:00 ` Lukáš Czerner
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2014-07-08 5:41 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-ext4, 'Dan Carpenter', Ashish Sangwan
Fix potential null pointer dereferencing problem caused by e43bb4e612
("ext4: decrement free clusters/inodes counters when block group declared bad")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
fs/ext4/ialloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index a87455d..6bfe7eb 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -338,7 +338,7 @@ out:
fatal = err;
} else {
ext4_error(sb, "bit already cleared for inode %lu", ino);
- if (!EXT4_MB_GRP_IBITMAP_CORRUPT(grp)) {
+ if (gdp && !EXT4_MB_GRP_IBITMAP_CORRUPT(grp)) {
int count;
count = ext4_free_inodes_count(sb, gdp);
percpu_counter_sub(&sbi->s_freeinodes_counter,
--
1.7.11-rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ext4: fix potential null pointer dereference in ext4_free_inode
2014-07-08 5:41 [PATCH] ext4: fix potential null pointer dereference in ext4_free_inode Namjae Jeon
@ 2014-07-08 11:00 ` Lukáš Czerner
0 siblings, 0 replies; 2+ messages in thread
From: Lukáš Czerner @ 2014-07-08 11:00 UTC (permalink / raw)
To: Namjae Jeon
Cc: Theodore Ts'o, linux-ext4, 'Dan Carpenter',
Ashish Sangwan
On Tue, 8 Jul 2014, Namjae Jeon wrote:
> Date: Tue, 08 Jul 2014 14:41:22 +0900
> From: Namjae Jeon <namjae.jeon@samsung.com>
> To: Theodore Ts'o <tytso@mit.edu>
> Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
> 'Dan Carpenter' <dan.carpenter@oracle.com>,
> Ashish Sangwan <a.sangwan@samsung.com>
> Subject: [PATCH] ext4: fix potential null pointer dereference in
> ext4_free_inode
>
> Fix potential null pointer dereferencing problem caused by e43bb4e612
> ("ext4: decrement free clusters/inodes counters when block group declared bad")
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Looks good.
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
> ---
> fs/ext4/ialloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index a87455d..6bfe7eb 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -338,7 +338,7 @@ out:
> fatal = err;
> } else {
> ext4_error(sb, "bit already cleared for inode %lu", ino);
> - if (!EXT4_MB_GRP_IBITMAP_CORRUPT(grp)) {
> + if (gdp && !EXT4_MB_GRP_IBITMAP_CORRUPT(grp)) {
> int count;
> count = ext4_free_inodes_count(sb, gdp);
> percpu_counter_sub(&sbi->s_freeinodes_counter,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-08 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-08 5:41 [PATCH] ext4: fix potential null pointer dereference in ext4_free_inode Namjae Jeon
2014-07-08 11:00 ` Lukáš Czerner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox