* [PATCH] Add i_version_hi for 64-bit version
@ 2007-03-18 10:13 Kalpak Shah
2007-03-19 15:34 ` Dave Kleikamp
2007-04-02 21:47 ` Mingming Cao
0 siblings, 2 replies; 5+ messages in thread
From: Kalpak Shah @ 2007-03-18 10:13 UTC (permalink / raw)
To: linux-ext4; +Cc: Andreas Dilger, TheodoreTso, Dave Kleikamp, Eric Sandeen
Hi,
This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits in osd1.linux1.l_i_version.
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: Kalpak Shah <kalpak@clusterfs.com>
Index: linux-2.6.20/include/linux/ext4_fs.h
===================================================================
--- linux-2.6.20.orig/include/linux/ext4_fs.h
+++ linux-2.6.20/include/linux/ext4_fs.h
@@ -336,6 +336,7 @@ struct ext4_inode {
__le32 i_atime_extra; /* extra Access time (nsec << 2 | epoch) */
__le32 i_crtime; /* File Creation time */
__le32 i_crtime_extra; /* extra File Creation time (nsec << 2 | epoch) */
+ __u32 i_version_hi; /* high 32 bits for 64-bit version */
};
#define i_size_high i_dir_acl
Thanks,
Kalpak <kalpak@clusterfs.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Add i_version_hi for 64-bit version
2007-03-18 10:13 [PATCH] Add i_version_hi for 64-bit version Kalpak Shah
@ 2007-03-19 15:34 ` Dave Kleikamp
2007-04-02 21:47 ` Mingming Cao
1 sibling, 0 replies; 5+ messages in thread
From: Dave Kleikamp @ 2007-03-19 15:34 UTC (permalink / raw)
To: Kalpak Shah; +Cc: linux-ext4, Andreas Dilger, TheodoreTso, Eric Sandeen
On Sun, 2007-03-18 at 15:43 +0530, Kalpak Shah wrote:
> Hi,
>
> This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits in osd1.linux1.l_i_version.
>
> Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
> Signed-off-by: Kalpak Shah <kalpak@clusterfs.com>
>
> Index: linux-2.6.20/include/linux/ext4_fs.h
> ===================================================================
> --- linux-2.6.20.orig/include/linux/ext4_fs.h
> +++ linux-2.6.20/include/linux/ext4_fs.h
> @@ -336,6 +336,7 @@ struct ext4_inode {
> __le32 i_atime_extra; /* extra Access time (nsec << 2 | epoch) */
> __le32 i_crtime; /* File Creation time */
> __le32 i_crtime_extra; /* extra File Creation time (nsec << 2 | epoch) */
> + __u32 i_version_hi; /* high 32 bits for 64-bit version */
> };
This is whitespace damaged. I see spaces instead of tabs.
>
> #define i_size_high i_dir_acl
>
> Thanks,
> Kalpak <kalpak@clusterfs.com>
Thanks,
Shaggy
--
David Kleikamp
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Add i_version_hi for 64-bit version
2007-03-18 10:13 [PATCH] Add i_version_hi for 64-bit version Kalpak Shah
2007-03-19 15:34 ` Dave Kleikamp
@ 2007-04-02 21:47 ` Mingming Cao
2007-04-02 23:29 ` Andreas Dilger
1 sibling, 1 reply; 5+ messages in thread
From: Mingming Cao @ 2007-04-02 21:47 UTC (permalink / raw)
To: Kalpak Shah
Cc: linux-ext4, Andreas Dilger, TheodoreTso, Dave Kleikamp,
Eric Sandeen
On Sun, 2007-03-18 at 15:43 +0530, Kalpak Shah wrote:
> Hi,
>
> This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits in osd1.linux1.l_i_version.
>
> Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
> Signed-off-by: Kalpak Shah <kalpak@clusterfs.com>
>
> Index: linux-2.6.20/include/linux/ext4_fs.h
> ===================================================================
> --- linux-2.6.20.orig/include/linux/ext4_fs.h
> +++ linux-2.6.20/include/linux/ext4_fs.h
> @@ -336,6 +336,7 @@ struct ext4_inode {
> __le32 i_atime_extra; /* extra Access time (nsec << 2 | epoch) */
> __le32 i_crtime; /* File Creation time */
> __le32 i_crtime_extra; /* extra File Creation time (nsec << 2 | epoch) */
> + __u32 i_version_hi; /* high 32 bits for 64-bit version */
> };
>
Any reason not using __le32 for the i_version_hi?
Thanks,
Mingming
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Add i_version_hi for 64-bit version
2007-04-02 21:47 ` Mingming Cao
@ 2007-04-02 23:29 ` Andreas Dilger
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Dilger @ 2007-04-02 23:29 UTC (permalink / raw)
To: Mingming Cao
Cc: Kalpak Shah, linux-ext4, TheodoreTso, Dave Kleikamp, Eric Sandeen
On Apr 02, 2007 14:47 -0700, Mingming Cao wrote:
> On Sun, 2007-03-18 at 15:43 +0530, Kalpak Shah wrote:
> > This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits in osd1.linux1.l_i_version.
> >
> > Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
> > Signed-off-by: Kalpak Shah <kalpak@clusterfs.com>
> >
> > Index: linux-2.6.20/include/linux/ext4_fs.h
> > ===================================================================
> > --- linux-2.6.20.orig/include/linux/ext4_fs.h
> > +++ linux-2.6.20/include/linux/ext4_fs.h
> > @@ -336,6 +336,7 @@ struct ext4_inode {
> > __le32 i_atime_extra; /* extra Access time (nsec << 2 | epoch) */
> > __le32 i_crtime; /* File Creation time */
> > __le32 i_crtime_extra; /* extra File Creation time (nsec << 2 | epoch) */
> > + __u32 i_version_hi; /* high 32 bits for 64-bit version */
> > };
> >
>
> Any reason not using __le32 for the i_version_hi?
Not really. I've also asked Kalpak to run sparse with Shaggy's flags
against the other patches to fix up any similar issues.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Add i_version_hi for 64-bit version
@ 2007-04-03 6:56 Kalpak Shah
0 siblings, 0 replies; 5+ messages in thread
From: Kalpak Shah @ 2007-04-03 6:56 UTC (permalink / raw)
To: linux-ext4; +Cc: Andreas Dilger, Mingming Cao, Dave Kleikamp
Hi,
I have changed the i_version_hi field to a le32 and also cleaned up the whitespace.
This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions.
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: Kalpak Shah <kalpak@clusterfs.com>
Index: linux-2.6.19/include/linux/ext4_fs.h
===================================================================
--- linux-2.6.19.orig/include/linux/ext4_fs.h
+++ linux-2.6.19/include/linux/ext4_fs.h
@@ -336,6 +336,7 @@ struct ext4_inode {
__le32 i_atime_extra; /* extra Access time (nsec << 2 | epoch) */
__le32 i_crtime; /* File Creation time */
__le32 i_crtime_extra; /* extra File Creation time (nsec << 2 | epoch) */
+ __le32 i_version_hi; /* high 32 bits for 64-bit version */
};
#define i_size_high i_dir_acl
Thanks,
Kalpak Shah.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-04-03 6:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-18 10:13 [PATCH] Add i_version_hi for 64-bit version Kalpak Shah
2007-03-19 15:34 ` Dave Kleikamp
2007-04-02 21:47 ` Mingming Cao
2007-04-02 23:29 ` Andreas Dilger
-- strict thread matches above, loose matches on Subject: below --
2007-04-03 6:56 Kalpak Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox