public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/6] inode version updated patches
@ 2007-06-14 15:56 Kalpak Shah
  2007-06-14 20:48 ` Mingming Cao
  0 siblings, 1 reply; 3+ messages in thread
From: Kalpak Shah @ 2007-06-14 15:56 UTC (permalink / raw)
  To: linux-ext4; +Cc: Andreas Dilger, Jean noel Cordenner

Hi,

I have updated the inode version patches and below are the details:

64-bit-i_version.patch which only replaces the 32-bit i_version field in
the generic inode with a 64-bit i_version field. The VFS-level updates
of the inode version are still in the i_version_update_vfs.patch and
this patch has been moved to the bottom of the patch series.

ext4_i_version_hi_2.patch was still using ei->i_fs_version instead of
inode->i_version. I have corrected this patch.

Also there were whitespace problems in i_version_hi.patch.

I am also attaching a ext4_no_version.patch which adds a "noversion"
mount option to disable inode version updates.

I am not sure why i_version needs to be updated in VFS since it is being
updated in ext4_mark_iloc_dirty().

Well, these are lots of small patches and I am sending them separately
so that they can be applied and commented upon easily.

Thanks,
Kalpak.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/6] inode version updated patches
  2007-06-14 15:56 [PATCH 0/6] inode version updated patches Kalpak Shah
@ 2007-06-14 20:48 ` Mingming Cao
  2007-06-15 14:28   ` Jean noel Cordenner
  0 siblings, 1 reply; 3+ messages in thread
From: Mingming Cao @ 2007-06-14 20:48 UTC (permalink / raw)
  To: Kalpak Shah; +Cc: linux-ext4, Andreas Dilger, Jean noel Cordenner

On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote:
> Hi,
> 
> I have updated the inode version patches and below are the details:
> 
> 64-bit-i_version.patch which only replaces the 32-bit i_version field in
> the generic inode with a 64-bit i_version field. The VFS-level updates
> of the inode version are still in the i_version_update_vfs.patch and
> this patch has been moved to the bottom of the patch series.
> 
> ext4_i_version_hi_2.patch was still using ei->i_fs_version instead of
> inode->i_version. I have corrected this patch.
> 
> Also there were whitespace problems in i_version_hi.patch.
> 
> I am also attaching a ext4_no_version.patch which adds a "noversion"
> mount option to disable inode version updates.
> 
> I am not sure why i_version needs to be updated in VFS since it is being
> updated in ext4_mark_iloc_dirty().
> 

Yes I think we can remove the inode version update in VFS patch. So I am
going to drop the patch 5/6.  Jean Noel, if you disagree, please let me
know.

> Well, these are lots of small patches and I am sending them separately
> so that they can be applied and commented upon easily.
> 

Thanks, I will update the patch queue with your patch series.

Mingming
> Thanks,
> Kalpak.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/6] inode version updated patches
  2007-06-14 20:48 ` Mingming Cao
@ 2007-06-15 14:28   ` Jean noel Cordenner
  0 siblings, 0 replies; 3+ messages in thread
From: Jean noel Cordenner @ 2007-06-15 14:28 UTC (permalink / raw)
  To: cmm; +Cc: Kalpak Shah, linux-ext4, Andreas Dilger

Mingming Cao a écrit :
> On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote:
>> Hi,
>>
>> I have updated the inode version patches and below are the details:
>>
>> 64-bit-i_version.patch which only replaces the 32-bit i_version field in
>> the generic inode with a 64-bit i_version field. The VFS-level updates
>> of the inode version are still in the i_version_update_vfs.patch and
>> this patch has been moved to the bottom of the patch series.
>>
>> ext4_i_version_hi_2.patch was still using ei->i_fs_version instead of
>> inode->i_version. I have corrected this patch.
>>
>> Also there were whitespace problems in i_version_hi.patch.
>>
>> I am also attaching a ext4_no_version.patch which adds a "noversion"
>> mount option to disable inode version updates.
>>
>> I am not sure why i_version needs to be updated in VFS since it is being
>> updated in ext4_mark_iloc_dirty().
>>
> 
> Yes I think we can remove the inode version update in VFS patch. So I am
> going to drop the patch 5/6.  Jean Noel, if you disagree, please let me
> know.
> 

I agree, the update of the i_version in the vfs are done in
simple_rename() , simple_link() , simple_unlink() , which are mainly 
used by fs/ramfs and fs/hugetlbfs. So I think if each fs can update the 
i_version, that will be good.

Jean noel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-06-15 14:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-14 15:56 [PATCH 0/6] inode version updated patches Kalpak Shah
2007-06-14 20:48 ` Mingming Cao
2007-06-15 14:28   ` Jean noel Cordenner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox