public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Girish Shilamkar <girish@clusterfs.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: Avantika Mathur <mathur@linux.vnet.ibm.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] uninitialized groups ported - kernel
Date: Wed, 20 Jun 2007 17:26:20 +0530	[thread overview]
Message-ID: <1182340580.3819.3.camel@dhcp7.linsyssoft.com> (raw)
In-Reply-To: <20070619075034.GQ5181@schatzie.adilger.int>

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]


> 
> I've asked Girish to send an incremental patch.
> 
Here is the incremental patch,  to be applied after the patch sent by
Avantika for 2.6.22-rc4 kernel.

Regards,
Girish.

[-- Attachment #2: update-uninit.patch --]
[-- Type: text/x-patch, Size: 1558 bytes --]

Index: linux-2.6.22-rc4/fs/ext4/super.c
===================================================================
--- linux-2.6.22-rc4.orig/fs/ext4/super.c
+++ linux-2.6.22-rc4/fs/ext4/super.c
@@ -1298,9 +1298,12 @@ __le16 ext4_group_desc_csum(struct ext4_
 		offset += sizeof(gdp->bg_checksum); /* skip checksum */
 		/*BUG_ON(offset != sizeof(*gdp)); /* XXX handle s_desc_size */
 		/* for checksum of struct ext4_group_desc do the rest...*/
-		if (offset < sbi->s_es->s_desc_size) {
+		if ((sbi->s_es->s_feature_incompat &
+		     cpu_to_le32(EXT4_FEATURE_INCOMPAT_64BIT)) && 
+		    offset < le16_to_cpu(sbi->s_es->s_desc_size)) {
 			crc = crc16(crc, (__u8 *)gdp + offset,
-				    sbi->s_es->s_desc_size - offset);
+				    le16_to_cpu(sbi->s_es->s_desc_size)
+					- offset);
 		} 
 	}
 
Index: linux-2.6.22-rc4/include/linux/ext4_fs.h
===================================================================
--- linux-2.6.22-rc4.orig/include/linux/ext4_fs.h
+++ linux-2.6.22-rc4/include/linux/ext4_fs.h
@@ -687,11 +687,11 @@ static inline int ext4_valid_inum(struct
 #define EXT4_FEATURE_COMPAT_EXT_ATTR		0x0008
 #define EXT4_FEATURE_COMPAT_RESIZE_INODE	0x0010
 #define EXT4_FEATURE_COMPAT_DIR_INDEX		0x0020
-#define EXT4_FEATURE_RO_COMPAT_GDT_CSUM		0x0040
 
 #define EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER	0x0001
 #define EXT4_FEATURE_RO_COMPAT_LARGE_FILE	0x0002
 #define EXT4_FEATURE_RO_COMPAT_BTREE_DIR	0x0004
+#define EXT4_FEATURE_RO_COMPAT_GDT_CSUM		0x0010
 #define EXT4_FEATURE_RO_COMPAT_DIR_NLINK	0x0020
 #define EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE	0x0040
 

  reply	other threads:[~2007-06-20 11:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-05 17:48 [PATCH] uninitialized groups ported - kernel Avantika Mathur
2007-06-05 18:48 ` Eric Sandeen
2007-06-05 21:20   ` Andreas Dilger
2007-06-19  4:04     ` Avantika Mathur
2007-06-19  7:50       ` Andreas Dilger
2007-06-20 11:56         ` Girish Shilamkar [this message]
2007-06-21 17:37           ` Andreas Dilger
2007-06-21 23:54             ` Avantika Mathur
2007-06-22 16:04               ` Andreas Dilger
2007-06-22 16:20               ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182340580.3819.3.camel@dhcp7.linsyssoft.com \
    --to=girish@clusterfs.com \
    --cc=adilger@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mathur@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox