From: Andreas Dilger <adilger@clusterfs.com>
To: Girish Shilamkar <girish@clusterfs.com>
Cc: Avantika Mathur <mathur@linux.vnet.ibm.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] uninitialized groups ported - kernel
Date: Thu, 21 Jun 2007 11:37:57 -0600 [thread overview]
Message-ID: <20070621173757.GA1075@schatzie.adilger.int> (raw)
In-Reply-To: <1182340580.3819.3.camel@dhcp7.linsyssoft.com>
On Jun 20, 2007 17:26 +0530, Girish Shilamkar wrote:
> crc = crc16(crc, (__u8 *)gdp + offset,
> - sbi->s_es->s_desc_size - offset);
> + le16_to_cpu(sbi->s_es->s_desc_size)
> + - offset);
Minor nit - please put '-' at the end of the previous line, and align
"offset" with '(sbi-> ...'.
Also, we're missing the signoff:
Signed-off-by: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: Girish Shilamkar <girish@clusterfs.com>
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
next prev parent reply other threads:[~2007-06-21 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 17:48 [PATCH] uninitialized groups ported - kernel Avantika Mathur
2007-06-05 18:48 ` Eric Sandeen
2007-06-05 21:20 ` Andreas Dilger
2007-06-19 4:04 ` Avantika Mathur
2007-06-19 7:50 ` Andreas Dilger
2007-06-20 11:56 ` Girish Shilamkar
2007-06-21 17:37 ` Andreas Dilger [this message]
2007-06-21 23:54 ` Avantika Mathur
2007-06-22 16:04 ` Andreas Dilger
2007-06-22 16:20 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070621173757.GA1075@schatzie.adilger.int \
--to=adilger@clusterfs.com \
--cc=girish@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mathur@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox