* [PATCH 1/4] ext4: minor fix in jbd2 stats kmalloc failure case
@ 2007-12-03 23:29 Eric Sandeen
2007-12-04 0:23 ` Mingming Cao
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2007-12-03 23:29 UTC (permalink / raw)
To: ext4 development
(Mingming: these 4 patches can apply after
jbd-stats-through-procfs-with-external-journal-oops-fix.patch)
---------------------------------------------------------------------
The other instance of this problem was caught, but this one got missed:
Free the correct pointer on s->stats allocation failure in jbd2_seq_info_open
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Index: linux-2.6.24-rc3/fs/jbd2/journal.c
===================================================================
--- linux-2.6.24-rc3.orig/fs/jbd2/journal.c
+++ linux-2.6.24-rc3/fs/jbd2/journal.c
@@ -850,7 +850,7 @@ static int jbd2_seq_info_open(struct ino
return -EIO;
size = sizeof(struct transaction_stats_s);
s->stats = kmalloc(size, GFP_KERNEL);
- if (s == NULL) {
+ if (s->stats == NULL) {
kfree(s);
return -EIO;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-04 0:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-03 23:29 [PATCH 1/4] ext4: minor fix in jbd2 stats kmalloc failure case Eric Sandeen
2007-12-04 0:23 ` Mingming Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox