public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Mingming Cao <cmm@us.ibm.com>
To: Shen Feng <shen@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org, Theodore Tso <tytso@MIT.EDU>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ext4: return error when calling ext4_ext_split failed
Date: Thu, 12 Jun 2008 15:20:00 -0700	[thread overview]
Message-ID: <1213309200.3698.15.camel@localhost.localdomain> (raw)
In-Reply-To: <484F696A.4070703@cn.fujitsu.com>

I have added to ext4 patch queue

Mingming
On Wed, 2008-06-11 at 13:58 +0800, Shen Feng wrote:
> ext4_ext_create_new_leaf must return error when its
> calling to ext4_ext_split failed.
> 
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
> ---
>  fs/ext4/extents.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ff609df..177345d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -981,6 +981,8 @@ repeat:
>  		/* if we found index with free entry, then use that
>  		 * entry: create all needed subtree and add new leaf */
>  		err = ext4_ext_split(handle, inode, path, newext, i);
> +		if (err)
> +			goto out;
> 
>  		/* refill path */
>  		ext4_ext_drop_refs(path);


      parent reply	other threads:[~2008-06-12 22:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11  5:58 [PATCH] ext4: return error when calling ext4_ext_split failed Shen Feng
2008-06-11 11:39 ` Aneesh Kumar K.V
2008-06-12 22:20 ` Mingming Cao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213309200.3698.15.camel@localhost.localdomain \
    --to=cmm@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=shen@cn.fujitsu.com \
    --cc=tytso@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox