From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Shen Feng <shen@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org, Theodore Tso <tytso@MIT.EDU>,
Mingming Cao <cmm@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ext4: return error when calling ext4_ext_split failed
Date: Wed, 11 Jun 2008 17:09:17 +0530 [thread overview]
Message-ID: <20080611113917.GA12998@skywalker> (raw)
In-Reply-To: <484F696A.4070703@cn.fujitsu.com>
On Wed, Jun 11, 2008 at 01:58:02PM +0800, Shen Feng wrote:
>
> ext4_ext_create_new_leaf must return error when its
> calling to ext4_ext_split failed.
>
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
> fs/ext4/extents.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ff609df..177345d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -981,6 +981,8 @@ repeat:
> /* if we found index with free entry, then use that
> * entry: create all needed subtree and add new leaf */
> err = ext4_ext_split(handle, inode, path, newext, i);
> + if (err)
> + goto out;
>
> /* refill path */
> ext4_ext_drop_refs(path);
> --
> 1.5.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-11 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 5:58 [PATCH] ext4: return error when calling ext4_ext_split failed Shen Feng
2008-06-11 11:39 ` Aneesh Kumar K.V [this message]
2008-06-12 22:20 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611113917.GA12998@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shen@cn.fujitsu.com \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox