* [PATCH] ext4: return error when calling ext4_ext_split failed
@ 2008-06-11 5:58 Shen Feng
2008-06-11 11:39 ` Aneesh Kumar K.V
2008-06-12 22:20 ` Mingming Cao
0 siblings, 2 replies; 3+ messages in thread
From: Shen Feng @ 2008-06-11 5:58 UTC (permalink / raw)
To: linux-ext4, Theodore Tso, Mingming Cao, Andrew Morton
ext4_ext_create_new_leaf must return error when its
calling to ext4_ext_split failed.
Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
---
fs/ext4/extents.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ff609df..177345d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -981,6 +981,8 @@ repeat:
/* if we found index with free entry, then use that
* entry: create all needed subtree and add new leaf */
err = ext4_ext_split(handle, inode, path, newext, i);
+ if (err)
+ goto out;
/* refill path */
ext4_ext_drop_refs(path);
--
1.5.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: return error when calling ext4_ext_split failed
2008-06-11 5:58 [PATCH] ext4: return error when calling ext4_ext_split failed Shen Feng
@ 2008-06-11 11:39 ` Aneesh Kumar K.V
2008-06-12 22:20 ` Mingming Cao
1 sibling, 0 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2008-06-11 11:39 UTC (permalink / raw)
To: Shen Feng; +Cc: linux-ext4, Theodore Tso, Mingming Cao, Andrew Morton
On Wed, Jun 11, 2008 at 01:58:02PM +0800, Shen Feng wrote:
>
> ext4_ext_create_new_leaf must return error when its
> calling to ext4_ext_split failed.
>
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
> fs/ext4/extents.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ff609df..177345d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -981,6 +981,8 @@ repeat:
> /* if we found index with free entry, then use that
> * entry: create all needed subtree and add new leaf */
> err = ext4_ext_split(handle, inode, path, newext, i);
> + if (err)
> + goto out;
>
> /* refill path */
> ext4_ext_drop_refs(path);
> --
> 1.5.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: return error when calling ext4_ext_split failed
2008-06-11 5:58 [PATCH] ext4: return error when calling ext4_ext_split failed Shen Feng
2008-06-11 11:39 ` Aneesh Kumar K.V
@ 2008-06-12 22:20 ` Mingming Cao
1 sibling, 0 replies; 3+ messages in thread
From: Mingming Cao @ 2008-06-12 22:20 UTC (permalink / raw)
To: Shen Feng; +Cc: linux-ext4, Theodore Tso, Andrew Morton
I have added to ext4 patch queue
Mingming
On Wed, 2008-06-11 at 13:58 +0800, Shen Feng wrote:
> ext4_ext_create_new_leaf must return error when its
> calling to ext4_ext_split failed.
>
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
> ---
> fs/ext4/extents.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ff609df..177345d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -981,6 +981,8 @@ repeat:
> /* if we found index with free entry, then use that
> * entry: create all needed subtree and add new leaf */
> err = ext4_ext_split(handle, inode, path, newext, i);
> + if (err)
> + goto out;
>
> /* refill path */
> ext4_ext_drop_refs(path);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-12 22:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-11 5:58 [PATCH] ext4: return error when calling ext4_ext_split failed Shen Feng
2008-06-11 11:39 ` Aneesh Kumar K.V
2008-06-12 22:20 ` Mingming Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox