public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: cmm@us.ibm.com, tytso@mit.edu, sandeen@redhat.com, jack@suse.cz
Cc: linux-ext4@vger.kernel.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH] jbd2: We shouldnot cap writeback when we are doing a journal commit
Date: Fri, 27 Jun 2008 23:37:45 +0530	[thread overview]
Message-ID: <1214590065-26891-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)

A journal commit need to make sure we submit data buffers before
we submit the meta-data buffers in ordered mode. We should
not be looking at BDI_CAP_NO_WRITEBACK when doing a journal commit.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 fs/jbd2/commit.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
index 32ca3c3..f8b3be8 100644
--- a/fs/jbd2/commit.c
+++ b/fs/jbd2/commit.c
@@ -203,9 +203,6 @@ static int journal_submit_inode_data_buffers(struct address_space *mapping)
 		.for_writepages = 1,
 	};
 
-	if (!mapping_cap_writeback_dirty(mapping))
-		return 0;

             reply	other threads:[~2008-06-27 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-27 18:07 Aneesh Kumar K.V [this message]
2008-06-27 18:11 ` [PATCH] jbd2: We shouldnot cap writeback when we are doing a journal commit Eric Sandeen
2008-06-27 21:04   ` Jan Kara
2008-06-27 23:52     ` Mingming Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214590065-26891-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox