Re: [PATCH] jbd2: We shouldnot cap writeback when we are doing a journal commit

[Eric Sandeen <sandeen@redhat.com>]

Aneesh Kumar K.V wrote:
> A journal commit need to make sure we submit data buffers before
> we submit the meta-data buffers in ordered mode. We should
> not be looking at BDI_CAP_NO_WRITEBACK when doing a journal commit.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

and I don't think we'll ever even see that flag set...

Acked-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  fs/jbd2/commit.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
> index 32ca3c3..f8b3be8 100644
> --- a/fs/jbd2/commit.c
> +++ b/fs/jbd2/commit.c
> @@ -203,9 +203,6 @@ static int journal_submit_inode_data_buffers(struct address_space *mapping)
>  		.for_writepages = 1,
>  	};
>  
> -	if (!mapping_cap_writeback_dirty(mapping))
> -		return 0;
> -
>  	ret = generic_writepages(mapping, &wbc);
>  	return ret;
>  }