public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free
@ 2008-10-13 16:14 Aneesh Kumar K.V
  2008-10-13 16:41 ` Theodore Tso
  0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2008-10-13 16:14 UTC (permalink / raw)
  To: cmm, tytso, sandeen; +Cc: linux-ext4, Aneesh Kumar K.V

We should use kmem_cache_free to free memory allocated
via kmem_cache_alloc

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 fs/ext4/mballoc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 7d5f70c..e54e03d 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2569,7 +2569,7 @@ static void ext4_mb_cleanup_pa(struct ext4_group_info *grp)
 		pa = list_entry(cur, struct ext4_prealloc_space, pa_group_list);
 		list_del(&pa->pa_group_list);
 		count++;
-		kfree(pa);
+		kmem_cache_free(ext4_pspace_cachep, pa);
 	}
 	if (count)
 		mb_debug("mballoc: %u PAs left\n", count);
-- 
1.6.0.2.526.g5c283


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free
  2008-10-13 16:14 [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free Aneesh Kumar K.V
@ 2008-10-13 16:41 ` Theodore Tso
  0 siblings, 0 replies; 3+ messages in thread
From: Theodore Tso @ 2008-10-13 16:41 UTC (permalink / raw)
  To: Aneesh Kumar K.V; +Cc: cmm, sandeen, linux-ext4

On Mon, Oct 13, 2008 at 09:44:03PM +0530, Aneesh Kumar K.V wrote:
> We should use kmem_cache_free to free memory allocated
> via kmem_cache_alloc

Thanks, queued.

						- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free
  2008-10-14  6:33         ` [PATCH] ext4: Fix file fragmentation during large file write Aneesh Kumar K.V
@ 2008-10-14  6:33           ` Aneesh Kumar K.V
  0 siblings, 0 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2008-10-14  6:33 UTC (permalink / raw)
  To: aneesh.kumar, cmm, tytso, sandeen; +Cc: linux-ext4

We should use kmem_cache_free to free memory allocated
via kmem_cache_alloc

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 fs/ext4/mballoc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 7023228..c22b904 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2569,7 +2569,7 @@ static void ext4_mb_cleanup_pa(struct ext4_group_info *grp)
 		pa = list_entry(cur, struct ext4_prealloc_space, pa_group_list);
 		list_del(&pa->pa_group_list);
 		count++;
-		kfree(pa);
+		kmem_cache_free(ext4_pspace_cachep, pa);
 	}
 	if (count)
 		mb_debug("mballoc: %u PAs left\n", count);
-- 
1.6.0.2.526.g5c283


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-10-14  6:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-13 16:14 [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free Aneesh Kumar K.V
2008-10-13 16:41 ` Theodore Tso
  -- strict thread matches above, loose matches on Subject: below --
2008-10-14  6:33 Patches for patchqueue Aneesh Kumar K.V
2008-10-14  6:33 ` [PATCH -V5] ext4: Use an rbtree for tracking blocks freed during transaction Aneesh Kumar K.V
2008-10-14  6:33   ` [PATCH] ext4: Use tag dirty lookup during mpage_da_submit_io Aneesh Kumar K.V
2008-10-14  6:33     ` [PATCH] vfs: Remove the range_cont writeback mode Aneesh Kumar K.V
2008-10-14  6:33       ` [PATCH] vfs: Add no_nrwrite_update and no_index_update writeback control flags Aneesh Kumar K.V
2008-10-14  6:33         ` [PATCH] ext4: Fix file fragmentation during large file write Aneesh Kumar K.V
2008-10-14  6:33           ` [PATCH] ext4: Free ext4_prealloc_space using kmem_cache_free Aneesh Kumar K.V

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox