public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] In mke2fs, accept a human readable size as input to the 'bytes-per-inode' argument.
@ 2015-11-15 15:24 Matthieu Dupont
  2015-11-16  1:10 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Dupont @ 2015-11-15 15:24 UTC (permalink / raw)
  To: linux-ext4

Signed-off-by: Matthieu Dupont <matt.59491@gmail.com>
---
 misc/mke2fs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 179a4d1..8d61212 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -1646,10 +1646,9 @@ profile_error:
 			}
 			break;
 		case 'i':
-			inode_ratio = strtoul(optarg, &tmp, 0);
+			inode_ratio = parse_num_blocks(optarg, -1);
 			if (inode_ratio < EXT2_MIN_BLOCK_SIZE ||
-			    inode_ratio > EXT2_MAX_BLOCK_SIZE * 1024 ||
-			    *tmp) {
+			    inode_ratio > EXT2_MAX_BLOCK_SIZE * 1024) {
 				com_err(program_name, 0,
 					_("invalid inode ratio %s (min %d/max %d)"),
 					optarg, EXT2_MIN_BLOCK_SIZE,
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] In mke2fs, accept a human readable size as input to the 'bytes-per-inode' argument.
  2015-11-15 15:24 [PATCH] In mke2fs, accept a human readable size as input to the 'bytes-per-inode' argument Matthieu Dupont
@ 2015-11-16  1:10 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2015-11-16  1:10 UTC (permalink / raw)
  To: Matthieu Dupont; +Cc: linux-ext4

On Sun, Nov 15, 2015 at 04:24:54PM +0100, Matthieu Dupont wrote:
> Signed-off-by: Matthieu Dupont <matt.59491@gmail.com>

Thanks, applied.

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-16  1:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-15 15:24 [PATCH] In mke2fs, accept a human readable size as input to the 'bytes-per-inode' argument Matthieu Dupont
2015-11-16  1:10 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox