* [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion
@ 2016-09-14 19:27 Eric Biggers
2016-09-14 21:09 ` Andreas Dilger
2016-09-15 22:24 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2016-09-14 19:27 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel, Eric Biggers
An obsolete comment and extra parentheses were left over from when the
sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
include/linux/blockgroup_lock.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/include/linux/blockgroup_lock.h b/include/linux/blockgroup_lock.h
index e44b88b..61b583d 100644
--- a/include/linux/blockgroup_lock.h
+++ b/include/linux/blockgroup_lock.h
@@ -49,14 +49,10 @@ static inline void bgl_lock_init(struct blockgroup_lock *bgl)
spin_lock_init(&bgl->locks[i].lock);
}
-/*
- * The accessor is a macro so we can embed a blockgroup_lock into different
- * superblock types
- */
static inline spinlock_t *
bgl_lock_ptr(struct blockgroup_lock *bgl, unsigned int block_group)
{
- return &bgl->locks[(block_group) & (NR_BG_LOCKS-1)].lock;
+ return &bgl->locks[block_group & (NR_BG_LOCKS-1)].lock;
}
#endif
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion
2016-09-14 19:27 [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion Eric Biggers
@ 2016-09-14 21:09 ` Andreas Dilger
2016-09-15 22:24 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Dilger @ 2016-09-14 21:09 UTC (permalink / raw)
To: Eric Biggers; +Cc: Theodore Ts'o, linux-ext4, LKML
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On Sep 14, 2016, at 1:27 PM, Eric Biggers <ebiggers@google.com> wrote:
>
> An obsolete comment and extra parentheses were left over from when the
> sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> include/linux/blockgroup_lock.h | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/include/linux/blockgroup_lock.h b/include/linux/blockgroup_lock.h
> index e44b88b..61b583d 100644
> --- a/include/linux/blockgroup_lock.h
> +++ b/include/linux/blockgroup_lock.h
> @@ -49,14 +49,10 @@ static inline void bgl_lock_init(struct blockgroup_lock *bgl)
> spin_lock_init(&bgl->locks[i].lock);
> }
>
> -/*
> - * The accessor is a macro so we can embed a blockgroup_lock into different
> - * superblock types
> - */
> static inline spinlock_t *
> bgl_lock_ptr(struct blockgroup_lock *bgl, unsigned int block_group)
> {
> - return &bgl->locks[(block_group) & (NR_BG_LOCKS-1)].lock;
> + return &bgl->locks[block_group & (NR_BG_LOCKS-1)].lock;
> }
>
> #endif
> --
> 2.8.0.rc3.226.g39d4020
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion
2016-09-14 19:27 [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion Eric Biggers
2016-09-14 21:09 ` Andreas Dilger
@ 2016-09-15 22:24 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2016-09-15 22:24 UTC (permalink / raw)
To: Eric Biggers; +Cc: adilger.kernel, linux-ext4, linux-kernel
On Wed, Sep 14, 2016 at 12:27:59PM -0700, Eric Biggers wrote:
> An obsolete comment and extra parentheses were left over from when the
> sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-15 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-14 19:27 [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion Eric Biggers
2016-09-14 21:09 ` Andreas Dilger
2016-09-15 22:24 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox