public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Mike Snitzer" <snitzer@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Steven Rostedt" <rostedt@goodmis.org>
Subject: why unlikely(rsv) in ext3_clear_inode()?
Date: Mon, 27 Oct 2008 18:29:10 -0400	[thread overview]
Message-ID: <170fa0d20810271529g3c64ae89me29ed8b65a9c3b5e@mail.gmail.com> (raw)

Please see: e6022603b9aa7d61d20b392e69edcdbbc1789969

Having a look at the LKML archives this was raised back in 2006:
http://lkml.org/lkml/2006/6/23/337

I'm not interested in whether unlikely() actually helps here.

I'm still missing _why_ rsv is mostly NULL at this callsite, as Andrew
asserted here:
http://lkml.org/lkml/2006/6/23/400

And then Steve here: http://lkml.org/lkml/2006/6/24/76
Where he said:
"The problem is that in these cases the pointer is NULL several thousands
of times for every time it is not NULL (if ever).  The non-NULL case is
where an error occurred or something very special.  So I don't see how
the if here is a problem?"

I'm missing which error or what "something very special" is the
unlikely() reason for having rsv be NULL.

Looking at the code; ext3_clear_inode() is _the_ place where the
i_block_alloc_info is cleaned up.  In my testing the rsv is _never_
NULL if the file was open for writing.  Are we saying that reads are
much more common than writes?  May be a reasonable assumption but
saying as much is very different than what Steve seemed to be eluding
to...

Anyway, I'd appreciate some clarification here.

thanks,
Mike

             reply	other threads:[~2008-10-27 22:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 22:29 Mike Snitzer [this message]
2008-10-27 22:53 ` why unlikely(rsv) in ext3_clear_inode()? Steven Rostedt
2008-10-27 23:32 ` Steven Rostedt
2008-10-27 23:48   ` Andrew Morton
2008-10-28  0:13   ` Theodore Tso
2008-10-28  0:21     ` Steven Rostedt
2008-10-28  0:14   ` Mike Snitzer
2008-10-27 23:52 ` Mingming Cao
2008-10-28  0:09   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170fa0d20810271529g3c64ae89me29ed8b65a9c3b5e@mail.gmail.com \
    --to=snitzer@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox