From: Steven Rostedt <rostedt@goodmis.org>
To: Theodore Tso <tytso@mit.edu>
Cc: Mike Snitzer <snitzer@gmail.com>,
linux-ext4@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: why unlikely(rsv) in ext3_clear_inode()?
Date: Mon, 27 Oct 2008 20:21:58 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0810272021010.20353@gandalf.stny.rr.com> (raw)
In-Reply-To: <20081028001340.GB9797@mit.edu>
On Mon, 27 Oct 2008, Theodore Tso wrote:
> On Mon, Oct 27, 2008 at 07:32:11PM -0400, Steven Rostedt wrote:
> > Attached is a patch that I used for counting.
> >
> > Here's my results:
> > # cat /debug/tracing/ftrace_null
> > 45
> > # cat /debug/tracing/ftrace_nonnull
> > 7
> >
> > Ah, seems that there is cases where it is nonnull more often. Anyway, it
> > obviously is not a fast path (total of 52). Even if it was all null, it is
> > not big enough to call for the confusion.
>
> Silly question --- what was your test workload?
Hehe, I just booted the box. The counting started right away, so I just
looked at the work load.
Anyway, I'm writing a generic "unlikely" profiler that should make Andrew
happy. And this will also catch this case as well.
-- Steve
next prev parent reply other threads:[~2008-10-28 0:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 22:29 why unlikely(rsv) in ext3_clear_inode()? Mike Snitzer
2008-10-27 22:53 ` Steven Rostedt
2008-10-27 23:32 ` Steven Rostedt
2008-10-27 23:48 ` Andrew Morton
2008-10-28 0:13 ` Theodore Tso
2008-10-28 0:21 ` Steven Rostedt [this message]
2008-10-28 0:14 ` Mike Snitzer
2008-10-27 23:52 ` Mingming Cao
2008-10-28 0:09 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0810272021010.20353@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=snitzer@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox