From: Jason Yan <yanaijie@huawei.com>
To: Baokun Li <libaokun1@huawei.com>, <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jack@suse.cz>,
<ritesh.list@gmail.com>, <linux-kernel@vger.kernel.org>,
<yi.zhang@huawei.com>, <yukuai3@huawei.com>
Subject: Re: [PATCH v3 3/4] ext4: add EXT4_IGET_BAD flag to prevent unexpected bad inode
Date: Wed, 26 Oct 2022 21:59:34 +0800 [thread overview]
Message-ID: <1cb8a9de-5fb1-a6c0-3d38-479d57ae3e15@huawei.com> (raw)
In-Reply-To: <20221026042310.3839669-4-libaokun1@huawei.com>
On 2022/10/26 12:23, Baokun Li wrote:
> There are many places that will get unhappy (and crash) when ext4_iget()
> returns a bad inode. However, if iget the boot loader inode, allows a bad
> inode to be returned, because the inode may not be initialized. This
> mechanism can be used to bypass some checks and cause panic. To solve this
> problem, we add a special iget flag EXT4_IGET_BAD. Only with this flag
> we'd be returning bad inode from ext4_iget(), otherwise we always return
> the error code if the inode is bad inode.(suggested by Jan Kara)
>
> Signed-off-by: Baokun Li<libaokun1@huawei.com>
> ---
> fs/ext4/ext4.h | 3 ++-
> fs/ext4/inode.c | 8 +++++++-
> fs/ext4/ioctl.c | 3 ++-
> 3 files changed, 11 insertions(+), 3 deletions(-)
Looks good,
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2022-10-26 13:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 4:23 [PATCH v3 0/4] ext4: fix two bug_on in __es_tree_search Baokun Li
2022-10-26 4:23 ` [PATCH v3 1/4] ext4: fix bug_on in __es_tree_search caused by bad quota inode Baokun Li
2022-10-26 9:36 ` Jan Kara
2022-10-26 13:56 ` Jason Yan
2022-10-26 18:33 ` Chaitanya Kulkarni
2022-10-26 4:23 ` [PATCH v3 2/4] ext4: add helper to check quota inums Baokun Li
2022-10-26 9:38 ` Jan Kara
2022-10-26 13:57 ` Jason Yan
2022-10-26 4:23 ` [PATCH v3 3/4] ext4: add EXT4_IGET_BAD flag to prevent unexpected bad inode Baokun Li
2022-10-26 9:41 ` Jan Kara
2022-10-26 13:59 ` Jason Yan [this message]
2022-10-26 4:23 ` [PATCH v3 4/4] ext4: fix bug_on in __es_tree_search caused by bad boot loader inode Baokun Li
2022-10-26 10:12 ` Jan Kara
2022-10-26 14:05 ` Jason Yan
2022-12-06 21:01 ` [PATCH v3 0/4] ext4: fix two bug_on in __es_tree_search Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb8a9de-5fb1-a6c0-3d38-479d57ae3e15@huawei.com \
--to=yanaijie@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=libaokun1@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox